Re: RFR: 8267418: IntelliJ build and test of JavaFX does not work [v4]
On Wed, 2 Jun 2021 07:11:54 GMT, Marius Hanl wrote: >> ~~Question: I was wondering, should I create a ticket for this as well? >> Given the fact that I don't have an https://bugs.openjdk.java.net account, I >> need to use the official bug reporting tool, which looked a bit overkill to >> me since someone needs to check my created ticket, while this PR is only >> affecting the IntelliJ IDE with OpenJFX and not the JavaFX platform >> directly.~~ >> EDIT: Thank you, Kevin. :) >> >> This PR fixes the errors you get when cloning and working with OpenJFX in >> IntelliJ IDE: >> - The **.idea/misc.xml** is modified to use **JDK_11** as language level >> instead of JDK_8. >> -> This is the language level shown inside the **Project Structure**. (File >> -> Project Structure...) >> - The **.idea/base.iml, .idea/controls.iml, .idea/fxml.iml, .idea/web.iml, >> .idea/graphics.iml** are modified to include/recognize the shims (as test >> resource, this is very similar to the configuration inside the .classpath >> file from Eclipse) >> - EDIT: The projects are now recognized by IntelliJ-gradle >> (**.idea/gradle.xml**, **.idea/compiler.xml**) >> >> **-> With this, I can run all normal tests with IntelliJ** >> >> ### What I couldn't fix yet (When I tried, it looked like IntelliJ is >> overriding the settings on next gradle reload): >> - IntelliJ is not detecting javafx.graphic inside the shims >> - All javafx.* dependencies are not found for the system tests >> >> **-> If someone has a solution, feel free to comment :)** > > Marius Hanl has updated the pull request incrementally with one additional > commit since the last revision: > > Reverted whitespace made by IntelliJ Approving, I re-verified the change: Loading project in IntelliJ does not cause any other changes in idea files. - Marked as reviewed by arapte (Reviewer). PR: https://git.openjdk.java.net/jfx/pull/506
Re: RFR: 8267418: IntelliJ build and test of JavaFX does not work [v4]
On Wed, 2 Jun 2021 07:11:54 GMT, Marius Hanl wrote: >> ~~Question: I was wondering, should I create a ticket for this as well? >> Given the fact that I don't have an https://bugs.openjdk.java.net account, I >> need to use the official bug reporting tool, which looked a bit overkill to >> me since someone needs to check my created ticket, while this PR is only >> affecting the IntelliJ IDE with OpenJFX and not the JavaFX platform >> directly.~~ >> EDIT: Thank you, Kevin. :) >> >> This PR fixes the errors you get when cloning and working with OpenJFX in >> IntelliJ IDE: >> - The **.idea/misc.xml** is modified to use **JDK_11** as language level >> instead of JDK_8. >> -> This is the language level shown inside the **Project Structure**. (File >> -> Project Structure...) >> - The **.idea/base.iml, .idea/controls.iml, .idea/fxml.iml, .idea/web.iml, >> .idea/graphics.iml** are modified to include/recognize the shims (as test >> resource, this is very similar to the configuration inside the .classpath >> file from Eclipse) >> - EDIT: The projects are now recognized by IntelliJ-gradle >> (**.idea/gradle.xml**, **.idea/compiler.xml**) >> >> **-> With this, I can run all normal tests with IntelliJ** >> >> ### What I couldn't fix yet (When I tried, it looked like IntelliJ is >> overriding the settings on next gradle reload): >> - IntelliJ is not detecting javafx.graphic inside the shims >> - All javafx.* dependencies are not found for the system tests >> >> **-> If someone has a solution, feel free to comment :)** > > Marius Hanl has updated the pull request incrementally with one additional > commit since the last revision: > > Reverted whitespace made by IntelliJ The follow on is reported here: [JDK-8269244](https://bugs.openjdk.java.net/browse/JDK-8269244) - PR: https://git.openjdk.java.net/jfx/pull/506
Re: RFR: 8267418: IntelliJ build and test of JavaFX does not work [v4]
On Tue, 15 Jun 2021 17:44:43 GMT, Ambarish Rapte wrote: > ``` > diff --git a/gradle/verification-metadata.xml > b/gradle/verification-metadata.xml > index abacd0b05b..0a3d33726d 100644 > --- a/gradle/verification-metadata.xml > +++ b/gradle/verification-metadata.xml > @@ -3,6 +3,9 @@ > >true >false > + > + > + > > > > ``` > > I tested this change in addition to the PR changes, dependency verification > does not fail with this change but fails without. > Can you please verify and test this change preferably on a clean repo by > creating a new IntelliJ project. Good catch indeed! This works like a charm. I think this is a good follow-up. - PR: https://git.openjdk.java.net/jfx/pull/506
Re: RFR: 8267418: IntelliJ build and test of JavaFX does not work [v4]
On Wed, 2 Jun 2021 07:11:54 GMT, Marius Hanl wrote: >> ~~Question: I was wondering, should I create a ticket for this as well? >> Given the fact that I don't have an https://bugs.openjdk.java.net account, I >> need to use the official bug reporting tool, which looked a bit overkill to >> me since someone needs to check my created ticket, while this PR is only >> affecting the IntelliJ IDE with OpenJFX and not the JavaFX platform >> directly.~~ >> EDIT: Thank you, Kevin. :) >> >> This PR fixes the errors you get when cloning and working with OpenJFX in >> IntelliJ IDE: >> - The **.idea/misc.xml** is modified to use **JDK_11** as language level >> instead of JDK_8. >> -> This is the language level shown inside the **Project Structure**. (File >> -> Project Structure...) >> - The **.idea/base.iml, .idea/controls.iml, .idea/fxml.iml, .idea/web.iml, >> .idea/graphics.iml** are modified to include/recognize the shims (as test >> resource, this is very similar to the configuration inside the .classpath >> file from Eclipse) >> - EDIT: The projects are now recognized by IntelliJ-gradle >> (**.idea/gradle.xml**, **.idea/compiler.xml**) >> >> **-> With this, I can run all normal tests with IntelliJ** >> >> ### What I couldn't fix yet (When I tried, it looked like IntelliJ is >> overriding the settings on next gradle reload): >> - IntelliJ is not detecting javafx.graphic inside the shims >> - All javafx.* dependencies are not found for the system tests >> >> **-> If someone has a solution, feel free to comment :)** > > Marius Hanl has updated the pull request incrementally with one additional > commit since the last revision: > > Reverted whitespace made by IntelliJ Good find. If this works, it seems like a good compromise to me. We don't download any `*-sources` or `*-javadoc` artifacts in our build, but it seems that IDEs do. If we add this exclusion, I think we should do it using separate bug ID and a separate PR (requiring two reviewers, since this is an area we need to be careful about). As part of that, we would need to update the [`gradle/README.txt`](https://github.com/openjdk/jfx/blob/master/gradle/README.txt) file to let people know why the `*-sources` / `*-javadoc` exclusion is there. - PR: https://git.openjdk.java.net/jfx/pull/506
Re: RFR: 8267418: IntelliJ build and test of JavaFX does not work [v4]
On Wed, 2 Jun 2021 07:11:54 GMT, Marius Hanl wrote: >> ~~Question: I was wondering, should I create a ticket for this as well? >> Given the fact that I don't have an https://bugs.openjdk.java.net account, I >> need to use the official bug reporting tool, which looked a bit overkill to >> me since someone needs to check my created ticket, while this PR is only >> affecting the IntelliJ IDE with OpenJFX and not the JavaFX platform >> directly.~~ >> EDIT: Thank you, Kevin. :) >> >> This PR fixes the errors you get when cloning and working with OpenJFX in >> IntelliJ IDE: >> - The **.idea/misc.xml** is modified to use **JDK_11** as language level >> instead of JDK_8. >> -> This is the language level shown inside the **Project Structure**. (File >> -> Project Structure...) >> - The **.idea/base.iml, .idea/controls.iml, .idea/fxml.iml, .idea/web.iml, >> .idea/graphics.iml** are modified to include/recognize the shims (as test >> resource, this is very similar to the configuration inside the .classpath >> file from Eclipse) >> - EDIT: The projects are now recognized by IntelliJ-gradle >> (**.idea/gradle.xml**, **.idea/compiler.xml**) >> >> **-> With this, I can run all normal tests with IntelliJ** >> >> ### What I couldn't fix yet (When I tried, it looked like IntelliJ is >> overriding the settings on next gradle reload): >> - IntelliJ is not detecting javafx.graphic inside the shims >> - All javafx.* dependencies are not found for the system tests >> >> **-> If someone has a solution, feel free to comment :)** > > Marius Hanl has updated the pull request incrementally with one additional > commit since the last revision: > > Reverted whitespace made by IntelliJ >From the gradle documentation: [Skipping Javadocs and >sources](https://docs.gradle.org/current/userguide/dependency_verification.html#sec:skipping-javadocs) The verification of auto downloaded *-sources.jar files can be skipped using following change. This way we can avoid deleting the `verification-metadata.xml` file. diff --git a/gradle/verification-metadata.xml b/gradle/verification-metadata.xml index abacd0b05b..0a3d33726d 100644 --- a/gradle/verification-metadata.xml +++ b/gradle/verification-metadata.xml @@ -3,6 +3,9 @@ true false + + + I tested this change in addition to the PR changes, dependency verification does not fail with this change but fails without. Can you please verify and test this change preferably on a clean repo by creating a new IntelliJ project. - PR: https://git.openjdk.java.net/jfx/pull/506
Re: RFR: 8267418: IntelliJ build and test of JavaFX does not work [v4]
On Thu, 10 Jun 2021 14:45:18 GMT, Marius Hanl wrote: > This might not work because of the dependency verification error you have in > your console. I had this as well and I temporary deleted the > **verification-metadata.xml** inside the **gradle** folder. Deleting **verification-metadata.xml** temporarily solves the error on my system. The modules and tasks get listed in gradle window. Could execute graphics:test task from the gradle window. The step to delete **verification-metadata.xml** seems acceptable. (May be we should include the whole IntelliJ setup steps with build documentation.) It does not seem like a stopper to me, but would like to get @kevinrushforth 's opinion. - PR: https://git.openjdk.java.net/jfx/pull/506
Re: RFR: 8267418: IntelliJ build and test of JavaFX does not work [v4]
On Mon, 7 Jun 2021 04:17:06 GMT, Ambarish Rapte wrote: > I tested with IntelliJ IDEA 2021.1.2 (Community Edition) Build > #IC-211.7442.40, built on June 1, 2021. > > I see no side effects of this change. However, I also don't see what you see > too. > I tried it with a fresh clone of repository. > The build from IntelliJ's inbuilt terminal worked without this change too, > that terminal picks JDK/gradle/ant that was set in bashrc. > > I also don't see the modules in gradle window. Here is the screenshot that I > see when the project(with this PR change) is loaded for first time in the > IntelliJ. >  This might not work because of the dependency verification error you have in your console. I had this as well and I temporary deleted the **verification-metadata.xml** inside the **gradle** folder. As stated in the mailing list you can also delete the **.gradle** **cache** and **native** folder, but that's the easier way to test it though. Then you can click on the refresh icon in the gradle window and everything should build and then the projects should be visible in the gradle window. - PR: https://git.openjdk.java.net/jfx/pull/506
Re: RFR: 8267418: IntelliJ build and test of JavaFX does not work [v4]
On Wed, 2 Jun 2021 07:11:54 GMT, Marius Hanl wrote: >> ~~Question: I was wondering, should I create a ticket for this as well? >> Given the fact that I don't have an https://bugs.openjdk.java.net account, I >> need to use the official bug reporting tool, which looked a bit overkill to >> me since someone needs to check my created ticket, while this PR is only >> affecting the IntelliJ IDE with OpenJFX and not the JavaFX platform >> directly.~~ >> EDIT: Thank you, Kevin. :) >> >> This PR fixes the errors you get when cloning and working with OpenJFX in >> IntelliJ IDE: >> - The **.idea/misc.xml** is modified to use **JDK_11** as language level >> instead of JDK_8. >> -> This is the language level shown inside the **Project Structure**. (File >> -> Project Structure...) >> - The **.idea/base.iml, .idea/controls.iml, .idea/fxml.iml, .idea/web.iml, >> .idea/graphics.iml** are modified to include/recognize the shims (as test >> resource, this is very similar to the configuration inside the .classpath >> file from Eclipse) >> - EDIT: The projects are now recognized by IntelliJ-gradle >> (**.idea/gradle.xml**, **.idea/compiler.xml**) >> >> **-> With this, I can run all normal tests with IntelliJ** >> >> ### What I couldn't fix yet (When I tried, it looked like IntelliJ is >> overriding the settings on next gradle reload): >> - IntelliJ is not detecting javafx.graphic inside the shims >> - All javafx.* dependencies are not found for the system tests >> >> **-> If someone has a solution, feel free to comment :)** > > Marius Hanl has updated the pull request incrementally with one additional > commit since the last revision: > > Reverted whitespace made by IntelliJ I tested with IntelliJ IDEA 2021.1.2 (Community Edition) Build #IC-211.7442.40, built on June 1, 2021. I see no side effects of this change. However, I also don't see what you see too. I tried it with a fresh clone of repository. The build from IntelliJ's inbuilt terminal worked without this change too, that terminal picks JDK/gradle/ant that was set in bashrc. I also don't see the modules in gradle window. Here is the screenshot that I see when the project(with this PR change) is loaded for first time in the IntelliJ.  Is it possible that some local changes on your machine/repo result in what you see? Some idea files are ignored using .gitignore file, so they get modified they won't be shown in 'git status' **from .gitignore file** # Ignore IntelliJ files .idea/tasks.xml .idea/workspace.xml .idea/inspectionProfiles/** .idea/copyright/profiles_settings.xml .idea/codeStyles/** .idea/checkstyle-idea.xml It would be helpful to compare those files before and after loading the project in IntelliJ. Also, can you test the PR once, by cloning a fresh copy of repo and then apply the PR. - PR: https://git.openjdk.java.net/jfx/pull/506
Re: RFR: 8267418: IntelliJ build and test of JavaFX does not work [v4]
> ~~Question: I was wondering, should I create a ticket for this as well? Given > the fact that I don't have an https://bugs.openjdk.java.net account, I need > to use the official bug reporting tool, which looked a bit overkill to me > since someone needs to check my created ticket, while this PR is only > affecting the IntelliJ IDE with OpenJFX and not the JavaFX platform > directly.~~ > EDIT: Thank you, Kevin. :) > > This PR fixes the errors you get when cloning and working with OpenJFX in > IntelliJ IDE: > - The **.idea/misc.xml** is modified to use **JDK_11** as language level > instead of JDK_8. > -> This is the language level shown inside the **Project Structure**. (File > -> Project Structure...) > - The **.idea/base.iml, .idea/controls.iml, .idea/fxml.iml, .idea/web.iml, > .idea/graphics.iml** are modified to include/recognize the shims (as test > resource, this is very similar to the configuration inside the .classpath > file from Eclipse) > - EDIT: The projects are now recognized by IntelliJ-gradle > (**.idea/gradle.xml**, **.idea/compiler.xml**) > > **-> With this, I can run all normal tests with IntelliJ** > > ### What I couldn't fix yet (When I tried, it looked like IntelliJ is > overriding the settings on next gradle reload): > - IntelliJ is not detecting javafx.graphic inside the shims > - All javafx.* dependencies are not found for the system tests > > **-> If someone has a solution, feel free to comment :)** Marius Hanl has updated the pull request incrementally with one additional commit since the last revision: Reverted whitespace made by IntelliJ - Changes: - all: https://git.openjdk.java.net/jfx/pull/506/files - new: https://git.openjdk.java.net/jfx/pull/506/files/e6963285..591bdacf Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jfx&pr=506&range=03 - incr: https://webrevs.openjdk.java.net/?repo=jfx&pr=506&range=02-03 Stats: 2 lines in 1 file changed: 1 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jfx/pull/506.diff Fetch: git fetch https://git.openjdk.java.net/jfx pull/506/head:pull/506 PR: https://git.openjdk.java.net/jfx/pull/506
