Re: RFR: 8270107: Open source FXMediaPlayer test app

2021-09-14 Thread Johan Vos 
On Fri, 27 Aug 2021 22:06:31 GMT, Alexander Matveev  
wrote:

> - Added FXMediaPlayer test application.
>  - This app uses all media APIs and very handy in verifying media builds 
> during development.
>  - It can be compiled and run by running "ant" and "ant run" in 
> tests/manual/media/FXMediaPlayer.

tested on linux and mac, works great.
Good addition!

-

Marked as reviewed by jvos (Reviewer).

PR: https://git.openjdk.java.net/jfx/pull/613

Re: RFR: 8270107: Open source FXMediaPlayer test app

2021-09-14 Thread Johan Vos 
On Fri, 27 Aug 2021 22:06:31 GMT, Alexander Matveev  
wrote:

> - Added FXMediaPlayer test application.
>  - This app uses all media APIs and very handy in verifying media builds 
> during development.
>  - It can be compiled and run by running "ant" and "ant run" in 
> tests/manual/media/FXMediaPlayer.

I partially tested it, will do the remainder now.

-

PR: https://git.openjdk.java.net/jfx/pull/613

Re: RFR: 8270107: Open source FXMediaPlayer test app

2021-09-14 Thread Kevin Rushforth 
On Fri, 27 Aug 2021 22:06:31 GMT, Alexander Matveev  
wrote:

> - Added FXMediaPlayer test application.
>  - This app uses all media APIs and very handy in verifying media builds 
> during development.
>  - It can be compiled and run by running "ant" and "ant run" in 
> tests/manual/media/FXMediaPlayer.

@aghaisas or @johanvos can one of you be the second reviewer on this?

-

PR: https://git.openjdk.java.net/jfx/pull/613

Re: RFR: 8270107: Open source FXMediaPlayer test app

2021-09-02 Thread Kevin Rushforth 
On Fri, 27 Aug 2021 22:06:31 GMT, Alexander Matveev  
wrote:

> - Added FXMediaPlayer test application.
>  - This app uses all media APIs and very handy in verifying media builds 
> during development.
>  - It can be compiled and run by running "ant" and "ant run" in 
> tests/manual/media/FXMediaPlayer.

Looks good. Tested on all three platforms.

-

Marked as reviewed by kcr (Lead).

PR: https://git.openjdk.java.net/jfx/pull/613

Re: RFR: 8270107: Open source FXMediaPlayer test app

2021-08-29 Thread Scott Palmer 
On Fri, 27 Aug 2021 22:06:31 GMT, Alexander Matveev  
wrote:

> - Added FXMediaPlayer test application.
>  - This app uses all media APIs and very handy in verifying media builds 
> during development.
>  - It can be compiled and run by running "ant" and "ant run" in 
> tests/manual/media/FXMediaPlayer.

> On Aug 28, 2021, at 11:51 AM, Kevin Rushforth ***@***.***> wrote:
> 
> 
> I agree with getting it in now (after testing) and then improving it after it 
> is in the repo.
> 
> Btw, the nbproject/ files were derived from those in the apps/toys/ 
> directory, for example, apps/toys/Hello/nbproject/ 
> ,
>  and similarly are used to build using ant. So they aren't really IDE files 
> any longer, even though that's where they originated back in the FX 2 time 
> frame.
> 
> A good cleanup effort would be to rewrite them to remove the NetBeans project 
> structure, but that would be a larger effort than just this one manual test 
> program.
> 


Would be nice to have part of the cleanup convert projects to Gradle to be 
consistent with the rest of the project.

Scott

-

PR: https://git.openjdk.java.net/jfx/pull/613

Re: RFR: 8270107: Open source FXMediaPlayer test app

2021-08-28 Thread Kevin Rushforth 
On Fri, 27 Aug 2021 22:06:31 GMT, Alexander Matveev  
wrote:

> - Added FXMediaPlayer test application.
>  - This app uses all media APIs and very handy in verifying media builds 
> during development.
>  - It can be compiled and run by running "ant" and "ant run" in 
> tests/manual/media/FXMediaPlayer.

I agree with getting it in now (after testing) and then improving it after it 
is in the repo.

Btw, the `nbproject/` files were derived from those in the `apps/toys/` 
directory, for example, 
[apps/toys/Hello/nbproject/](https://github.com/openjdk/jfx/tree/68db44a2c80f420c967c64bb85988178a3cf6d9c/apps/toys/Hello/nbproject),
 and similarly are used to build using `ant`. So they aren't really IDE files 
any longer, even though that's where they originated back in the FX 2 time 
frame.

A good cleanup effort would be to rewrite them to remove the NetBeans project 
structure, but that would be a larger effort than just this one manual test 
program.

-

PR: https://git.openjdk.java.net/jfx/pull/613

Re: RFR: 8270107: Open source FXMediaPlayer test app

2021-08-28 Thread Johan Vos 
On Fri, 27 Aug 2021 22:06:31 GMT, Alexander Matveev  
wrote:

> - Added FXMediaPlayer test application.
>  - This app uses all media APIs and very handy in verifying media builds 
> during development.
>  - It can be compiled and run by running "ant" and "ant run" in 
> tests/manual/media/FXMediaPlayer.

That's great. I agree a global media sample would be an excellent improvement 
for testing (regression on) media.
 
I notice there are a number of netbeans-impl files, which is ok for me, unless 
we want to avoid ide-specific impl files?
It would be nice if this sample can leverage openjfx-global properties, i.e. I 
see it now has java source level set to 1.9.

Rather than requesting many changes (e.g. bump java version) before it is in 
the repository, I think it would be good to do some sanity tests on the 
different platforms and then include it. I plan to do that later this weekend.

-

PR: https://git.openjdk.java.net/jfx/pull/613

Re: RFR: 8270107: Open source FXMediaPlayer test app

2021-08-27 Thread Kevin Rushforth 
On Fri, 27 Aug 2021 22:06:31 GMT, Alexander Matveev  
wrote:

> - Added FXMediaPlayer test application.
>  - This app uses all media APIs and very handy in verifying media builds 
> during development.
>  - It can be compiled and run by running "ant" and "ant run" in 
> tests/manual/media/FXMediaPlayer.

By way of background this is a lightly cleaned up version of a closed-source 
test program that we are open sourcing in order to facilitate testing various 
media features.

Even though it is a test program, I'd like a second pair of eyes on it.

-

PR: https://git.openjdk.java.net/jfx/pull/613

RFR: 8270107: Open source FXMediaPlayer test app

2021-08-27 Thread Alexander Matveev 
- Added FXMediaPlayer test application.
 - This app uses all media APIs and very handy in verifying media builds during 
development.
 - It can be compiled and run by running "ant" and "ant run" in 
tests/manual/media/FXMediaPlayer.

-

Commit messages:
 - 8270107: Open source FXMediaPlayer test app

Changes: https://git.openjdk.java.net/jfx/pull/613/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jfx&pr=613&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8270107
  Stats: 5970 lines in 26 files changed: 5970 ins; 0 del; 0 mod
  Patch: https://git.openjdk.java.net/jfx/pull/613.diff
  Fetch: git fetch https://git.openjdk.java.net/jfx pull/613/head:pull/613

PR: https://git.openjdk.java.net/jfx/pull/613