Re: RFR: 8273969: Memory Leak on the Lambda provided to Platform.startup

2021-09-20 Thread Kevin Rushforth
On Sun, 19 Sep 2021 15:33:46 GMT, Florian Kirmaier wrote: > Probably my most boring PR. ;) > Setting the lambda to null, after it has been used, fixes the leak. The fix looks obviously correct. I verified that the test catches the bug (fails without the fix and passes with the fix). I left a

Re: RFR: 8273969: Memory Leak on the Lambda provided to Platform.startup

2021-09-20 Thread Florian Kirmaier
On Sun, 19 Sep 2021 15:33:46 GMT, Florian Kirmaier wrote: > Probably my most boring PR. ;) > Setting the lambda to null, after it has been used, fixes the leak. I guess that makes sense - but I can think of a million ways to create nearly unsolvable problems with it. - PR:

Re: RFR: 8273969: Memory Leak on the Lambda provided to Platform.startup

2021-09-20 Thread Tom Schindl
On Sun, 19 Sep 2021 15:58:24 GMT, Florian Kirmaier wrote: > For the strange reason, why i haven't used a lambda for the test, I've > created another ticket: https://bugs.openjdk.java.net/browse/JDK-8273970 I dpn't think this is a bug - none capturing lambdas are instantiated once and you

RFR: 8273969: Memory Leak on the Lambda provided to Platform.startup

2021-09-19 Thread Florian Kirmaier
Probably my most boring PR. ;) Setting the lambda to null, after it has been used, fixes the leak. - Commit messages: - JDK-8273969 Changes: https://git.openjdk.java.net/jfx/pull/626/files Webrev: https://webrevs.openjdk.java.net/?repo=jfx=626=00 Issue:

Re: RFR: 8273969: Memory Leak on the Lambda provided to Platform.startup

2021-09-19 Thread Florian Kirmaier
On Sun, 19 Sep 2021 15:33:46 GMT, Florian Kirmaier wrote: > Probably my most boring PR. ;) > Setting the lambda to null, after it has been used, fixes the leak. For the strange reason, why i haven't used a lambda for the test, I've created another ticket: