Re: RFR: 8276167: VirtualFlow.scrollToTop doesn't scroll to the top of the last element [v2]

2021-12-06 Thread Johan Vos
On Mon, 6 Dec 2021 09:23:53 GMT, eduardsdv wrote: >> eduardsdv has updated the pull request with a new target base due to a merge >> or a rebase. The incremental webrev excludes the unrelated changes brought >> in by the merge/rebase. The pull request contains two additional commits >> since

Re: RFR: 8276167: VirtualFlow.scrollToTop doesn't scroll to the top of the last element [v2]

2021-12-06 Thread Johan Vos
On Mon, 6 Dec 2021 11:26:24 GMT, Jeanette Winzenburg wrote: >> I tested it again. Without the changes in this PR the bug is still there. >> If the item is larger than the viewport, the VirtualFlow.scrollToTop(int) >> scrolls to the end instead of to top of the item. > >> I tested it again.

Re: RFR: 8276167: VirtualFlow.scrollToTop doesn't scroll to the top of the last element [v2]

2021-12-06 Thread Jeanette Winzenburg
On Mon, 6 Dec 2021 09:23:53 GMT, eduardsdv wrote: > I tested it again. Without the changes in this PR the bug is still there. > **If the item is larger than the viewport**, the VirtualFlow.scrollToTop(int) > scrolls to the end instead of to top of the item. ahhh .. finally I understand what

Re: RFR: 8276167: VirtualFlow.scrollToTop doesn't scroll to the top of the last element [v2]

2021-12-06 Thread eduardsdv
On Mon, 6 Dec 2021 08:22:37 GMT, eduardsdv wrote: >> Fix VirtualFlow.scrollToTop(int) doesn't scroll to the top of the last >> element but to the bottom of the last element. > > eduardsdv has updated the pull request with a new target base due to a merge > or a rebase. The incremental webrev

Re: RFR: 8276167: VirtualFlow.scrollToTop doesn't scroll to the top of the last element [v2]

2021-12-06 Thread eduardsdv
> Fix VirtualFlow.scrollToTop(int) doesn't scroll to the top of the last > element but to the bottom of the last element. eduardsdv has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the