Re: [jfx18] RFR: 8278980: Update WebKit to 613.1

2022-04-13 Thread Kevin Rushforth
On Wed, 13 Apr 2022 12:35:18 GMT, Johan Vos wrote: > Co-authored-by: Ajit Ghaisas > Co-authored-by: Jay Bhaskar > Co-authored-by: Kevin Rushforth > Reviewed-by: kcr, jvos, aghaisas Marked as reviewed by kcr (Lead). I can confirm that this is a clean patch, even though Skara doesn't record

[jfx18] RFR: 8278980: Update WebKit to 613.1

2022-04-13 Thread Johan Vos
Co-authored-by: Ajit Ghaisas Co-authored-by: Jay Bhaskar Co-authored-by: Kevin Rushforth Reviewed-by: kcr, jvos, aghaisas - Commit messages: - 8278980: Update WebKit to 613.1 Changes: https://git.openjdk.java.net/jfx/pull/770/files Webrev:

Re: [jfx11u] RFR: 8278980: Update WebKit to 613.1

2022-03-01 Thread Ambarish Rapte
On Mon, 28 Feb 2022 16:46:36 GMT, Kevin Rushforth wrote: > Nearly clean backport to `jfx11u` (the only conflict was in the copyright > years in one of the unit tests). I tested this along with the other VS 2019 > and WebKit 613.1 fixes together in the `test-kcr-11.0.15` branch. Marked as

Re: [jfx11u] RFR: 8278980: Update WebKit to 613.1

2022-03-01 Thread Ambarish Rapte
On Mon, 28 Feb 2022 16:46:36 GMT, Kevin Rushforth wrote: > Nearly clean backport to `jfx11u` (the only conflict was in the copyright > years in one of the unit tests). I tested this along with the other VS 2019 > and WebKit 613.1 fixes together in the `test-kcr-11.0.15` branch. Verified that

Re: [jfx11u] RFR: 8278980: Update WebKit to 613.1

2022-02-28 Thread Kevin Rushforth
On Mon, 28 Feb 2022 16:46:36 GMT, Kevin Rushforth wrote: > Nearly clean backport to `jfx11u` (the only conflict was in the copyright > years in one of the unit tests). I tested this along with the other VS 2019 > and WebKit 613.1 fixes together in the `test-kcr-11.0.15` branch. @arapte Can

[jfx11u] RFR: 8278980: Update WebKit to 613.1

2022-02-28 Thread Kevin Rushforth
Nearly clean backport to `jfx11u` (the only conflict was in the copyright years in one of the unit tests). I tested this along with the other VS 2019 and WebKit 613.1 fixes together in the `test-kcr-11.0.15` branch. - Commit messages: - 8278980: Update WebKit to 613.1 Changes:

Re: [jfx17u] RFR: 8278980: Update WebKit to 613.1

2022-02-11 Thread Kevin Rushforth
On Fri, 11 Feb 2022 16:48:47 GMT, Kevin Rushforth wrote: > Clean backport to jfx17u. CI build passed on three platforms. Tested locally > on macOS. Skara didn't mark this one as clean, although it is. See [SKARA-1332](https://bugs.openjdk.java.net/browse/SKARA-1332). I double-checked by

[jfx17u] RFR: 8278980: Update WebKit to 613.1

2022-02-11 Thread Kevin Rushforth
Clean backport to jfx17u. CI build passed on three platforms. Tested locally on macOS. - Commit messages: - 8278980: Update WebKit to 613.1 Changes: https://git.openjdk.java.net/jfx17u/pull/33/files Webrev: https://webrevs.openjdk.java.net/?repo=jfx17u=33=00 Issue:

Re: RFR: 8278980: Update WebKit to 613.1 [v2]

2022-02-04 Thread Ajit Ghaisas
On Wed, 2 Feb 2022 15:29:51 GMT, Ambarish Rapte wrote: >> Update JavaFX WebKit to GTK WebKit 2.34 (613.1). >> >> Verified the updated version build, tests run and sanity testing. >> This does not cause any issues except a unit test failure >> `IrresponsiveScriptTest`. >> It is recorded and

Re: RFR: 8278980: Update WebKit to 613.1 [v2]

2022-02-04 Thread Johan Vos
On Wed, 2 Feb 2022 15:29:51 GMT, Ambarish Rapte wrote: >> Update JavaFX WebKit to GTK WebKit 2.34 (613.1). >> >> Verified the updated version build, tests run and sanity testing. >> This does not cause any issues except a unit test failure >> `IrresponsiveScriptTest`. >> It is recorded and

Re: RFR: 8278980: Update WebKit to 613.1 [v2]

2022-02-03 Thread Kevin Rushforth
On Wed, 2 Feb 2022 15:29:51 GMT, Ambarish Rapte wrote: >> Update JavaFX WebKit to GTK WebKit 2.34 (613.1). >> >> Verified the updated version build, tests run and sanity testing. >> This does not cause any issues except a unit test failure >> `IrresponsiveScriptTest`. >> It is recorded and

Re: RFR: 8278980: Update WebKit to 613.1

2022-02-02 Thread Ambarish Rapte
On Wed, 2 Feb 2022 13:42:53 GMT, yosbits wrote: > You may have noticed ... The change file contains changes that are not > related to the WebKit upgrade. It looks like you're reverting to an older > version. Thanks for pointing it out. It is corrected now. Thanks @kevinrushforth for quick

Re: RFR: 8278980: Update WebKit to 613.1 [v2]

2022-02-02 Thread Ambarish Rapte
> Update JavaFX WebKit to GTK WebKit 2.34 (613.1). > > Verified the updated version build, tests run and sanity testing. > This does not cause any issues except a unit test failure > `IrresponsiveScriptTest`. > It is recorded and ignored using >

Re: RFR: 8278980: Update WebKit to 613.1

2022-02-02 Thread Kevin Rushforth
On Wed, 2 Feb 2022 13:42:53 GMT, yosbits wrote: > The change file contains changes that are not related to the WebKit upgrade. Thanks for pointing this out! It looks like the patch was applied incorrectly. @arapte please fix this. - PR: https://git.openjdk.java.net/jfx/pull/723

Re: RFR: 8278980: Update WebKit to 613.1

2022-02-02 Thread yosbits
On Wed, 2 Feb 2022 07:34:55 GMT, Ambarish Rapte wrote: > Update JavaFX WebKit to GTK WebKit 2.34 (613.1). > > Verified the updated version build, tests run and sanity testing. > This does not cause any issues except a unit test failure > `IrresponsiveScriptTest`. > It is recorded and ignored

Re: RFR: 8278980: Update WebKit to 613.1

2022-02-02 Thread Johan Vos
Hi Kevin, Thanks for filing [JDK-8281089]. I think this is the way forward indeed. The longer we delay moving to VS 2019, the more problems we can expect. I'll build/test the WebKit 613.1 as well. - Johan On Wed, Feb 2, 2022 at 1:49 PM Kevin Rushforth wrote: > On Wed, 2 Feb 2022 07:34:55 GMT,

Re: RFR: 8278980: Update WebKit to 613.1

2022-02-02 Thread Kevin Rushforth
On Wed, 2 Feb 2022 07:34:55 GMT, Ambarish Rapte wrote: > Update JavaFX WebKit to GTK WebKit 2.34 (613.1). > > Verified the updated version build, tests run and sanity testing. > This does not cause any issues except a unit test failure > `IrresponsiveScriptTest`. > It is recorded and ignored