Re: RFR: 8282449: Intermittent OOM error in PredefinedMeshManagerTest
On Thu, 21 Apr 2022 15:07:38 GMT, Ambarish Rapte wrote: > This is a test only fix. The tests used to create Sphere and Cylinder of > large divisions, which could fail intermittently with OOM. > The tests were added along with the fix for > [JDK-8180151](https://bugs.openjdk.java.net/browse/JDK-8180151). > The attributes of Sphere and Cylinder were chosen such that their hash code > would collide. The large number of divisions results in creating large sized > triangle mesh and sometimes cause OOM. > > The fix: is to use different combination of hashcode colliding attributes > with smaller number of divisions to avoid OOM. > > There are two commits in the PR: > 1. [First > commit](https://github.com/openjdk/jfx/commit/1ff6054503f5042f9ede54faac6fa00ec4369612) > contains the source changes with which test should fail. Only > `sphereCacheTest` fails with this commit but not the `cylinderCacheTest`. The > earlier combination of Cylinder attributes also does NOT fail. > 2. [Second > commit](https://github.com/openjdk/jfx/commit/0c8649abe94ef2b526007c37fab6910315a98654) > reverts the source code changes. Looks good. Thanks for the explanation regarding the replacement values. - Marked as reviewed by kcr (Lead). PR: https://git.openjdk.java.net/jfx/pull/782
RFR: 8282449: Intermittent OOM error in PredefinedMeshManagerTest
This is a test only fix. The tests used to create Sphere and Cylinder of large divisions, which could fail intermittently with OOM. The tests were added along with the fix for [JDK-8180151](https://bugs.openjdk.java.net/browse/JDK-8180151). The attributes of Sphere and Cylinder were chosen such that their hash code would collide. The large number of divisions results in creating large sized triangle mesh and sometimes cause OOM. The fix: is to use different combination of hashcode colliding attributes with smaller number of divisions to avoid OOM. There are two commits in the PR: 1. [First commit](https://github.com/openjdk/jfx/commit/1ff6054503f5042f9ede54faac6fa00ec4369612) contains the source changes with which test should fail. Only `sphereCacheTest` fails with this commit but not the `cylinderCacheTest`. The earlier combination of Cylinder attributes also does NOT fail. 2. [Second commit](https://github.com/openjdk/jfx/commit/0c8649abe94ef2b526007c37fab6910315a98654) reverts the source code changes. - Commit messages: - revert temp source changes - commit with source changes where test fails Changes: https://git.openjdk.java.net/jfx/pull/782/files Webrev: https://webrevs.openjdk.java.net/?repo=jfx=782=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8282449 Stats: 9 lines in 1 file changed: 0 ins; 3 del; 6 mod Patch: https://git.openjdk.java.net/jfx/pull/782.diff Fetch: git fetch https://git.openjdk.java.net/jfx pull/782/head:pull/782 PR: https://git.openjdk.java.net/jfx/pull/782
