Re: Swing module's module-info file

Yes, but since this thread was about the Swing module's module-info I'll start another thread with the link to the JBS issue I created a few days ago about Eclipse. On Wed, Aug 8, 2018 at 10:10 AM, Tom Schindl wrote: > Hi, > > On 08.08.18 08:55, Tom Schindl wrote: > > Hi Nir, > > > > I

Re: Swing module's module-info file

Hi, On 08.08.18 08:55, Tom Schindl wrote: > Hi Nir, > > I currently use the attached stash to make Eclipse compile all modules. > > Unfortunately I have to modify the following java-Files to get away > without any compile errors: > * Dialog => Added a method getDialog() instead of directly

Re: Swing module's module-info file

Hi Nir, I currently use the attached stash to make Eclipse compile all modules. Unfortunately I have to modify the following java-Files to get away without any compile errors: * Dialog => Added a method getDialog() instead of directly accessing the field * javafx.fxml => Add a static

Re: Swing module's module-info file

Ah, yes, I was trying to see what modifications each project needs so I didn't have it modified. Can you share your Swing .classpath? Eclipse gives me a NPE during the build task, I think something broke. On Tue, Aug 7, 2018 at 8:54 PM, Tom Schindl wrote: > Oh but naturally my .classpath-File

Re: Swing module's module-info file

Oh but naturally my .classpath-File is modified Tom On 07.08.18 19:51, Tom Schindl wrote: > Yes they do! > > Tom > > On 07.08.18 19:36, Nir Lisker wrote: >> And both newimlp and oldimpl packages compile for you? >> >> On Tue, Aug 7, 2018 at 8:04 PM, Tom Schindl >

Re: Swing module's module-info file

There is no reason they won't both compile with JDK 11. In this case, the implementation is selected at runtime. When compiling with JDK 10, the 'newimpl' package is excluded. -- Kevin On 8/7/2018 10:36 AM, Nir Lisker wrote: And both newimlp and oldimpl packages compile for you? On Tue,

Re: Swing module's module-info file

Yes they do! Tom On 07.08.18 19:36, Nir Lisker wrote: > And both newimlp and oldimpl packages compile for you? > > On Tue, Aug 7, 2018 at 8:04 PM, Tom Schindl > wrote: > > Hi Nir, > > I'm using OpenJDK-11 in my eclipse for development so I have

Re: Swing module's module-info file

And both newimlp and oldimpl packages compile for you? On Tue, Aug 7, 2018 at 8:04 PM, Tom Schindl wrote: > Hi Nir, > > I'm using OpenJDK-11 in my eclipse for development so I have that module > included. > > Tom > > On 07.08.18 18:34, Nir Lisker wrote: > > So you rebuilt the JDK with the new

Re: Swing module's module-info file

Hi Nir, I'm using OpenJDK-11 in my eclipse for development so I have that module included. Tom On 07.08.18 18:34, Nir Lisker wrote: > So you rebuilt the JDK with the new jdk.unsupported.desktop module? > > On Tue, Aug 7, 2018 at 3:11 PM, Tom Schindl >

Re: Swing module's module-info file

So you rebuilt the JDK with the new jdk.unsupported.desktop module? On Tue, Aug 7, 2018 at 3:11 PM, Tom Schindl wrote: > Well I simply added the folder to my class-folders and things then work > perfectly fine inside Eclipse > > Tom > > On 07.08.18 14:02, Nir Lisker wrote: > > Thanks for the

Re: Swing module's module-info file

Well I simply added the folder to my class-folders and things then work perfectly fine inside Eclipse Tom On 07.08.18 14:02, Nir Lisker wrote: > Thanks for the info. I'm working on updating the Eclipse files and this is > causing problems for javafx.swing. When will the minimum version be bumped

Re: Swing module's module-info file

Thanks for the info. I'm working on updating the Eclipse files and this is causing problems for javafx.swing. When will the minimum version be bumped to 11? On Tue, Aug 7, 2018 at 7:51 AM, Prasanta Sadhukhan < prasanta.sadhuk...@oracle.com> wrote: > This is because if fx is compiled with a jdk

Re: Swing module's module-info file

This is because if fx is compiled with a jdk version which does not have jdk.unsupported.desktop module then having module-info.java in its original place would cause compilation error as module-info.java contains requires static jdk.unsupported.desktop; So, the idea was to copy the file into

Swing module's module-info file

Hi, I didn't follow all the latest changes to the Swing module, but I notice now its module-info.java file is not in the same place where other modules have theirs: It's under javafx.swing\src\main\module-info instead of javafx.\src\main\java. Is there a reason for this? - Nir