Re: Touch Events, Scrolling, and Windows Pen

2013-06-04 Thread Anthony Petrov
Hi Danno, I've just pushed your fix: http://hg.openjdk.java.net/openjfx/8/graphics/rt/rev/1dd4bb7090a2 Thank you for the contribution. -- best regards, Anthony On 06/03/2013 06:47 PM, Artem Ananiev wrote: On 6/3/2013 5:52 PM, Anthony Petrov wrote: Hi Danno, Thank you for the patch. I've p

Re: Touch Events, Scrolling, and Windows Pen

2013-06-03 Thread Artem Ananiev
On 6/3/2013 5:52 PM, Anthony Petrov wrote: Hi Danno, Thank you for the patch. I've published a webrev at: http://cr.openjdk.java.net/~anthony/g-301-penEvents-RT-30869.0/ The fix looks fine to me. Could anyone else please review it? +1. Thanks, Artem -- best regards, Anthony On 06/03/13

Re: Touch Events, Scrolling, and Windows Pen

2013-06-03 Thread Anthony Petrov
Hi Danno, Thank you for the patch. I've published a webrev at: http://cr.openjdk.java.net/~anthony/g-301-penEvents-RT-30869.0/ The fix looks fine to me. Could anyone else please review it? -- best regards, Anthony On 06/03/13 04:59, Danno Ferrin wrote: I created a new bug for the pen support

Re: Touch Events, Scrolling, and Windows Pen

2013-06-02 Thread Danno Ferrin
I created a new bug for the pen support bug, with a tested patch. I spent way more time getting the build up than doing the fix, such is native work. https://javafx-jira.kenai.com/browse/RT-30869 For the pan-select, I attached a fix for list views to the existing bug. If that approach passes must

Re: Touch Events, Scrolling, and Windows Pen

2013-05-28 Thread Anthony Petrov
Sounds good to me. Danno, could you please prepare a patch for this bug, test it, and post it for review here? -- best regards, Anthony On 05/28/2013 07:46 PM, Danno Ferrin wrote: For 8.0 that would be the best solution IMHO. On May 28, 2013 8:41 AM, "Pavel Safrata" wrote: So it seems to

Re: Touch Events, Scrolling, and Windows Pen

2013-05-28 Thread Danno Ferrin
For 8.0 that would be the best solution IMHO. On May 28, 2013 8:41 AM, "Pavel Safrata" wrote: > So it seems to me that in short term (FX8) the pen should produce mouse > events with isSynthesized==false. We can introduce something more advanced > in the future, but right now it should generally w

Re: Touch Events, Scrolling, and Windows Pen

2013-05-28 Thread Pavel Safrata
So it seems to me that in short term (FX8) the pen should produce mouse events with isSynthesized==false. We can introduce something more advanced in the future, but right now it should generally work and the synthesized flag really seems to be misused here. Pavel On 28.5.2013 16:09, Danno Fer

Re: Touch Events, Scrolling, and Windows Pen

2013-05-28 Thread Danno Ferrin
On Tue, May 28, 2013 at 2:44 AM, Anthony Petrov wrote: > Hi Danno, > > > On 05/27/2013 07:27 PM, Danno Ferrin wrote: > >> My next problem is the pen device on Windows. The only events captured in >> JavaFX from a pen are mouse events. To complicate things the >> "Synthesized" >> flag is set. Th

Re: Touch Events, Scrolling, and Windows Pen

2013-05-28 Thread Anthony Petrov
Hi Danno, On 05/27/2013 07:27 PM, Danno Ferrin wrote: My next problem is the pen device on Windows. The only events captured in JavaFX from a pen are mouse events. To complicate things the "Synthesized" flag is set. This is a bit disconcerting because to the view of a JFX app there is no othe

Re: Touch Events, Scrolling, and Windows Pen

2013-05-27 Thread Pavel Safrata
On 27.5.2013 18:09, Pavel Safrata wrote: Hi Danno, On 27.5.2013 17:27, Danno Ferrin wrote: One of the things that prompted me to write the TouchyFXy application was to get a feel of the event flow before I embarked on recommending fixes to some of the quirks. Here goes. My first concern is

Re: Touch Events, Scrolling, and Windows Pen

2013-05-27 Thread Pavel Safrata
Hi Danno, On 27.5.2013 17:27, Danno Ferrin wrote: One of the things that prompted me to write the TouchyFXy application was to get a feel of the event flow before I embarked on recommending fixes to some of the quirks. Here goes. My first concern is touch scrolling on lists. If you do a touch

Touch Events, Scrolling, and Windows Pen

2013-05-27 Thread Danno Ferrin
One of the things that prompted me to write the TouchyFXy application was to get a feel of the event flow before I embarked on recommending fixes to some of the quirks. Here goes. My first concern is touch scrolling on lists. If you do a touch scroll on a List you wind up selecting the item you