On Tue, 9 Aug 2022 17:17:12 GMT, Andy Goryachev wrote:
>> The goal of this change is to make sure jfx repo can be imported as a gradle
>> project in eclipse and all nested projects in the workspace compile with no
>> errors.
>>
>> - updated .classpath entries in apps/
>> - added utf-8 prefs
> 1. reword SelectionModel.isSelected(int) javadoc, removing incorrect
> statement "Is functionally equivalent to calling
> getSelectedIndices().contains(index)."
> 2. reimplement TableView.TableViewSelectionModel.isSelected(int) method to
> return true when at least one cell in *any* column
On Tue, 5 Jul 2022 23:30:48 GMT, Marius Hanl wrote:
>> Initialize the `(Tree)TableView` when creating the measure row.
>> This will guarantee, that we can access the `(Tree)TableView` in the
>> `(Tree)TableRowSkin`, which is currently only null during the autosizing (It
>> is always set
On Tue, 9 Aug 2022 17:17:12 GMT, Andy Goryachev wrote:
>> The goal of this change is to make sure jfx repo can be imported as a gradle
>> project in eclipse and all nested projects in the workspace compile with no
>> errors.
>>
>> - updated .classpath entries in apps/
>> - added utf-8 prefs
On Tue, 9 Aug 2022 11:57:32 GMT, Jeanette Winzenburg
wrote:
>>> Aside: there is a general issue with cell selection not updated on columns
>>> modification (the selection visual is kept on the same column index without
>>> changing selectedCells accordingly - technically due to looping across
> The goal of this change is to make sure jfx repo can be imported as a gradle
> project in eclipse and all nested projects in the workspace compile with no
> errors.
>
> - updated .classpath entries in apps/
> - added utf-8 prefs in .settings/
Andy Goryachev has updated the pull request
> The goal of this change is to make sure jfx repo can be imported as a gradle
> project in eclipse and all nested projects in the workspace compile with no
> errors.
>
> - updated .classpath entries in apps/
> - added utf-8 prefs in .settings/
Andy Goryachev has updated the pull request
On Tue, 9 Aug 2022 15:14:15 GMT, Kevin Rushforth wrote:
>> Andy Goryachev has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains eight additional
>>
On Mon, 8 Aug 2022 20:30:01 GMT, Andy Goryachev wrote:
>> The goal of this change is to make sure jfx repo can be imported as a gradle
>> project in eclipse and all nested projects in the workspace compile with no
>> errors.
>>
>> - updated .classpath entries in apps/
>> - added utf-8 prefs
On Tue, 9 Aug 2022 15:11:49 GMT, Kevin Rushforth wrote:
>> This is up to Kevin. It's changing the build file specifically to remove a
>> warning for Eclipse Mac users. I don't mind. Might need to do the same for
>> the other OS-specific folders.
>
> While not ideal, I suppose it's OK. I'm
On Tue, 9 Aug 2022 00:52:36 GMT, Nir Lisker wrote:
>> I respectfully disagree.
>> I see no harm in creating empty directories in this case if it solves the
>> problem.
>> We can log a bug against eclipse, and it will be fixed in several years, if
>> ever.
>
> This is up to Kevin. It's
On Wed, 3 Aug 2022 23:41:54 GMT, Kevin Rushforth wrote:
>> Laurent Bourgès has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> fixed pixel color tests on hi-dpi
>
> modules/javafx.graphics/src/main/java/com/sun/marlin/MarlinProperties.java
On Mon, 8 Aug 2022 13:41:24 GMT, Laurent Bourgès wrote:
>> Changelog for this MarlinFX 0.9.4.5 release:
>>
>> The Marlin-renderer 0.9.4.5 release provides bug fixes on Marlin's path
>> clipper:
>> - improved Stroker to handle huge coordinates, up to 1E15
>> - improved PathClipFilter (filler)
Clean backport to `jfx17u`.
-
Commit messages:
- 8284676: TreeTableView loses sort ordering when applied on empty table
Changes: https://git.openjdk.org/jfx17u/pull/76/files
Webrev: https://webrevs.openjdk.org/?repo=jfx17u=76=00
Issue: https://bugs.openjdk.org/browse/JDK-8284676
Clean backport to `jfx17u`.
-
Commit messages:
- 8289952: Visual Studio libs msvcp140_1.dll and msvcp140_2.dll missing from
build
Changes: https://git.openjdk.org/jfx17u/pull/75/files
Webrev: https://webrevs.openjdk.org/?repo=jfx17u=75=00
Issue:
Clean backport to `jfx17u`.
-
Commit messages:
- 8289587: IllegalArgumentException: Color.rgb's red parameter (-16776961)
expects color values 0-255
Changes: https://git.openjdk.org/jfx17u/pull/74/files
Webrev: https://webrevs.openjdk.org/?repo=jfx17u=74=00
Issue:
Clean backport to `jfx17u`.
-
Commit messages:
- 8088420: JavaFX WebView memory leak via EventListener
Changes: https://git.openjdk.org/jfx17u/pull/73/files
Webrev: https://webrevs.openjdk.org/?repo=jfx17u=73=00
Issue: https://bugs.openjdk.org/browse/JDK-8088420
Stats: 1509
Clean backport to jfx17u
-
Commit messages:
- 8283786: Update to Visual Studio 2022 version 17.1.0 on Windows
Changes: https://git.openjdk.org/jfx17u/pull/72/files
Webrev: https://webrevs.openjdk.org/?repo=jfx17u=72=00
Issue: https://bugs.openjdk.org/browse/JDK-8283786
Stats:
On Mon, 8 Aug 2022 22:07:17 GMT, Andy Goryachev wrote:
>
> Personally, I feel that any manipulations with the columns structure should
> clear the existing selection. I would imagine it's such a rare operation, and
> the "fix" is so easy (clear selection) that it's not worth even creating an
On Mon, 8 Aug 2022 21:51:05 GMT, Andy Goryachev wrote:
>
> I think you are right, @kleopatra ! Took me a while, but I see your point
> now. This method should indeed delegate to super(), or not be overridden at
> all.
>
I would prefer removing it (reducing clutter :) As it's a private
On Thu, 28 Jul 2022 15:01:34 GMT, Kevin Rushforth wrote:
> When using the Windows Narrator screen reader on a Hi-DPI screen, the visible
> focus is drawn in the wrong location and with the wrong size. This happens
> because the the JavaFX Windows accessibility code that returns the screen
>
On Fri, 5 Aug 2022 18:42:34 GMT, Kevin Rushforth wrote:
>> When using the Windows Narrator screen reader on a Hi-DPI screen, the
>> visible focus is drawn in the wrong location and with the wrong size. This
>> happens because the the JavaFX Windows accessibility code that returns the
>>
On Thu, 4 Aug 2022 23:01:37 GMT, Kevin Rushforth wrote:
>> Laurent Bourgès has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> fixed pixel color tests on hi-dpi
>
> I did a quick skim of the DPQS class, enough to know that code review is
>
23 matches
Mail list logo
