On Tue, 2 Aug 2022 18:01:06 GMT, Ambarish Rapte wrote:
>> Nir Lisker has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Renamed method
>
> modules/javafx.graphics/src/main/native-prism-d3d/hlsl/vs2ps.h line 38:
>
>> 36: float3
> **Issue:**
> When the `TableView` is set with built-in `CONSTRAINED_RESIZE_POLICY`, the
> horizontal scroll bar keeps flickering when the `TableView` width is reduced.
>
> **Cause:**
> The table columns widths are recalculated only if the difference of the
> `TableView` width and the total
On Sat, 8 Jan 2022 00:17:36 GMT, Marius Hanl wrote:
> This PR fixes a bunch of NPEs when a null `SelectionModel` or `FocusModel` is
> set on a `ListView`.
>
> The following NPEs are fixed (all are also covered by exactly one test case):
> NPEs with null selection model:
> - Mouse click on a
On Sat, 8 Jan 2022 00:17:36 GMT, Marius Hanl wrote:
> This PR fixes a bunch of NPEs when a null `SelectionModel` or `FocusModel` is
> set on a `ListView`.
>
> The following NPEs are fixed (all are also covered by exactly one test case):
> NPEs with null selection model:
> - Mouse click on a
> - added Skin.install()
> - javadoc changes for Skinnable.setSkin(Skin)
>
> no code changes for Skinnable.setSkin(Skin) yet.
Andy Goryachev has updated the pull request incrementally with one additional
commit since the last revision:
8290844: javadoc
-
Changes:
- all:
On Tue, 26 Jul 2022 00:28:59 GMT, Sai Pradeep Dandem wrote:
>> modules/javafx.controls/src/main/java/javafx/scene/control/TableUtil.java
>> line 226:
>>
>>> 224: }
>>> 225:
>>> 226: if (Math.abs(colWidth - tableWidth) > 0) {
>>
>> Related to Andy's question, shouldn't this be
On Wed, 10 Aug 2022 08:14:13 GMT, Marius Hanl wrote:
>> Initialize the `(Tree)TableView` when creating the measure row.
>> This will guarantee, that we can access the `(Tree)TableView` in the
>> `(Tree)TableRowSkin`, which is currently only null during the autosizing (It
>> is always set
On Mon, 25 Jul 2022 09:25:57 GMT, Sai Pradeep Dandem wrote:
> **Issue:**
> When the `TableView` is set with built-in `CONSTRAINED_RESIZE_POLICY`, the
> horizontal scroll bar keeps flickering when the `TableView` width is reduced.
>
> **Cause:**
> The table columns widths are recalculated only
On Mon, 25 Jul 2022 09:25:57 GMT, Sai Pradeep Dandem wrote:
> **Issue:**
> When the `TableView` is set with built-in `CONSTRAINED_RESIZE_POLICY`, the
> horizontal scroll bar keeps flickering when the `TableView` width is reduced.
>
> **Cause:**
> The table columns widths are recalculated only
> 1. reword SelectionModel.isSelected(int) javadoc, removing incorrect
> statement "Is functionally equivalent to calling
> getSelectedIndices().contains(index)."
> 2. reimplement TableView.TableViewSelectionModel.isSelected(int) method to
> return true when at least one cell in *any* column
On Wed, 10 Aug 2022 08:14:13 GMT, Marius Hanl wrote:
>> Initialize the `(Tree)TableView` when creating the measure row.
>> This will guarantee, that we can access the `(Tree)TableView` in the
>> `(Tree)TableRowSkin`, which is currently only null during the autosizing (It
>> is always set
On Wed, 10 Aug 2022 10:06:21 GMT, Jay Bhaskar wrote:
> Issue: xml not well-formed error occurs at XML document parser.
> Issue: doEnd() call not needed for JAVA platform, as it is making
> XMLDocumentParserLibxml2 xml not well-formed error.
Can you say why the `doEnd` call is not needed for
On Wed, 10 Aug 2022 11:00:23 GMT, Ambarish Rapte wrote:
> Clean backport to `jfx17u`.
This pull request has now been integrated.
Changeset: ae0b9fa8
Author:Ambarish Rapte
URL:
https://git.openjdk.org/jfx17u/commit/ae0b9fa8d41beb077ead26507e4d3aaf708ec36e
Stats: 447029 lines in
Clean backport to `jfx17u`.
-
Commit messages:
- 8285881: Update WebKit to 614.1
Changes: https://git.openjdk.org/jfx17u/pull/77/files
Webrev: https://webrevs.openjdk.org/?repo=jfx17u=77=00
Issue: https://bugs.openjdk.org/browse/JDK-8285881
Stats: 447029 lines in 7346 files
On Tue, 9 Aug 2022 12:20:35 GMT, Ambarish Rapte wrote:
> Clean backport to `jfx17u`.
This pull request has now been integrated.
Changeset: e363c7a3
Author:Ambarish Rapte
URL:
https://git.openjdk.org/jfx17u/commit/e363c7a39eca30227ef8c79a16e7132937783904
Stats: 15 lines in 2
On Tue, 9 Aug 2022 12:18:51 GMT, Ambarish Rapte wrote:
> Clean backport to `jfx17u`.
This pull request has now been integrated.
Changeset: f961fa80
Author:Ambarish Rapte
URL:
https://git.openjdk.org/jfx17u/commit/f961fa80131480b4742f8eb9daf9122a35a6a2c6
Stats: 5 lines in 2
On Tue, 9 Aug 2022 12:16:43 GMT, Ambarish Rapte wrote:
> Clean backport to `jfx17u`.
This pull request has now been integrated.
Changeset: 525e854f
Author:Ambarish Rapte
URL:
https://git.openjdk.org/jfx17u/commit/525e854fbcf0f696969f4230303c14a1ed82f6a4
Stats: 180 lines in 3
On Tue, 9 Aug 2022 12:13:46 GMT, Ambarish Rapte wrote:
> Clean backport to `jfx17u`.
This pull request has now been integrated.
Changeset: cd39e0bb
Author:Ambarish Rapte
URL:
https://git.openjdk.org/jfx17u/commit/cd39e0bb3515aafc39d97f719695ff807f27e497
Stats: 1509 lines in 11
On Tue, 9 Aug 2022 12:11:18 GMT, Ambarish Rapte wrote:
> Clean backport to jfx17u
This pull request has now been integrated.
Changeset: 60311082
Author:Ambarish Rapte
URL:
https://git.openjdk.org/jfx17u/commit/603110823e59016fd422fd4a129e520e90e2e0ea
Stats: 9 lines in 3 files
Issue: xml not well-formed error occurs at XML document parser.
Issue: doEnd() call not needed for JAVA platform, as it is making
XMLDocumentParserLibxml2 xml not well-formed error.
-
Commit messages:
- 8290274: DRT 27 tests fail due to xml not well formed error on window
Changes:
> A null check has been added to below SpinnerValueFactory classes in
> valueProperty() ChangeListeners-
> - `IntegerSpinnerValueFactory`
> - `LocalDateSpinnerValueFactory`
> - `LocalTimeSpinnerValueFactory`
> - `ListSpinnerValueFactory`
>
> Added 5 tests that detect NPE for above 4 Spinner
On Tue, 9 Aug 2022 21:35:11 GMT, Kevin Rushforth wrote:
> @Maran23 GitHub is reporting a merge conflict in two of the test files. Can
> you merge the latest upstream master into your branch?
Didn't noticed, thanks for the ping.
For some reason the macOS build can not download ant:
On Wed, 10 Aug 2022 06:56:50 GMT, Ajit Ghaisas wrote:
> A null check has been added to below SpinnerValueFactory classes in
> valueProperty() ChangeListeners-
> - `IntegerSpinnerValueFactory`
> - `LocalDateSpinnerValueFactory`
> - `LocalTimeSpinnerValueFactory`
> - `ListSpinnerValueFactory`
>
On Tue, 9 Aug 2022 14:52:12 GMT, Kevin Rushforth wrote:
>> Laurent Bourgès has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> upgraded to 0.9.4.6 (no repeated lineTo) + fixed tests
>
>
> Initialize the `(Tree)TableView` when creating the measure row.
> This will guarantee, that we can access the `(Tree)TableView` in the
> `(Tree)TableRowSkin`, which is currently only null during the autosizing (It
> is always set otherwise).
>
> With this change, a NPE is happening as the
A null check has been added to below SpinnerValueFactory classes in
valueProperty() ChangeListeners-
- `IntegerSpinnerValueFactory`
- `LocalDateSpinnerValueFactory`
- `LocalTimeSpinnerValueFactory`
- `ListSpinnerValueFactory`
Added 5 tests that detect NPE for above 4 Spinner factories.
Only
26 matches
Mail list logo
