Withdrawn: 8285878: [TestBug] LocalStorageTest does not cleanup post execution

2022-08-13 Thread Jay Bhaskar
On Sat, 13 Aug 2022 11:45:00 GMT, Jay Bhaskar wrote: > Issue: test Bug LocalStorageTest does not cleanup post execution > Solution: Path for LocalStorageDir changed to modules/javafx.web/build/. Now > the LocalStorageDir is deleted after post execution. This pull request has been closed without

Re: RFR: 8285878: [TestBug] LocalStorageTest does not cleanup post execution [v2]

2022-08-13 Thread Jay Bhaskar
> Issue: test Bug LocalStorageTest does not cleanup post execution > Solution: Path for LocalStorageDir changed to modules/javafx.web/build/. Now > the LocalStorageDir is deleted after post execution. Jay Bhaskar has updated the pull request incrementally with two additional commits since the la

Re: [External] : Re: Missing 'vcruntime.h'

2022-08-13 Thread Nir Lisker
I figured out that that error (which appeared during compilation of native decora shaders) came from a missing entry in windows.tools.properties: WINDOWS_VS_INCLUDE=C:/Program Files/Microsoft Visual Studio/2022/Community/VC/Tools/MSVC/14.33.31629/include (There were many other entries there, but al

Re: RFR: 8287604: Update MarlinFX to 0.9.4.6 [v6]

2022-08-13 Thread Laurent Bourgès
On Sat, 13 Aug 2022 13:24:30 GMT, Laurent Bourgès wrote: >> Changelog for this MarlinFX 0.9.4.6 release: >> >> The Marlin-renderer 0.9.4.6 release provides one bug fix in Stroker: skip >> repeated endpoint to preserve mitter orientation: see JDK-8264999, >> https://bugs.openjdk.org/browse/JDK-

Re: RFR: 8287604: Update MarlinFX to 0.9.4.6 [v6]

2022-08-13 Thread Laurent Bourgès
> Changelog for this MarlinFX 0.9.4.6 release: > > The Marlin-renderer 0.9.4.6 release provides one bug fix in Stroker: skip > repeated endpoint to preserve mitter orientation: see JDK-8264999, > https://bugs.openjdk.org/browse/JDK-8264999 > > The Marlin-renderer 0.9.4.5 release provides bug fi

Re: RFR: 8285878: [TestBug] LocalStorageTest does not cleanup post execution

2022-08-13 Thread Kevin Rushforth
On Sat, 13 Aug 2022 11:45:00 GMT, Jay Bhaskar wrote: > Issue: test Bug LocalStorageTest does not cleanup post execution > Solution: Path for LocalStorageDir changed to modules/javafx.web/build/. Now > the LocalStorageDir is deleted after post execution. Moving `LocalStorageDir` to be under `bui

Re: [External] : Re: Missing 'vcruntime.h'

2022-08-13 Thread Kevin Rushforth
Sure, I'll do that when I get a chance. As long as you set VS150COMNTOOLS, you shouldn't ever need to edit them, but it might be useful as a sanity check to compare with yours. Our GHA builds only set that one variable (and do not set MSVC_VER or VSINSTALLDIR).     VS150COMNTOOLS: "C:\\Program

RFR: 8285878: [TestBug] LocalStorageTest does not cleanup post execution

2022-08-13 Thread Jay Bhaskar
Issue: test Bug LocalStorageTest does not cleanup post execution Solution: Path for LocalStorageDir changed to modules/javafx.web/build/. Now the LocalStorageDir is deleted after post execution. - Commit messages: - 8285878: [TestBug] LocalStorageTest does not cleanup post execution