> Issue:
> When Narrator is running,
> 1. Deleting last character from `TextField` throws
> `IllegalArgumentException`, and
> 2. Deleting last character from `TextArea` throws `NPE`.
>
> Fix:
> When character is deleted, we receive an offset larger by one than the
> current text length. This
On Fri, 26 Aug 2022 03:43:49 GMT, Nir Lisker wrote:
> I haven't looked at the code yet, but in general it's not considered a good
> idea to expose an object before it's instantiated. Not sure if we have a
> choice here though.
I agree, that's why the `underConstruction` flag is used to
On Thu, 25 Aug 2022 22:18:44 GMT, Michael Strauß wrote:
>> `Node` adds InvalidationListeners to its parent's `disabled` and
>> `treeVisible` properties and calls its own `updateDisabled()` and
>> `updateTreeVisible(boolean)` methods when the property values change.
>>
>> These listeners are
On Thu, 25 Aug 2022 22:18:44 GMT, Michael Strauß wrote:
>> `Node` adds InvalidationListeners to its parent's `disabled` and
>> `treeVisible` properties and calls its own `updateDisabled()` and
>> `updateTreeVisible(boolean)` methods when the property values change.
>>
>> These listeners are
> `Node` adds InvalidationListeners to its parent's `disabled` and
> `treeVisible` properties and calls its own `updateDisabled()` and
> `updateTreeVisible(boolean)` methods when the property values change.
>
> These listeners are not required, since `Node` can easily call the
>
On Thu, 25 Aug 2022 13:50:19 GMT, Nir Lisker wrote:
>> It's definitely a hypothetical case. `getChildren()` is called all over the
>> place in JavaFX without a null check, so I see no reason for null checks
>> here.
>
> Technically correct, although the [doc of
>
On Thu, 25 Aug 2022 13:46:26 GMT, Kevin Rushforth wrote:
>> Since `getChildren()` is not final, one can easily override it and return
>> null.
>> Therefore, this check should still be done here.
>> Maybe we even need to check that every child is not null, since again I can
>> override
On Thu, 25 Aug 2022 13:36:01 GMT, Marius Hanl wrote:
>> modules/javafx.graphics/src/main/java/javafx/scene/Node.java line 1919:
>>
>>> 1917: }
>>> 1918: }
>>> 1919: }
>>
>> Because we can use Java 17 now, you can use
On Thu, 25 Aug 2022 12:33:51 GMT, Nir Lisker wrote:
>> `Node` adds InvalidationListeners to its parent's `disabled` and
>> `treeVisible` properties and calls its own `updateDisabled()` and
>> `updateTreeVisible(boolean)` methods when the property values change.
>>
>> These listeners are not
On Thu, 21 Jul 2022 04:43:15 GMT, Michael Strauß wrote:
> `Node` adds InvalidationListeners to its parent's `disabled` and
> `treeVisible` properties and calls its own `updateDisabled()` and
> `updateTreeVisible(boolean)` methods when the property values change.
>
> These listeners are not
On Thu, 21 Jul 2022 04:43:15 GMT, Michael Strauß wrote:
> `Node` adds InvalidationListeners to its parent's `disabled` and
> `treeVisible` properties and calls its own `updateDisabled()` and
> `updateTreeVisible(boolean)` methods when the property values change.
>
> These listeners are not
11 matches
Mail list logo
