Re: Provide Quit handler for system menu bar

2022-09-19 Thread Scott Palmer
Windows applications often have an “Exit” menu item, but since it isn’t standardized like it is on macOS, calling a quit handler for it would need to be a manual step - but the exact same method for the quit handler could be called, leaving it up to the programmer to continue or not with the app

Re: Provide Quit handler for system menu bar

2022-09-19 Thread Kevin Rushforth
I don't see us adding 100s of OS-specific API calls, but even if we did, going down the path of exposing them as Mac APIs or Windows APIs, doesn't really seem like the direction we want to go. Whatever we do needs to balance the desire to integrate with, e.g., the macOS or Windows platform with

Re: Provide Quit handler for system menu bar

2022-09-19 Thread Andy Goryachev
Thank you, Kevin. Your insightful feedback always pulls the discussion in the right direction. The initial problem we are facing is access to Mac menu in general and additional API specifically. I can see a possibility of extending the list of APIs that app devs would want on Mac growing, so

Re: Provide Quit handler for system menu bar

2022-09-19 Thread Kevin Rushforth
I like the idea of looking at this holistically, even if we do end up adding such features one at a time. As for how to expose such an API, I don't much like the idea of exposing the underlying platform explicitly unless there is no viable alternative. A better approach is one where a feature

Re: Provide Quit handler for system menu bar

2022-09-19 Thread Andy Goryachev
Greetings! Thank you for proposing a solution, Florian. I wonder if we should extrapolate the problem further. Given the fact that app developers always need access to platform specific APIs, be it integration with Mac menu, perhaps we should consider a way to do so in such a way that does no

Re: RFR: 8292353: TableRow vs. TreeTableRow: inconsistent visuals in cell selection mode [v11]

2022-09-19 Thread Andy Goryachev
> The issue is caused by TreeTableRow incorrectly selected when cell selection > mode is enabled. > > Changes: > - modified TreeTableRow.updateSelection() Andy Goryachev has updated the pull request incrementally with one additional commit since the last revision: 8292353: review comments -

Re: [External] : Re: Opacity elements broken for svg

2022-09-19 Thread Kevin Rushforth
Filed here: https://bugs.openjdk.org/browse/JDK-8294011 -- Kevin On 9/19/2022 6:08 AM, Thorsten wrote: Much appreciated Am 19/09/2022 um 15:01 schrieb Kevin Rushforth: This belongs on the openjfx-dev list, so I'm rerouting it (I Bcc'ed openjfx-discuss) I haven't heard other reports of htt

Re: Opacity elements broken for svg

2022-09-19 Thread Kevin Rushforth
This belongs on the openjfx-dev list, so I'm rerouting it (I Bcc'ed openjfx-discuss) I haven't heard other reports of https://bugreport.java.com being broken, but I can file the bug for you. -- Kevin On 9/19/2022 5:47 AM, Thorsten wrote: Hello This is a bug report that should go through

Re: RFR: 8254676: Alert disables Tab selection when TabDragPolicy REORDER is used

2022-09-19 Thread Ambarish Rapte
On Sun, 11 Sep 2022 12:13:47 GMT, Johan Vos wrote: > Don't set TabHeader to mouseTransparent, since it might get stuck in that > state (e.g. in case an Alert is shown). > The TabPaneSkin deals with the dragging internally, and does not require the > dragged node to be mouseTransparent. The fix