Re: RFR: 8293883: Add test/.classpath (Eclipse) [v2]

2022-09-22 Thread Andy Goryachev
> Adding a tests/.classpath file to include tests/manual/controls source folder > so Eclipse could see/execute manual tests there. > > Also, I would rather move the sources there to a specific package > (test.manual ?) instead of a default package. Any objections? > edit: won't be done as a part

Re: RFR: 8293883: Add test/.classpath (Eclipse)

2022-09-22 Thread Andy Goryachev
On Thu, 15 Sep 2022 21:55:20 GMT, Andy Goryachev wrote: > Adding a tests/.classpath file to include tests/manual/controls source folder > so Eclipse could see/execute manual tests there. > > Also, I would rather move the sources there to a specific package > (test.manual ?) instead of a defaul

Re: RFR: 8293883: Add test/.classpath (Eclipse)

2022-09-22 Thread Nir Lisker
On Thu, 15 Sep 2022 21:55:20 GMT, Andy Goryachev wrote: > Adding a tests/.classpath file to include tests/manual/controls source folder > so Eclipse could see/execute manual tests there. > > Also, I would rather move the sources there to a specific package > (test.manual ?) instead of a defaul

Re: RFR: 8293883: Add test/.classpath (Eclipse)

2022-09-22 Thread Andy Goryachev
On Thu, 22 Sep 2022 19:54:41 GMT, Nir Lisker wrote: > There are sources under `tests/performance` and `tests/manual` that should > also be included in the classpath. I would like to limit the scope of this PR. The problem is that one thing leads to another - and the fact that all these manu

Re: RFR: 8293883: Add test/.classpath (Eclipse)

2022-09-22 Thread Nir Lisker
On Thu, 15 Sep 2022 21:55:20 GMT, Andy Goryachev wrote: > Adding a tests/.classpath file to include tests/manual/controls source folder > so Eclipse could see/execute manual tests there. > > Also, I would rather move the sources there to a specific package > (test.manual ?) instead of a defaul

Re: RFR: 8293883: Add test/.classpath (Eclipse)

2022-09-22 Thread Andy Goryachev
On Thu, 15 Sep 2022 21:55:20 GMT, Andy Goryachev wrote: > Adding a tests/.classpath file to include tests/manual/controls source folder > so Eclipse could see/execute manual tests there. > > Also, I would rather move the sources there to a specific package > (test.manual ?) instead of a defaul

Integrated: JDK-8289541 : Update ICU4C to 71.1

2022-09-22 Thread Hima Bindu Meda
On Wed, 7 Sep 2022 18:13:43 GMT, Hima Bindu Meda wrote: > Updated icu to v71.1. > Verified build and sanity testing on windows,Mac and Linux. > Removed icu directory from Source/WTF, as the functionality is already > provided by Source/ThirdParty/icu This pull request has now been integrated.

Re: RFR: 8290040: Provide simplified deterministic way to manage listeners [v5]

2022-09-22 Thread John Hendrikx
> This PR adds a new (lazy*) property on `Node` which provides a boolean which > indicates whether or not the `Node` is currently part of a `Scene`, which in > turn is part of a currently showing `Window`. > > It also adds a new fluent binding method on `ObservableValue` dubbed `when` > (open f

Re: RFR: JDK-8289541 : Update ICU4C to 71.1 [v6]

2022-09-22 Thread Johan Vos
On Wed, 21 Sep 2022 16:32:09 GMT, Hima Bindu Meda wrote: >> Updated icu to v71.1. >> Verified build and sanity testing on windows,Mac and Linux. >> Removed icu directory from Source/WTF, as the functionality is already >> provided by Source/ThirdParty/icu > > Hima Bindu Meda has updated the pull