On Mon, 17 Oct 2022 16:11:32 GMT, Andy Goryachev wrote:
>> What I meant is you can add it in Node.getProperties() and not to add a
>> pointer to every Node everywhere. If it's used, the actual properties will
>> be created in a few containers.
>
> private static final Object KEY = new
On Mon, 17 Oct 2022 17:07:40 GMT, Nir Lisker wrote:
>> It would be suitable to align with our existing doc comment in other
>> classes, for example as here,
>>
>> 1.
>>
On Mon, 17 Oct 2022 09:36:55 GMT, Ambarish Rapte wrote:
> Update Copyright year in these 3 doc files to 2023.
Marked as reviewed by kcr (Lead).
-
PR: https://git.openjdk.org/jfx/pull/917
On Mon, 17 Oct 2022 15:24:48 GMT, Ambarish Rapte wrote:
>> ...correction, found in toString() as well.
>
> It would be suitable to align with our existing doc comment in other classes,
> for example as here,
>
> 1.
>
On Fri, 14 Oct 2022 15:08:24 GMT, Douglas Held wrote:
>> Not strictly enforced, but adding a blank line does aid readability (of the
>> source code...the generated docs don't care).
>
> If I were to add empty lines before JavaDoc tags such as @param etc, then for
> consistency I think I should
On Fri, 14 Oct 2022 23:01:48 GMT, Andy Goryachev wrote:
>> I agree with your first point, but I think limiting any changes to `Node`
>> because it would add another field is not a good enough argument. It would
>> depend on its merits.
>>
>> The second point, there is much more to the
On Fri, 14 Oct 2022 15:15:27 GMT, Douglas Held wrote:
>> Looking at the JavaDoc in the rest of the class, the {@code Point3D} tags
>> are not used outside of these two methods hashCode() and equals(). I'd
>> propose actually that we remove them, for consistency with the rest of the
>> JavaDoc
Update Copyright year in these 3 doc files to 2023.
-
Commit messages:
- copyright update in docs
Changes: https://git.openjdk.org/jfx/pull/917/files
Webrev: https://webrevs.openjdk.org/?repo=jfx=917=00
Issue: https://bugs.openjdk.org/browse/JDK-8294722
Stats: 3 lines in 3
> This fixes a race condition between application and 'Print Job Thread'
> threads when printing.
>
> The race condition occurs when application thread calls `endJob()`, which in
> effect sets the `jobDone` flag to true,
> and when the 'Print Job Thread' thread was in the `synchronized` block
