On Tue, 15 Nov 2022 18:00:59 GMT, Andy Goryachev wrote:
> 1. Introduced the following utility methods:
> - Util.launch
> - Util.shutdown
> - Util.waitForLatch
> 2. Fixed the out-of order calls to Stage.hide() and Platform.exit() in many
> tests' shutdowns.
> 3. Replaced local waitForLatch
On Tue, 15 Nov 2022 18:00:59 GMT, Andy Goryachev wrote:
> 1. Introduced the following utility methods:
> - Util.launch
> - Util.shutdown
> - Util.waitForLatch
> 2. Fixed the out-of order calls to Stage.hide() and Platform.exit() in many
> tests' shutdowns.
> 3. Replaced local waitForLatch
1. Introduced the following utility methods:
- Util.launch
- Util.shutdown
- Util.waitForLatch
2. Fixed the out-of order calls to Stage.hide() and Platform.exit() in many
tests' shutdowns.
3. Replaced local waitForLatch copies with Util.waitForLatch
-
Commit messages:
- 8206430:
On Sun, 13 Nov 2022 01:02:36 GMT, Thiago Milczarek Sayao
wrote:
>> Simple fix to not requestFocus() on scene change.
>>
>> The attached bug sample shows that the TextField focused on the scene
>> remains focused when the scene comes back.
>
> Thiago Milczarek Sayao has updated the pull
The new operation returns a new ObservableValue that is only
meaningfully "exists" when the condition holds.
If the condition doesn't hold, the effect is as if the operation
wasn't invoked at all, i.e. it doesn't meaningfully exist.
With this in mind, here's another option:
> Introduction
>
> There is a number of places where various listeners (strong as well as weak)
> are added, to be later disconnected in one go. For example, Skin
> implementations use dispose() method to clean up the listeners installed in
> the corresponding Control (sometimes using
>
On Tue, 15 Nov 2022 06:35:05 GMT, Ajit Ghaisas wrote:
>> Exactly. In its current form, `ListenerHelper` is a utility helper class for
>> Skins, and should be reviewed with that in mind. As discussed in previous
>> comments, there are several things that will need to change when/if this is
>>
On Tue, 15 Nov 2022 06:17:21 GMT, Ajit Ghaisas wrote:
>> Right, there is no way the accessor can be null, since it is initialized at
>> class load time in the static initializer, We do this in many other places
>> (e.g., Node.java).
>
> The `accessor` cannot be null **only if** it is used from
>
> - the screenshots are outdated, using much older version of Eclipse, the
> UI has been changed a bit. The latest Eclipse won't work with java19
> without a separate plugin, but i am sure they will fix it soon.
>
Yes, I will need to delete all the projects and re-import in order to
create the
Nir, thank you so much!
A few minor corrections might be needed.
in Import the Eclipse Projects:
- the screenshots are outdated, using much older version of Eclipse, the UI has
been changed a bit. The latest Eclipse won't work with java19 without a
separate plugin, but i am sure they will fix
This PR fixes our `build.gradle` script so it can work with gradle 7.6.
When doing a test build with gradle 7.6 RC3:
$ gradle sdk
$ gradle --info -PBUILD_SDK_FOR_TEST=false test
We get the following error:
FAILURE: Build failed with an exception.
* Where:
Build file
On Wed, 9 Nov 2022 10:08:28 GMT, pandaapo wrote:
> Fixes [JDK-8296618](https://bugs.openjdk.org/browse/JDK-8296618)
This pull request has been closed without being integrated.
-
PR: https://git.openjdk.org/jfx/pull/942
On Wed, 9 Nov 2022 10:08:28 GMT, pandaapo wrote:
> Fixes [JDK-8296618](https://bugs.openjdk.org/browse/JDK-8296618)
Now that [JDK-8285503](https://bugs.openjdk.org/browse/JDK-8285503) has been
fixed, [JDK-8296618](https://bugs.openjdk.org/browse/JDK-8296618) has been
closed as "not an issue".
While rereading the proposed docs for the new method, the following
stood out to me:
"The returned ObservableValue only observes this value when condition
holds true."
So I agree that "updateWhen" isn't really accurate, but I don't care for
"onCondition" either.
I think "whenever" would
On Tue, 15 Nov 2022 02:05:33 GMT, Nir Lisker wrote:
> I updated
> https://wiki.openjdk.org/display/OpenJFX/Using+an+IDE#UsinganIDE-UsingEclipse.
Looks good, nicely explained :)
-
PR: https://git.openjdk.org/jfx/pull/930
15 matches
Mail list logo
