Re: Warnings

2022-12-04 Thread John Hendrikx
On 04/12/2022 20:53, John Neffenger wrote: On 12/4/22 8:22 AM, John Hendrikx wrote: - Avoiding indirect access to static methods and fields     class A { static final int ONE = 1; }     class B { }         class C extends B { int one = ONE;  // unqualified access to A.ONE

Re: RFR: JDK-8297413: Remove easy warnings in javafx.graphics [v4]

2022-12-04 Thread Nir Lisker
On Sat, 3 Dec 2022 20:54:04 GMT, John Hendrikx wrote: >> - Remove unsupported/unnecessary SuppressWarning annotations >> - Remove reduntant type specifications (use diamond operator) >> - Remove unused or duplicate imports >> - Remove unnecessary casts (type is already correct type or can be auto

Re: RFR: 8276170: Create Sources when publishing to Maven

2022-12-04 Thread Michael Paus
On Sun, 4 Dec 2022 20:10:29 GMT, Johan Vos wrote: > We're now using the github issue tracker to discuss reproducible builds, > which is probably not the primary reason Github issues were created, so I > think it's better to start this discussion on a mail thread :) Or maybe use https://docs.gi

Re: RFR: 8276170: Create Sources when publishing to Maven

2022-12-04 Thread Johan Vos
On Fri, 29 Oct 2021 12:36:13 GMT, eduardsdv wrote: > Create sources.jars and attach they to the publish task, so that they can be > uploaded to the (e.g. maven) repository automatically. We're now using the github issue tracker to discuss reproducible builds, which is probably not the primary

Re: Warnings

2022-12-04 Thread John Neffenger
On 12/4/22 8:22 AM, John Hendrikx wrote: - Avoiding indirect access to static methods and fields    class A { static final int ONE = 1; }    class B { }        class C extends B {     int one = ONE;  // unqualified access to A.ONE   } Did you mean the following?

Warnings

2022-12-04 Thread John Hendrikx
We've done a few fixes in JavaFX trying to reduce the amount of warnings, and there was some discussion as to the value of fixing certain warnings. Some of these are purely aesthetic (like using the diamond operator) but others can hide current or future programming problems. I thought I'd po

Re: RFR: 8290040: Provide simplified deterministic way to manage listeners [v10]

2022-12-04 Thread John Hendrikx
On Fri, 2 Dec 2022 09:56:42 GMT, John Hendrikx wrote: >> This PR adds a new (lazy*) property on `Node` which provides a boolean which >> indicates whether or not the `Node` is currently part of a `Scene`, which in >> turn is part of a currently showing `Window`. >> >> It also adds a new fluent