On Mon, 12 Dec 2022 05:41:45 GMT, Ambarish Rapte wrote:
> The commit#1 changes look good. I would recommend to revert commit#2 for few
> reasons:
>
> 1. Cleanup changes are a lot more than actual fix change.
> 2. It will be difficult to revisit in future.
> 3. If required the cleanup changes
On Thu, 1 Dec 2022 17:03:03 GMT, Karthik P K wrote:
> Cause: When slider is dragged for first time after tooltip appears,
> setOnMousePressed event was not invoked, hence dragStart was null in the
> subsequently invoked event handler (setOnMouseDragged).
>
> Fix: Initialized dragStart in
On Sat, 10 Dec 2022 15:42:23 GMT, Kevin Rushforth wrote:
>> modules/javafx.controls/src/main/java/javafx/scene/control/skin/SliderSkin.java
>> line 410:
>>
>>> 408: thumb.setOnMouseExited(me -> {
>>> 409: Tooltip t = getSkinnable().getTooltip();
>>> 410: if (t
On Sat, 3 Dec 2022 22:17:55 GMT, John Hendrikx wrote:
> This includes a fix for the precision problem we've found as part of the
> graphics warnings clean ups.
>
> I've included two commits, one with just the minimal fix, and one with the
> clean ups. I can drop off the 2nd commit if it is
On Sun, 11 Dec 2022 20:31:24 GMT, John Hendrikx wrote:
>> This PR adds a new (lazy*) property on `Node` which provides a boolean which
>> indicates whether or not the `Node` is currently part of a `Scene`, which in
>> turn is part of a currently showing `Window`.
>>
>> It also adds a new
> This cleans size and positioning code, reducing special cases, code
> complexity and size.
>
> Changes:
>
> - cached extents: 28, 1, 1, 1 are old defaults - modern gnome uses different
> sizes. It does not assume any size because it varies - it does cache because
> it's unlikely to vary on
On Sun, 11 Dec 2022 21:14:56 GMT, Thiago Milczarek Sayao
wrote:
>> This cleans size and positioning code, reducing special cases, code
>> complexity and size.
>>
>> Changes:
>>
>> - cached extents: 28, 1, 1, 1 are old defaults - modern gnome uses different
>> sizes. It does not assume any
> This cleans size and positioning code, reducing special cases, code
> complexity and size.
>
> Changes:
>
> - cached extents: 28, 1, 1, 1 are old defaults - modern gnome uses different
> sizes. It does not assume any size because it varies - it does cache because
> it's unlikely to vary on
Packages fixed:
- com.sun.javafx.binding
- com.sun.javafx.collections
- javafx.beans
- javafx.beans.binding
- javafx.collections
- javafx.collections.transformation
-
Commit messages:
- Use static method for no-op map
- Fix raw type warnings in base
Changes:
On Sat, 10 Dec 2022 17:36:16 GMT, Kevin Rushforth wrote:
> In order to move this forward, please revert the changes in `javafx.graphics`
> and file a follow-up Enhancement in JBS that we can use to separately discuss
> adding such a property to `Node`.
>
> I also think it might be cleanest to
On Sat, 10 Dec 2022 17:29:23 GMT, Kevin Rushforth wrote:
>> John Hendrikx has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Improve wording in javadoc and comments
>
>
> This PR adds a new (lazy*) property on `Node` which provides a boolean which
> indicates whether or not the `Node` is currently part of a `Scene`, which in
> turn is part of a currently showing `Window`.
>
> It also adds a new fluent binding method on `ObservableValue` dubbed `when`
> (open
> This PR adds a new (lazy*) property on `Node` which provides a boolean which
> indicates whether or not the `Node` is currently part of a `Scene`, which in
> turn is part of a currently showing `Window`.
>
> It also adds a new fluent binding method on `ObservableValue` dubbed `when`
> (open
On Sun, 11 Dec 2022 14:30:22 GMT, John Hendrikx wrote:
>> - Added generics (to package private or internal classes only)
>> - Minor clean-ups of code I touched (naming)
>> - Fixed incorrect use of generics
>> - Fixed raw type warnings
>>
>> Note: some raw types have leaked into public API.
> - Added generics (to package private or internal classes only)
> - Minor clean-ups of code I touched (naming)
> - Fixed incorrect use of generics
> - Fixed raw type warnings
>
> Note: some raw types have leaked into public API. These could be fixed
> without incompatibilities. For specifics
On Sat, 10 Dec 2022 21:55:03 GMT, Nir Lisker wrote:
>> John Hendrikx has updated the pull request incrementally with three
>> additional commits since the last revision:
>>
>> - Adjusted ReadOnlyListProperty#equals to be a bit more modern Java
>> - Remove SuppressWarnings in
16 matches
Mail list logo
