Re: RFR: 8299423: JavaFX Mac system menubar leaks

2022-12-30 Thread Michael Strauß
On Fri, 30 Dec 2022 09:41:46 GMT, Florian Kirmaier wrote: > This PR fixes the leak in the mac system menu bar. > > Inside the native code, NewGlobalRef is called for the callable. > Which makes it into a "GC-Root" until DeleteGlobalRef is called. > > The DeleteGlobalRef is never called for

Re: RFR: JDK-8298528: Clean up raw type warnings in base in bindings and collections packages

2022-12-30 Thread Nir Lisker
On Sun, 11 Dec 2022 20:12:17 GMT, John Hendrikx wrote: > Packages fixed: > - com.sun.javafx.binding > - com.sun.javafx.collections > - javafx.beans > - javafx.beans.binding > - javafx.collections > - javafx.collections.transformation Second part of the review. I'm still looking at the changes

Re: RFR: JDK-8298528: Clean up raw type warnings in base in bindings and collections packages

2022-12-30 Thread Nir Lisker
On Mon, 26 Dec 2022 14:32:52 GMT, John Hendrikx wrote: >> modules/javafx.base/src/main/java/javafx/beans/binding/ListExpression.java >> line 238: >> >>> 236: public Iterator iterator() { >>> 237: final ObservableList list = get(); >>> 238: return (list == null)? >>>

RFR: 8299423: JavaFX Mac system menubar leaks

2022-12-30 Thread Florian Kirmaier
This PR fixes the leak in the mac system menu bar. Inside the native code, NewGlobalRef is called for the callable. Which makes it into a "GC-Root" until DeleteGlobalRef is called. The DeleteGlobalRef is never called for the MenuEntry, if it's removed from the menu without removing it's

RFR: JDK-8299423: JavaFX Mac system menubar leaks

2022-12-30 Thread Florian Kirmaier
Hi Everyone, Please review this change: https://github.com/openjdk/jfx/pull/987 It fixes a newly found leak in the mac system menu bar Florian