Re: RFR: 8267546: Add CSS themes as a first-class concept [v15]

2022-12-31 Thread Michael Strauß
> This PR adds style themes as a first-class concept to OpenJFX. A style theme > is a collection of stylesheets and the logic that governs them. Style themes > can respond to OS notifications and update their stylesheets dynamically. > This PR also re-implements Caspian and Modena as style theme

Re: Concatenated observable list

2022-12-31 Thread Scott Palmer
+1 to doing something like this. I just recently discovered FXCollections.concat(ObservableList…) doesn’t do what you propose. I figured that was the whole point.ScottOn Dec 31, 2022, at 3:44 PM, Nir Lisker wrote:We can do better than that. Instead of introducing methods for specific operations,

Re: Concatenated observable list

2022-12-31 Thread Nir Lisker
We can do better than that. Instead of introducing methods for specific operations, like concat and retain, we can offer bulk operations on collections. When John H. proposed the fluent bindings additions, we discussed doing the same for collections after that. At the very least, we can have a met

Concatenated observable list

2022-12-31 Thread Michael Strauß
FXCollections.concat(ObservableList...) can be used to create a new ObservableList that contains the concatenation of all elements of the source lists. This is useful to initialize the contents of the new ObservableList, but the returned list is not kept in sync with the source lists. I'm proposin

Re: RFR: 8299423: JavaFX Mac system menubar leaks

2022-12-31 Thread Florian Kirmaier
On Sat, 31 Dec 2022 04:18:09 GMT, Michael Strauß wrote: >> This PR fixes the leak in the mac system menu bar. >> >> Inside the native code, NewGlobalRef is called for the callable. >> Which makes it into a "GC-Root" until DeleteGlobalRef is called. >> >> The DeleteGlobalRef is never called for