Thanks for reporting this. I think a lot of the comments in build.gradle
are outdated. I filed https://bugs.openjdk.org/browse/JDK-8300700 to
track this.
-- Kevin
On 1/19/2023 10:30 AM, Scott Palmer wrote:
This isn't affecting anything, but while trying to figure out my build
issues I notice
I filed https://bugs.openjdk.org/browse/JDK-8300697 to track this. In
addition to fixing it, I propose to add a very visible warning so that
developers know they are building in this "HAS_JAVAFX_MODULES" mode,
since it could otherwise be a surprise when no standalone build
artifacts are produce
I'm not sure that will work in general. The more important thing to note
is that we really can't build and run an actual standalone JavaFX SDK if
the JDK already has the javafx.* modules. I'll file a bug and we can
think about possible solutions.
Basically, though, unless you are intending to
Looks like our replies crossed in the mail. I replied with basically the
same conclusion.
-- Kevin
On 1/19/2023 11:17 AM, Scott Palmer wrote:
I found the problem. I'm using a build of OpenJDK from Azul that
includes the javafx modules. You probably aren't, which means the
--upgrade-module-
I guess --patch-module should be used instead of --update-module-path ? It
seems to be a little more complicated.
On Thu, Jan 19, 2023 at 2:17 PM Scott Palmer wrote:
> I found the problem. I'm using a build of OpenJDK from Azul that includes
> the javafx modules. You probably aren't, which mea
You're up to date with the latest jfx master, right?
Our CI builds are working fine, as are the GitHub actions builds (on all
platforms).
Oh, I see your problem.
> error: option --upgrade-module-path cannot be used together with
--release
The "--upgrade-module-path" option is only set if y
I found the problem. I'm using a build of OpenJDK from Azul that includes
the javafx modules. You probably aren't, which means the
--upgrade-module-path option isn't being used so there is no conflict with
javac parameters.
I downloaded a JDK17 without the JavaFX modules and teh build worked.
I t
This isn't affecting anything, but while trying to figure out my build
issues I noticed this typo and mismatch between the comment and the code..
"verion" at https://github.com/openjdk/jfx/blob/master/build.gradle#L617
But more significant, the actual command issued is "java -fullversion"
which ou
Tried a gradle clean (which works fine after manually deleting the stale
mac_tools.properties file) and confirmed the build folder was gone from the
graphics module and elsewhere, no difference. I'm running the gradle
wrapper, so it's using Gradle as defined by the project. I'm also usually
on th
I recommend removing the entire build directory (although if you managed
to get "gradle clean" working, then it will do that).
What version of gradle are you using? You will need gradle 7.6 to use
JDK 19.
-- Kevin
On 1/19/2023 10:17 AM, Scott Palmer wrote:
Tried again with JDK 17.0.5, just
Tried again with JDK 17.0.5, just in case... still not working.
On Wed, Jan 18, 2023 at 3:18 PM Scott Palmer wrote:
> I'm trying to build OpenJFX on my Mac. I figured out an issue with the
> Gradle scripts, they fail if there is a stale mac_tools.properties file. A
> 'clean' also fails for the
On Thu, 19 Jan 2023 17:22:38 GMT, Thiago Milczarek Sayao
wrote:
>> This PR fixes 8273379.
>>
>> I reverted back to use GDK (from
>> [8225571](https://bugs.openjdk.org/browse/JDK-8225571)) to handle the
>> events.
>>
>> It may also fix [8280383](https://bugs.openjdk.org/browse/JDK-8280383).
> This PR fixes 8273379.
>
> I reverted back to use GDK (from
> [8225571](https://bugs.openjdk.org/browse/JDK-8225571)) to handle the events.
>
> It may also fix [8280383](https://bugs.openjdk.org/browse/JDK-8280383).
>
> There's also some cleaup.
>
> To do general testing (two tests were add
When running on Wayland the `GDK_DRAG_LEAVE` is sent just after
`GDK_DROP_START`. The leave event causes java to set dragGesture to null. On
Xorg this event is not sent.
The fix just ignore the leave event if a drop occurred.
-
Commit messages:
- Fix JDK-8275033
- Merge branch '
Hi list,
I've been looking into what it would take to make the design of
properties which only register listeners when needed easier to implement
with JavaFX, both for JavaFX itself as well as for the user. This is
the result of my investigation into ListProperty (and other collection
proper
> This PR fixes 8273379.
>
> I reverted back to use GDK (from
> [8225571](https://bugs.openjdk.org/browse/JDK-8225571)) to handle the events.
>
> It may also fix [8280383](https://bugs.openjdk.org/browse/JDK-8280383).
>
> There's also some cleaup.
>
> To do general testing (two tests were add
On Thu, 19 Jan 2023 13:05:49 GMT, Johan Vos wrote:
> 8296654: [macos] Crash when launching JavaFX app with JDK that targets SDK 13
>
> Reviewed-by: aghaisas, jvos, mstrauss
This pull request has now been integrated.
Changeset: 795ed10e
Author:Johan Vos
URL:
https://git.openjdk.org/
On Thu, 19 Jan 2023 13:05:49 GMT, Johan Vos wrote:
> 8296654: [macos] Crash when launching JavaFX app with JDK that targets SDK 13
>
> Reviewed-by: aghaisas, jvos, mstrauss
Marked as reviewed by kcr (Lead).
-
PR: https://git.openjdk.org/jfx/pull/1003
> This PR fixes 8273379.
>
> I reverted back to use GDK (from
> [8225571](https://bugs.openjdk.org/browse/JDK-8225571)) to handle the events.
>
> It may also fix [8280383](https://bugs.openjdk.org/browse/JDK-8280383).
>
> There's also some cleaup.
>
> To do general testing (two tests were add
8296654: [macos] Crash when launching JavaFX app with JDK that targets SDK 13
Reviewed-by: aghaisas, jvos, mstrauss
-
Commit messages:
- 8296654: [macos] Crash when launching JavaFX app with JDK that targets SDK 13
Changes: https://git.openjdk.org/jfx/pull/1003/files
Webrev: https
On Thu, 19 Jan 2023 13:05:49 GMT, Johan Vos wrote:
> 8296654: [macos] Crash when launching JavaFX app with JDK that targets SDK 13
>
> Reviewed-by: aghaisas, jvos, mstrauss
@johanvos I think that "Backport" must be capitalized in the PR title (not 100%
sure, but it seems like Skara doesn't rec
On Thu, 19 Jan 2023 09:59:30 GMT, Johan Vos wrote:
> set release version to 19.0.2.1
> Fix for JDK-8300640
This pull request has now been integrated.
Changeset: 06e167ad
Author:Johan Vos
URL:
https://git.openjdk.org/jfx/commit/06e167adf9e737308ebd4b9d6ba3ff76bcc00a53
Stats: 2 li
No check was present in `RadioMenuItem` accelerator to see if it is in a
`ToggleGroup` or not.
Made changes to check if `RadioMenuItem` is part of `ToggleGroup` or not. If it
is part of a `ToggleGroup`, then it can not be cleared using accelerator.
Added test to validate the change.
--
On Thu, 19 Jan 2023 09:59:30 GMT, Johan Vos wrote:
> set release version to 19.0.2.1
> Fix for JDK-8300640
Marked as reviewed by kcr (Lead).
-
PR: https://git.openjdk.org/jfx/pull/1001
Approved.
-- Kevin
On 1/19/2023 2:01 AM, Johan Vos wrote:
Hi Kevin,
I request permission to backport the fix for JDK-8296654 [1] to
jfx/jfx19 (after the version has been increased to 19.0.2.1 [2]).
Thanks,
- Johan
[1] https://bugs.openjdk.org/browse/JDK-8296654
[2] https://bugs.openjdk.or
+1
On 1/19/2023 1:46 AM, Johan Vos wrote:
Hi,
If the JDK installed by Homebrew (is there a public build recipe that
Homebrew is using?) in combination with JavaFX causes apps to crash,
then the situation is really bad indeed.
Kevin and myself will work on the administration to have a 19.0.2.1
set release version to 19.0.2.1
Fix for JDK-8300640
-
Commit messages:
- Bump JavaFX patch version to 19.0.2.1 for jfx19
Changes: https://git.openjdk.org/jfx/pull/1001/files
Webrev: https://webrevs.openjdk.org/?repo=jfx&pr=1001&range=00
Issue: https://bugs.openjdk.org/browse/JDK-
Hi Kevin,
I request permission to backport the fix for JDK-8296654 [1] to jfx/jfx19
(after the version has been increased to 19.0.2.1 [2]).
Thanks,
- Johan
[1] https://bugs.openjdk.org/browse/JDK-8296654
[2] https://bugs.openjdk.org/browse/JDK-8300640
Hi,
If the JDK installed by Homebrew (is there a public build recipe that
Homebrew is using?) in combination with JavaFX causes apps to crash, then
the situation is really bad indeed.
Kevin and myself will work on the administration to have a 19.0.2.1 patch
update.
- Johan
On Wed, Jan 18, 2023 a
29 matches
Mail list logo
