Re: RFR: 8299756: Minor updates in CSS Reference

2023-05-29 Thread Ajit Ghaisas
On Fri, 26 May 2023 22:26:49 GMT, Andy Goryachev wrote: > Minor fixes and addition of missing sections: > > - The 'system' font is missing from the list of generic font family names in > the section. ✓ > - Explicitly add text color property -fx-fill to Text section, so as not to > confuse

Re: Implementation not following documentation regarding when event handler gets called

2023-05-29 Thread Nir Lisker
Didn't look too deep, but seems like a bug or incorrect doc. I don't see such specifications in other "setOnX" methods. On Sun, May 28, 2023 at 1:02 PM John Hendrikx wrote: > When looking at the code for Scene#setOnKeyPressed, I noticed that it > calls Scene#setEventHandler. This is documented

Withdrawn: 8277848 Binding and Unbinding to List leads to memory leak

2023-05-29 Thread duke
On Tue, 7 Dec 2021 14:57:00 GMT, Florian Kirmaier wrote: > Making the initial listener of the ListProperty weak fixes the problem. > The same is fixed for Set and Map. > Due to a smart implementation, this is done without any performance drawback. > (The trick is to have an object, which is both

Withdrawn: 8299423: JavaFX Mac system menubar leaks

2023-05-29 Thread duke
On Fri, 30 Dec 2022 09:41:46 GMT, Florian Kirmaier wrote: > This PR fixes the leak in the mac system menu bar. > > Inside the native code, NewGlobalRef is called for the callable. > Which makes it into a "GC-Root" until DeleteGlobalRef is called. > > The DeleteGlobalRef is never called for