Re: RFR: 8274932: Render scales in EmbeddedWindow are not properly updated [v6]

2023-07-27 Thread Prasanta Sadhukhan
On Thu, 27 Jul 2023 17:50:11 GMT, John Hendrikx wrote: > This is how I understand this works: > > The `JFXPanel` makes use of an `EmbeddedWindow` that is a subclass of > `Window`. This window listens to its `showing` property, and when it becomes > visible will call `updateOutputScales`; this

[jfx21] RFR: 8313227: Correct attenuation indicator for removed lights

2023-07-27 Thread Nir Lisker
Backport of commit [b323db26](https://github.com/openjdk/jfx/commit/b323db262906853afbdec7a747f3b2f5b6593b9b) (PR https://github.com/openjdk/jfx/pull/1186) - Commit messages: - Backport b323db262906853afbdec7a747f3b2f5b6593b9b Changes: https://git.openjdk.org/jfx/pull/1187/files

Integrated: 8313227: Correct attenuation indicator for removed lights

2023-07-27 Thread Nir Lisker
On Thu, 27 Jul 2023 03:39:06 GMT, Nir Lisker wrote: > A simple fix of changing the attenuation toggle from 1 to 0 for removed > lights. This pull request has now been integrated. Changeset: b323db26 Author:Nir Lisker URL:

Re: RFR: 8313227: Correct attenuation indicator for removed lights

2023-07-27 Thread Kevin Rushforth
On Thu, 27 Jul 2023 03:39:06 GMT, Nir Lisker wrote: > A simple fix of changing the attenuation toggle from 1 to 0 for removed > lights. Marked as reviewed by kcr (Lead). - PR Review: https://git.openjdk.org/jfx/pull/1186#pullrequestreview-1551015235

Re: RFR: 8313227: Correct attenuation indicator for removed lights

2023-07-27 Thread Kevin Rushforth
On Thu, 27 Jul 2023 22:07:40 GMT, Kevin Rushforth wrote: > > By the way, the lighting in the LightingSample test application looks a bit > > off to me (regardless of this patch). It's as if the point and spot lights > > are too dim even at close range. Do you also notice that? Might need to >

Re: RFR: 8313227: Correct attenuation indicator for removed lights

2023-07-27 Thread Kevin Rushforth
On Thu, 27 Jul 2023 03:44:56 GMT, Nir Lisker wrote: > @kevinrushforth I think that this is simple enough to be able to get into > RDP1. There is some performance improvement regained here that was lost in > one of my previous enhancements because of my mistake of setting this > parameter to

Re: RFR: 8274932: Render scales in EmbeddedWindow are not properly updated [v6]

2023-07-27 Thread John Hendrikx
On Tue, 11 Jul 2023 07:58:07 GMT, Prasanta Sadhukhan wrote: >> When the JavaFX scene is set before it is really shown, then the scale >> factors are not properly propagated to the EmbeddedWindow, resulting in >> showing wrong scales. >> Fix is made to update scales to EmbeddedWindow > >

Re: RFR: 8090267: JFXPanel Input Problem

2023-07-27 Thread Andy Goryachev
On Tue, 4 Jul 2023 05:54:54 GMT, Prasanta Sadhukhan wrote: > When Japanse (IME on) is inputted to the TextFIeld, which is on JFXPanel, > small window for inputting appears on top-left side of screen > >

Re: RFR: 8090267: JFXPanel Input Problem

2023-07-27 Thread Prasanta Sadhukhan
On Tue, 4 Jul 2023 05:54:54 GMT, Prasanta Sadhukhan wrote: > When Japanse (IME on) is inputted to the TextFIeld, which is on JFXPanel, > small window for inputting appears on top-left side of screen > >

Re: RFR: 8274932: Render scales in EmbeddedWindow are not properly updated [v6]

2023-07-27 Thread Prasanta Sadhukhan
On Tue, 11 Jul 2023 07:58:07 GMT, Prasanta Sadhukhan wrote: >> When the JavaFX scene is set before it is really shown, then the scale >> factors are not properly propagated to the EmbeddedWindow, resulting in >> showing wrong scales. >> Fix is made to update scales to EmbeddedWindow > >