On Thu, 2 Nov 2023 16:26:57 GMT, Jayathirth D V wrote:
> This is jfx21u backport of https://bugs.openjdk.org/browse/JDK-8319079
> It adds appropriate range checks in native code for Box/Gaussian Blur/Shadow
> effects in Software pipeline.
This pull request has now been integrated.
Changeset:
Hi,
About Wayland:
Porting es2 to use EGL instead of GLX is pretty straightforward, so
converting a X11GL* to WaylandGL* is easy (GLX is X11 only, so this is why
EGL is needed).
The problem is Gtk4 and/or Gtk3 with Wayland won't allow you to paint
directly to the window as es2 do.
I've tried to
On Thu, 2 Nov 2023 22:34:10 GMT, Nir Lisker wrote:
>> That's correct.
>>
>>> can the value in preferences be `null`?
>>
>> It could be `null` (signalling a removal), but then that's a no-op if the
>> key wasn't present in `effectivePreferences`.
>
> So now I'm wondering why the need for the
On Thu, 2 Nov 2023 19:11:39 GMT, Michael Strauß wrote:
>> modules/javafx.graphics/src/main/java/com/sun/javafx/application/preferences/PlatformPreferences.java
>> line 198:
>>
>>> 196: * @throws NullPointerException if {@code preferences} is {@code
>>> null}
>>> 197: */
>>> 198:
On Thu, 2 Nov 2023 19:13:58 GMT, Thiago Milczarek Sayao
wrote:
> JavaFX on Linux is allowing disabled windows to be minimized.
>
> Currently close does nothing as it should, maximize disappears (on MS Windows
> it's greyed out - it's a platform behavior difference) and minimize is being
>
On Fri, 8 Sep 2023 07:07:40 GMT, Jayathirth D V wrote:
> Two perspective lod tests fail because of minute differences in expected
> values.
>
> Failing tests:
> test/scenegraph/fx3d/lod/PerspectiveLodCameraTest.java:
> test/scenegraph/fx3d/lod/PerspectiveLodGroupTest.java:
>
> Exception:
>
Observed that the window manager takes care of showing and hiding children
because we set `gtk_window_set_transient_for`.
Works since Ubuntu 16.04.
This PR removes the code to show or hide children because it "duplicates" the
operation and might lead to unknown bugs.
-
Commit
JavaFX on Linux is allowing disabled windows to be minimized.
Currently close does nothing as it should, maximize disappears (on MS Windows
it's greyed out - it's a platform behavior difference) and minimize is being
allowed.
Thins PR removes WM functions when window is disabled and restores
On Thu, 2 Nov 2023 19:05:27 GMT, Nir Lisker wrote:
>> Michael Strauß has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> changend bool comparison
>
>
On Wed, 1 Nov 2023 17:36:21 GMT, Michael Strauß wrote:
>> Please read [this
>> document](https://gist.github.com/mstr2/9f46f92c98d3c86aa6a0b4224a9a6548)
>> for an introduction to the Platform Preferences API, and how it interacts
>> with the proposed style theme and stage appearance features.
> Please read [this
> document](https://gist.github.com/mstr2/9f46f92c98d3c86aa6a0b4224a9a6548) for
> an introduction to the Platform Preferences API, and how it interacts with
> the proposed style theme and stage appearance features.
Michael Strauß has updated the pull request incrementally
On Wed, 1 Nov 2023 13:59:07 GMT, Nir Lisker wrote:
>> Michael Strauß has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - formatting
>> - Javadoc change
>
>
Hi,
Hold on this question, it might not be necessary.
Looking into it.
Em qui., 2 de nov. de 2023 às 10:21, Thiago Milczarek Sayão <
thiago.sa...@gmail.com> escreveu:
> Hi,
>
> On Linux, the current behavior of SetEnabled(true / false) does not work
> very well.
> Ideally it should use native
On Thu, 2 Nov 2023 13:47:26 GMT, Kevin Rushforth wrote:
> Looks good. Please file a follow-up bug to get the tests running on Windows.
I have created follow-up issue https://bugs.openjdk.org/browse/JDK-8319329 for
Windows.
-
PR Comment:
This is jfx21u backport of https://bugs.openjdk.org/browse/JDK-8319079
It adds appropriate range checks in native code for Box/Gaussian Blur/Shadow
effects in Software pipeline.
-
Commit messages:
- Backport 96e5d10a40dc25b999ff229f1d6601d1058761b2
Changes:
On Tue, 31 Oct 2023 08:05:56 GMT, vlaaad wrote:
>> This PR addresses [JDK-8284445](https://bugs.openjdk.org/browse/JDK-8284445).
>>
>> Context: the warning might be more important than it seems. Our JavaFX-based
>> desktop app has [an issue](https://github.com/defold/defold/issues/7845) —
>>
On Tue, 31 Oct 2023 08:05:56 GMT, vlaaad wrote:
>> This PR addresses [JDK-8284445](https://bugs.openjdk.org/browse/JDK-8284445).
>>
>> Context: the warning might be more important than it seems. Our JavaFX-based
>> desktop app has [an issue](https://github.com/defold/defold/issues/7845) —
>>
On Thu, 2 Nov 2023 11:43:06 GMT, Ambarish Rapte wrote:
>> vlaaad has updated the pull request incrementally with one additional commit
>> since the last revision:
>>
>> Don't use NSFunctionKeyMask as modifier at all
>
> When a function key is pressed
>
On Thu, 2 Nov 2023 06:04:23 GMT, Prasanta Sadhukhan
wrote:
> A manual regression test for JFXPanel orientation fix in
> [JDK-8317836](https://bugs.openjdk.org/browse/JDK-8317836) is added
looks good, works as expected with the latest master.
-
Marked as reviewed by angorya
On Wed, 15 Apr 2020 15:14:49 GMT, Arun Joseph wrote:
>> Issue: Assuming the pixelScale is 2, the tile image size is doubled at the
>> native side which is propagated to the java side as well. But, as transform
>> initialization takes place after scaling, the transform is reset to default
>>
> Modified the resize algorithm to work well with fractional scale, thanks for
> deeper understanding of the problem thanks to @hjohn and @mstr2 .
>
> It is important to note that even though the constraints are given by the
> user in unsnapped coordinates, they are converted to snapped
On Wed, 11 Oct 2023 11:18:17 GMT, Jayathirth D V wrote:
>> Two perspective lod tests fail because of minute differences in expected
>> values.
>>
>> Failing tests:
>> test/scenegraph/fx3d/lod/PerspectiveLodCameraTest.java:
>> test/scenegraph/fx3d/lod/PerspectiveLodGroupTest.java:
>>
>>
On Wed, 15 Apr 2020 15:14:49 GMT, Arun Joseph wrote:
>> Issue: Assuming the pixelScale is 2, the tile image size is doubled at the
>> native side which is propagated to the java side as well. But, as transform
>> initialization takes place after scaling, the transform is reset to default
>>
On Tue, 31 Oct 2023 17:28:35 GMT, Michael Strauß wrote:
>> Please read [this
>> document](https://gist.github.com/mstr2/9f46f92c98d3c86aa6a0b4224a9a6548)
>> for an introduction to the Platform Preferences API, and how it interacts
>> with the proposed style theme and stage appearance
Hi,
On Linux, the current behavior of SetEnabled(true / false) does not work
very well.
Ideally it should use native MODALITY.
On GTK MODAL means APPLICATION_MODAL.
MODAL as in JavaFX would be archived by using Window groups:
https://docs.gtk.org/gtk3/ctor.WindowGroup.new.html
I would make
On Wed, 15 Apr 2020 13:35:11 GMT, Kevin Rushforth wrote:
>> Arun Joseph has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update copyright year
>
> As discussed offline, please add a test for this.
@kevinrushforth Looks like the
On Mon, 30 Oct 2023 06:55:11 GMT, Jayathirth D V wrote:
> In SW pipeline path of Box/Gaussian Blur/Shadow effects we are not checking
> for range when we read data from the source/destination buffers in native
> code.
>
> We need to add appropriate range checks in native JNI code also apart
On Thu, 2 Nov 2023 11:39:47 GMT, Johan Vos wrote:
> When the Java layer removes a systemmenu, release the native resources
> related to this systemmenu.
> This removes the strong JNI Global ref, which prevents its references from
> being gc'ed.
>
> The current implementation for the
On Thu, 2 Nov 2023 06:55:29 GMT, Jayathirth D V wrote:
>> In SW pipeline path of Box/Gaussian Blur/Shadow effects we are not checking
>> for range when we read data from the source/destination buffers in native
>> code.
>>
>> We need to add appropriate range checks in native JNI code also
On Tue, 31 Oct 2023 08:05:56 GMT, vlaaad wrote:
>> This PR addresses [JDK-8284445](https://bugs.openjdk.org/browse/JDK-8284445).
>>
>> Context: the warning might be more important than it seems. Our JavaFX-based
>> desktop app has [an issue](https://github.com/defold/defold/issues/7845) —
>>
When the Java layer removes a systemmenu, release the native resources related
to this systemmenu.
This removes the strong JNI Global ref, which prevents its references from
being gc'ed.
The current implementation for the mac-specific system menu creates a menu, but
never releases its
On Tue, 8 Aug 2023 23:44:58 GMT, Jose Pereda wrote:
>> So far, BorderPane does the calculation for the children min/pref
>> width/height taken into account only the margin applied to them, if any, but
>> not the total padding that could be applied as well to the BorderPane itself.
>>
>>
On Fri, 4 Aug 2023 18:13:34 GMT, Marius Hanl wrote:
> Before, the `updateItem` method was called with the new value that was
> committed via `commitEdit()`.
> This is problematic as developers may setup a commit handler via
> `setOnEditCommit`, which may reject the edit (or change the value
On Wed, 1 Nov 2023 19:47:42 GMT, Johan Vos wrote:
> … command to be ignored
>
> Reviewed-by: ehelin, angorya
This pull request has now been integrated.
Changeset: 192480a4
Author:Johan Vos
URL:
https://git.openjdk.org/jfx17u/commit/192480a4e7970904c6b5a729681b1c89f5dc504d
Stats:
On Thu, 2 Nov 2023 08:16:43 GMT, Marius Hanl wrote:
>> Before, the `updateItem` method was called with the new value that was
>> committed via `commitEdit()`.
>> This is problematic as developers may setup a commit handler via
>> `setOnEditCommit`, which may reject the edit (or change the
> Before, the `updateItem` method was called with the new value that was
> committed via `commitEdit()`.
> This is problematic as developers may setup a commit handler via
> `setOnEditCommit`, which may reject the edit (or change the value otherwise).
> We therefore do call the `updateItem(-1)`
A manual regression test for JFXPanel orientation fix in
[JDK-8317836](https://bugs.openjdk.org/browse/JDK-8317836) is added
-
Commit messages:
- Test fix
- Test fix
Changes: https://git.openjdk.org/jfx/pull/1276/files
Webrev: https://webrevs.openjdk.org/?repo=jfx=1276=00
On Thu, 2 Nov 2023 06:55:29 GMT, Jayathirth D V wrote:
>> In SW pipeline path of Box/Gaussian Blur/Shadow effects we are not checking
>> for range when we read data from the source/destination buffers in native
>> code.
>>
>> We need to add appropriate range checks in native JNI code also
On Tue, 31 Oct 2023 14:54:01 GMT, Kevin Rushforth wrote:
>> Jayathirth D V has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Add common util function
>
> modules/javafx.graphics/src/main/native-decora/SSEUtils.cc line 187:
>
>> 185: }
>>
> In SW pipeline path of Box/Gaussian Blur/Shadow effects we are not checking
> for range when we read data from the source/destination buffers in native
> code.
>
> We need to add appropriate range checks in native JNI code also apart from
> range checks in Java side to make sure that
40 matches
Mail list logo
