Re: RFR: 8325900: Emit a warning on macOS if AWT has set the NSAppearance [v2]

2024-02-14 Thread Michael Strauß
> Platform preferences detection doesn't pick up effective macOS system > preferences if AWT owns the NSApplication and has set its NSAppearance to a > fixed value. > > The workaround is to set the system property > "apple.awt.application.appearance=system". > > If this property is not set, th

Re: [jfx22] RFR: 8325873: Update JDK_DOCS property to point to JDK 21 docs

2024-02-14 Thread Ambarish Rapte
On Thu, 15 Feb 2024 00:31:23 GMT, Kevin Rushforth wrote: > Clean backport of a docs-only fix to jfx22. Marked as reviewed by arapte (Reviewer). - PR Review: https://git.openjdk.org/jfx/pull/1369#pullrequestreview-1881602522

Re: [jfx22] RFR: 8325873: Update JDK_DOCS property to point to JDK 21 docs

2024-02-14 Thread Kevin Rushforth
On Thu, 15 Feb 2024 00:31:23 GMT, Kevin Rushforth wrote: > Clean backport of a docs-only fix to jfx22. Reviewer: @arapte - PR Comment: https://git.openjdk.org/jfx/pull/1369#issuecomment-1945177161

[jfx22] RFR: 8325873: Update JDK_DOCS property to point to JDK 21 docs

2024-02-14 Thread Kevin Rushforth
Clean backport of a docs-only fix to jfx22. - Commit messages: - Backport f379eae65aab963779d7b7335cbade810f8efe82 Changes: https://git.openjdk.org/jfx/pull/1369/files Webrev: https://webrevs.openjdk.org/?repo=jfx&pr=1369&range=00 Issue: https://bugs.openjdk.org/browse/JDK-832587

Re: RFR: 8322748: Caret blinking in JavaFX should only stop when caret moves

2024-02-14 Thread Andy Goryachev
On Wed, 14 Feb 2024 22:44:07 GMT, Andy Goryachev wrote: > Move caret animation handling due to keyboard input to the Skin, by > registering a listener on the caretPosition property. This will restart > animation only when the caret position changes instead of every key press. > > This also si

RFR: 8322748: Caret blinking in JavaFX should only stop when caret moves

2024-02-14 Thread Andy Goryachev
Move caret animation handling due to keyboard input to the Skin, by registering a listener on the caretPosition property. This will restart animation only when the caret position changes instead of every key press. This also simplifies internal behaviors of TextArea, TextField, and PasswordFie

Re: RFR: 8325900: Emit a warning on macOS if AWT has set the NSAppearance

2024-02-14 Thread Kevin Rushforth
On Wed, 14 Feb 2024 21:09:39 GMT, Michael Strauß wrote: > Platform preferences detection doesn't pick up effective macOS system > preferences if AWT owns the NSApplication and has set its NSAppearance to a > fixed value. > > The workaround is to set the system property > "apple.awt.applicatio

Integrated: 8325873: Update JDK_DOCS property to point to JDK 21 docs

2024-02-14 Thread Kevin Rushforth
On Wed, 14 Feb 2024 15:19:47 GMT, Kevin Rushforth wrote: > Simple fix to update the pointer to the JDK docs to JDK 21 (matching the > current boot JDK). The only impact of this change is that hyperlinks in the > generated API docs will link to the online JDK 21 docs. As this is a > docs-only c

RFR: 8325900: Emit a warning on macOS if AWT has set the NSAppearance

2024-02-14 Thread Michael Strauß
Platform preferences detection doesn't pick up effective macOS system preferences if AWT owns the NSApplication and has set its NSAppearance to a fixed value. The workaround is to set the system property "apple.awt.application.appearance=system". If this property is not set, the following warn

Re: RFR: JDK-8325402: TreeTableRow updateItem() does not check item with isItemChanged(..) unlike all other cell implementations

2024-02-14 Thread Andy Goryachev
On Wed, 14 Feb 2024 20:52:44 GMT, Marius Hanl wrote: >> modules/javafx.controls/src/test/java/test/javafx/scene/control/TreeTableViewTest.java >> line 2639: >> >>> 2637: StageLoader sl = new StageLoader(treeTableView); >>> 2638: >>> 2639: assertEquals(18, rt_31200_count); >> >

Re: RFR: JDK-8325402: TreeTableRow updateItem() does not check item with isItemChanged(..) unlike all other cell implementations

2024-02-14 Thread Andy Goryachev
On Wed, 14 Feb 2024 20:48:33 GMT, Marius Hanl wrote: >> modules/javafx.controls/src/main/java/javafx/scene/control/TreeTableRow.java >> line 424: >> >>> 422: // proceed with the code following this, so that >>> we may >>> 423: // still update references,

Re: RFR: JDK-8325402: TreeTableRow updateItem() does not check item with isItemChanged(..) unlike all other cell implementations

2024-02-14 Thread Marius Hanl
On Wed, 14 Feb 2024 19:21:39 GMT, Andy Goryachev wrote: >> `TreeTableRow` does not check the item with `isItemChanged(..)`, unlike all >> other implementations of the cell. >> >> This also means that the `TreeTableRow` always updates the item, although it >> should not, resulting in a performa

Re: RFR: JDK-8325402: TreeTableRow updateItem() does not check item with isItemChanged(..) unlike all other cell implementations

2024-02-14 Thread Marius Hanl
On Wed, 14 Feb 2024 19:25:27 GMT, Andy Goryachev wrote: >> `TreeTableRow` does not check the item with `isItemChanged(..)`, unlike all >> other implementations of the cell. >> >> This also means that the `TreeTableRow` always updates the item, although it >> should not, resulting in a performa

Re: RFR: JDK-8325402: TreeTableRow updateItem() does not check item with isItemChanged(..) unlike all other cell implementations

2024-02-14 Thread Andy Goryachev
On Thu, 8 Feb 2024 18:55:54 GMT, Marius Hanl wrote: > `TreeTableRow` does not check the item with `isItemChanged(..)`, unlike all > other implementations of the cell. > > This also means that the `TreeTableRow` always updates the item, although it > should not, resulting in a performance loss

Re: [External] : Re: Platform preferences theme detection

2024-02-14 Thread Kevin Rushforth
I filed https://bugs.openjdk.org/browse/JDK-8325888 to track this. -- Kevin On 2/13/2024 11:11 AM, Michael Strauß wrote: The reason why the values are wrong might be that in PlatformSupport.m L105, we query [NSApp effectiveApperance], but this always seems to return the light appearance if Java

Re: RFR: 8325873: Update JDK_DOCS property to point to JDK 21 docs

2024-02-14 Thread Ambarish Rapte
On Wed, 14 Feb 2024 15:19:47 GMT, Kevin Rushforth wrote: > Simple fix to update the pointer to the JDK docs to JDK 21 (matching the > current boot JDK). The only impact of this change is that hyperlinks in the > generated API docs will link to the online JDK 21 docs. As this is a > docs-only c

Re: Attachment size limits for the mailing list

2024-02-14 Thread Andy Goryachev
Thank you, Kevin! -andy From: openjfx-dev on behalf of Kevin Rushforth Date: Wednesday, February 14, 2024 at 07:45 To: openjfx-dev@openjdk.org Subject: Re: Attachment size limits for the mailing list I was pleasantly surprised to see that this setting is configurable on a per-mailing-list b

Re: Attachment size limits for the mailing list

2024-02-14 Thread Kevin Rushforth
I was pleasantly surprised to see that this setting is configurable on a per-mailing-list basis. I just now bumped the limit to 4 Mbytes (for openjfx-dev only). -- Kevin On 2/14/2024 7:38 AM, Andy Goryachev wrote: +1 PNG Screenshots on macOS retina might easily be 3MB or more. -andy *Fro

Re: Attachment size limits for the mailing list

2024-02-14 Thread Andy Goryachev
+1 PNG Screenshots on macOS retina might easily be 3MB or more. -andy From: openjfx-dev on behalf of Christopher Schnick Date: Wednesday, February 14, 2024 at 07:33 To: openjfx-dev@openjdk.org Subject: Attachment size limits for the mailing list Hello, over the last few days I ran into the

Integrated: 8325154: resizeColumnToFitContent is slower than it needs to be

2024-02-14 Thread Robert Lichtenberger
On Fri, 2 Feb 2024 06:55:36 GMT, Robert Lichtenberger wrote: > The PR simply moves column and view-updates outside the loop. Since the > column or view never changes within the for-loop it is not necessary to call > these again and again. This pull request has now been integrated. Changeset:

Attachment size limits for the mailing list

2024-02-14 Thread Christopher Schnick
Hello, over the last few days I ran into the attachment size limit of this mailing list several times, causing the mails to be suspended until they are approved. There is also I think another mail still in the moderation queue. I think it would be a good idea to increase the size limit to al

Re: RFR: 8325873: Update JDK_DOCS property to point to JDK 21 docs

2024-02-14 Thread Kevin Rushforth
On Wed, 14 Feb 2024 15:19:47 GMT, Kevin Rushforth wrote: > Simple fix to update the pointer to the JDK docs to JDK 21 (matching the > current boot JDK). The only impact of this change is that hyperlinks in the > generated API docs will link to the online JDK 21 docs. As this is a > docs-only c

RFR: 8325873: Update JDK_DOCS property to point to JDK 21 docs

2024-02-14 Thread Kevin Rushforth
Simple fix to update the pointer to the JDK docs to JDK 21 (matching the current boot JDK). The only impact of this change is that hyperlinks in the generated API docs will link to the online JDK 21 docs. As this is a docs-only change, I intend to backport this to the jfx22 stabilization branch

Re: RFR: JDK-8324182 Deprecate for removal SimpleSelector and CompoundSelector classes [v2]

2024-02-14 Thread Kevin Rushforth
On Tue, 13 Feb 2024 13:33:36 GMT, John Hendrikx wrote: > CSR was created I reviewed the CSR. - PR Comment: https://git.openjdk.org/jfx/pull/1340#issuecomment-1943718956

Re: RFR: 8309374: Accessibility Focus Rectangle on ListItem is not drawn when ListView is shown for first time [v2]

2024-02-14 Thread Kevin Rushforth
On Wed, 14 Feb 2024 02:55:15 GMT, Ambarish Rapte wrote: >> This is accessibility specific fix. >> >> **Issue**: When a ListView is shown for first time then accessibility focus >> rectangle is not drawn around the focused ListIem >> >> **Cause:** >>The ListView takes a little time to crea