[jfx22u] Integrated: Merge jfx:jfx22

2024-02-16 Thread Kevin Rushforth
On Fri, 16 Feb 2024 22:47:52 GMT, Kevin Rushforth wrote: > Clean merge of `jfx:jfx22` to `jfx22u:master` This pull request has now been integrated. Changeset: 9d0592f5 Author:Kevin Rushforth URL: https://git.openjdk.org/jfx22u/commit/9d0592f5a44cad789e92e6bff218bc9606272c1f Stats:

[jfx22u] RFR: Merge jfx:jfx22

2024-02-16 Thread Kevin Rushforth
Clean merge of `jfx:jfx22` to `jfx22u:master` - Commit messages: - Merge jfx:master - 8325873: Update JDK_DOCS property to point to JDK 21 docs The merge commit only contains trivial merges, so no merge-specific webrevs have been generated. Changes: https://git.openjdk.org/jfx22u

RFR: 8325591: [Mac] DRAG_DONE reports null transferMode when destination is external

2024-02-16 Thread Martin Fox
At the end of a drag operation the Mac Glass code sends out a DRAG_DONE event using the operation mask tracked in the GlassDragSource to determine the final transfer mode. That mask is only updated when a window in the JavaFX app is the drop destination. If the drag moves to an external destinat

Proposal: Bump minimum JDK version for JavaFX 23 to JDK 21

2024-02-16 Thread Kevin Rushforth
All, Even though we build JavaFX binaries with JDK 21 as the boot JDK, the latest version of JavaFX still runs with JDK 17, although it isn't tested with older JDK versions. In order for JavaFX to be able to use newer JDK features, such as code snippets (in API docs), record patterns, pattern

[jfx21u] RFR: 8325154: resizeColumnToFitContent is slower than it needs to be

2024-02-16 Thread Jose Pereda
Hi all, This pull request contains a clean backport of commit [e2f42c5b](https://github.com/openjdk/jfx/commit/e2f42c5b71ef061c614540508fbac3fb610b1ae3) from the [openjdk/jfx](https://git.openjdk.org/jfx) repository. The commit being backported was authored by Robert Lichtenberger on 14 Feb 202

Re: UI scaling issues when physical and logical screen resolutions differ on Linux

2024-02-16 Thread Martin Fox
Hi Christopher, This may be a side-effect of using KDE. To determine the UI scale the JavaFX code consults the “scaling-factor” setting in the “org.gnome.desktop.interface” schema. You can check this on the command line: gsettings get org.gnome.desktop.interface scaling-factor This sho

Re: [jfx17u] RFR: 8221261: Deadlock on macOS in JFXPanel app when handling IME calls

2024-02-16 Thread Johan Vos
On Thu, 8 Feb 2024 09:11:13 GMT, Johannes Bechberger wrote: > Clean backport of 8221261: Deadlock on macOS in JFXPanel app when handling > IME calls Marked as reviewed by jvos (Reviewer). - PR Review: https://git.openjdk.org/jfx17u/pull/178#pullrequestreview-1885952738

Re: RFR: 8322748: Caret blinking in JavaFX should only stop when caret moves [v2]

2024-02-16 Thread Andy Goryachev
On Fri, 16 Feb 2024 19:23:00 GMT, John Hendrikx wrote: > I think those tests should be unit tests, not via Robot Preferably, yes. If something can be tested via headless unit tests, it should be done so, you are absolutely right. Some tests, however, require a fully rendered skin - for exampl

Re: RFR: 8322748: Caret blinking in JavaFX should only stop when caret moves [v2]

2024-02-16 Thread John Hendrikx
On Fri, 16 Feb 2024 16:00:07 GMT, Andy Goryachev wrote: > As a side note, before we can start re-writing the controls' behaviors, we > should: > > a) identify all the behavioral aspects of each control and b) develop a set > of tests to exercise each one, along the lines of > [JDK-8314906](ht

Re: [External] : Re: Platform preferences theme detection

2024-02-16 Thread Kevin Rushforth
Good to hear. Thanks for confirming. -- Kevin On 2/15/2024 4:46 AM, Christopher Schnick wrote: Just wanted to let you know that after setting apple.awt.application.appearance=system everything works as expected now. Thanks for all the work on this great feature. I plan to release the next v

Re: RFR: 8322748: Caret blinking in JavaFX should only stop when caret moves [v2]

2024-02-16 Thread Andy Goryachev
On Fri, 16 Feb 2024 13:15:14 GMT, John Hendrikx wrote: > so I guess I'll file another one. Thank you, please do. As a side note, before we can start re-writing the controls' behaviors, we should: a) identify all the behavioral aspects of each control and b) develop a set of tests to exercise

Re: RFR: 8322748: Caret blinking in JavaFX should only stop when caret moves [v2]

2024-02-16 Thread Andy Goryachev
On Thu, 15 Feb 2024 17:29:10 GMT, Andy Goryachev wrote: >> Move caret animation handling due to keyboard input to the Skin, by >> registering a listener on the caretPosition property. This will restart >> animation only when the caret position changes instead of every key press. >> >> This al

[jfx22u] Integrated: 8323880: Caret rendered at wrong position in case of a click event on RTL text

2024-02-16 Thread Jay Bhaskar
On Fri, 16 Feb 2024 14:00:57 GMT, Jay Bhaskar wrote: > A clean backport to jfx22u. The fix is for rtl text issue, where the caret > position is at the wrong position. I have tested the fix it is working with > the fix and failing without the fix. This pull request has now been integrated. Cha

[jfx22u] RFR: 8323880: Caret rendered at wrong position in case of a click event on RTL text

2024-02-16 Thread Jay Bhaskar
A clean backport to jfx22u. The fix is for rtl text issue, where the caret position is at the wrong position. I have tested the fix it is working with the fix and failing without the fix. - Commit messages: - Backport 1fb56e333bc65860cc1abeebd1cbb01cd8b8e5f3 Changes: https://git.o

Re: [jfx17u] RFR: 8221261: Deadlock on macOS in JFXPanel app when handling IME calls

2024-02-16 Thread Kevin Rushforth
On Thu, 8 Feb 2024 09:11:13 GMT, Johannes Bechberger wrote: > Clean backport of 8221261: Deadlock on macOS in JFXPanel app when handling > IME calls The backport looks fine to me. @johanvos will need to review / approve it for inclusion into jfx17u as he maintains this code line. --

Re: RFR: 8322748: Caret blinking in JavaFX should only stop when caret moves [v2]

2024-02-16 Thread John Hendrikx
On Thu, 15 Feb 2024 17:26:39 GMT, Andy Goryachev wrote: > > I think if we're busy here, it would be worthwhile to also remove the other > > calls to the skin to change the caret animating. > > I would rather not: it would require a much larger effort. Avoiding the caret > flickering when its p

Re: RFR: 8322748: Caret blinking in JavaFX should only stop when caret moves [v2]

2024-02-16 Thread John Hendrikx
On Thu, 15 Feb 2024 17:29:10 GMT, Andy Goryachev wrote: >> Move caret animation handling due to keyboard input to the Skin, by >> registering a listener on the caretPosition property. This will restart >> animation only when the caret position changes instead of every key press. >> >> This al