On Fri, 1 Mar 2024 18:44:17 GMT, Marius Hanl wrote:
>> This PR fixes the dialog freeze problem once and for all.
>>
>> This one is a bit tricky to understand, here is how it works:
>> This bug happens on every platform, although the implementation of nested
>> event loops differs on every plat
All,
Thank you to everyone who has provided feedback on the RichText proposal
so far. If I could characterize the response, there are some developers
who want at least a basic rich text control available as part of the
JavaFX core and other developers who don't think that such a control
shoul
I updated the Incubator Modules proposal to address Phil's feedback,
along with updating the example incubator module:
https://github.com/kevinrushforth/jfx/blob/javafx.incubator/INCUBATOR-MODULES.md
https://github.com/openjdk/jfx/pull/1375
-- Kevin
On 2/22/2024 2:32 PM, Kevin Rushforth wrote
On Fri, 1 Mar 2024 21:33:16 GMT, Martin Fox wrote:
> The output I would expect would be:
>
> ```
> enter1
> exit1
> enter2
> exit2
> 456
> 123
> ```
You are right, this sounds correct.
> By the way, when I grab the code in the original bug report and run it agains
> this PR the innermost moda
On Fri, 1 Mar 2024 18:44:17 GMT, Marius Hanl wrote:
>> This PR fixes the dialog freeze problem once and for all.
>>
>> This one is a bit tricky to understand, here is how it works:
>> This bug happens on every platform, although the implementation of nested
>> event loops differs on every plat
On Fri, 1 Mar 2024 18:44:17 GMT, Marius Hanl wrote:
>> This PR fixes the dialog freeze problem once and for all.
>>
>> This one is a bit tricky to understand, here is how it works:
>> This bug happens on every platform, although the implementation of nested
>> event loops differs on every plat
> This PR fixes the dialog freeze problem once and for all.
>
> This one is a bit tricky to understand, here is how it works:
> This bug happens on every platform, although the implementation of nested
> event loops differs on every platform.
> E.g. on Linux we use `gtk_main` and `gtk_main_quit`
On Wed, 28 Feb 2024 21:48:38 GMT, Andy Goryachev wrote:
> This change brings the number of javadoc warnings back to 91 (to be fixed in
> [JDK-8270996](https://bugs.openjdk.org/browse/JDK-8270996))
>
> - adds missing information in `@param` tags
> - adds `@SuppressWarnings("doclint:missing")` t
On Fri, 1 Mar 2024 15:53:21 GMT, Andy Goryachev wrote:
>> This change brings the number of javadoc warnings back to 91 (to be fixed in
>> [JDK-8270996](https://bugs.openjdk.org/browse/JDK-8270996))
>>
>> - adds missing information in `@param` tags
>> - adds `@SuppressWarnings("doclint:missing"
On Fri, 1 Mar 2024 16:19:14 GMT, Andy Goryachev wrote:
>> This PR is addressing doclint warnings, not javac lint warnings. javac
>> warnings can be addressed in a follow-up bug.
>
> FYI: after merging this and #1384 together all I see in the build log are 4
> native warnings (on macOS):
>
>
>
On Fri, Mar 1, 2024 at 4:04 PM Kevin Rushforth
wrote:
> Hi Johan,
>
> FOr the systemTests project, the gradle test runner does run each test
> class in its own VM, as a result of the "forkEvery = 1" setting. As
> noted, gradle launches tests using a gradle test runner class as the
> main method,
On Fri, 1 Mar 2024 15:53:21 GMT, Andy Goryachev wrote:
>> This change brings the number of javadoc warnings back to 91 (to be fixed in
>> [JDK-8270996](https://bugs.openjdk.org/browse/JDK-8270996))
>>
>> - adds missing information in `@param` tags
>> - adds `@SuppressWarnings("doclint:missing"
On Fri, 1 Mar 2024 13:05:23 GMT, Kevin Rushforth wrote:
>> modules/javafx.swing/src/main/java/javafx/embed/swing/JFXPanel.java line 142:
>>
>>> 140: * future Swing or JavaFX releases. The current serialization support
>>> is
>>> 141: * appropriate for short term storage or RMI between applica
On Fri, 1 Mar 2024 15:53:21 GMT, Andy Goryachev wrote:
>> This change brings the number of javadoc warnings back to 91 (to be fixed in
>> [JDK-8270996](https://bugs.openjdk.org/browse/JDK-8270996))
>>
>> - adds missing information in `@param` tags
>> - adds `@SuppressWarnings("doclint:missing"
On Fri, 1 Mar 2024 03:40:57 GMT, Ambarish Rapte wrote:
> there is no empty line between the description and `@param`
it makes no difference in the generated javadoc output.
I've made the changes anyway, for the developers' sake.
-
PR Comment: https://git.openjdk.org/jfx/pull/1384#i
> This change brings the number of javadoc warnings back to 91 (to be fixed in
> [JDK-8270996](https://bugs.openjdk.org/browse/JDK-8270996))
>
> - adds missing information in `@param` tags
> - adds `@SuppressWarnings("doclint:missing")` to `Skinnable` to silence the
> warning due to [JDK-832507
On Fri, 1 Mar 2024 00:22:05 GMT, Andy Goryachev wrote:
>> This change brings the number of javadoc warnings back to 91 (to be fixed in
>> [JDK-8270996](https://bugs.openjdk.org/browse/JDK-8270996))
>>
>> - adds missing information in `@param` tags
>> - adds `@SuppressWarnings("doclint:missing"
Hi Johan,
FOr the systemTests project, the gradle test runner does run each test
class in its own VM, as a result of the "forkEvery = 1" setting. As
noted, gradle launches tests using a gradle test runner class as the
main method, but there is still a 1 VM to 1 test class relationship.
We ha
On Tue, 27 Feb 2024 09:30:14 GMT, Johan Vos wrote:
>> A listener was added but never removed.
>> This patch removes the listener when the menu it links to is cleared. Fix
>> for https://bugs.openjdk.org/browse/JDK-8319779
>
> Johan Vos has updated the pull request with a new target base due to a
Hi,
We currently run systemtests using a gradle command, but that doesn't start
a clean Java process for the individual tests (which would be very
convenient as that allows us to inspect the process with VisualVM).
We know the behavior of a JavaFX application can be different depending if
1. the m
On Fri, 1 Mar 2024 03:49:20 GMT, Prasanta Sadhukhan
wrote:
>> Andy Goryachev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> review comments
>
> modules/javafx.swing/src/main/java/javafx/embed/swing/JFXPanel.java line 142:
>
>> 140: *
On Thu, 29 Feb 2024 15:48:30 GMT, Jose Pereda wrote:
> Almost clean backport of 8322703: Intermittent crash in WebView in a JFXPanel
> from IME calls on macOS
>
> Reviewed-by: jbhaskar, arapte
>
> Very minor conflicts after cherry picking the commit:
>
> // InputMethodRequests implementa
Hi everyone,
I updated the validation framework ValidatorFX today in our project to the
latest release and I really like it a lot. It is a small compact API and works
with any observable as opposed to the validation support provided by
ControlsFX.
Using it made me wonder whether it would make
On Thu, 29 Feb 2024 15:48:30 GMT, Jose Pereda wrote:
> Almost clean backport of 8322703: Intermittent crash in WebView in a JFXPanel
> from IME calls on macOS
>
> Reviewed-by: jbhaskar, arapte
>
> Very minor conflicts after cherry picking the commit:
>
> // InputMethodRequests implementa
24 matches
Mail list logo
