Am 08.03.24 um 00:40 schrieb Marius Hanl:
One note here regarding that a lot of things are final in JavaFX:
The problem is not that everything is final - this is intended and
makes sense, since we speak mostly of properties here. Overriding
those will not give you any benefit.
You mostly want
On 3/7/24 3:40 PM, Marius Hanl wrote:
This design is mostly superior than e.g. Swing, where you can override
things and easily break something if not too careful.
Pretty sure that this were some lessons learned from the development
of Swing.
That's what I remember, too, but I can't find any so
One note here regarding that a lot of things are final in JavaFX:
The problem is not that everything is final - this is intended and makes sense, since we speak mostly of properties here. Overriding those will not give you any benefit.
You mostly want to override e.g. Controls if you add some
After reading everything on this thread, I can understand all sides.
I think that a general RichTextArea control inside JavaFX is a nice addition and it somewhat makes sense to me as well.
But I also understand the other points, I agree that there is still a lot of work needed to improve an
I also like the idea of having some kind of Validation in JavaFX.
But I'm also unsure how/what to implement.
What I implemented for my application is some kind of Validator framework, which is:
- Binding itself to the textProperty() of TextInputControls
- Binding itself to the selected item f
On Wed, 6 Mar 2024 17:24:10 GMT, Martin Fox wrote:
>> Marius Hanl has updated the pull request incrementally with four additional
>> commits since the last revision:
>>
>> - test for multiple nested event loops
>> - try leave outer loop after finishing inner loop
>> - update copyright
>> -
> This PR fixes the dialog freeze problem once and for all.
>
> This one is a bit tricky to understand, here is how it works:
> This bug happens on every platform, although the implementation of nested
> event loops differs on every platform.
> E.g. on Linux we use `gtk_main` and `gtk_main_quit`
On Wed, 6 Mar 2024 17:24:10 GMT, Martin Fox wrote:
> The Mac is still failing the NestedEventLoop test.
Thanks for testing this on Mac. I always need to ask someone in order to test
the changes, so really appreciating that.
> I've created a branch with my proposed fix for this problem
> (http
On Thu, 7 Mar 2024 14:13:18 GMT, Johan Vos wrote:
>> Almost clean backport of JDK-8318386.
>> The original patch contains a fix to gstaacparse.c which is not in jfx17u
>> because it does not have JDK-8277309 (JDK-8277309)
>
> Johan Vos has updated the pull request with a new target base due to a
> Modified the resize algorithm to work well with fractional scale, thanks for
> deeper understanding of the problem thanks to @hjohn and @mstr2 .
>
> It is important to note that even though the constraints are given by the
> user in unsnapped coordinates, they are converted to snapped values,
> Adds **Labeled.textTruncated** property which indicates when the text is
> visually truncated (and the ellipsis string is inserted) in order to fit the
> available width.
>
> The new property reacts to changes in the following properties:
> - ellipsisString
> - font
> - height
> - text
> - wid
Marius, got your email literally before I could hit "Send" on mine!
You are right, of course, thank you for the effort.
-andy
From: Marius Hanl
Date: Thursday, March 7, 2024 at 10:51
To: Daniel Peintner
Cc: Andy Goryachev , openjfx-dev@openjdk.org
Subject: Aw: Re: [External] : Re: Q: Labeled
Daniel:
Thank you for providing a sample app!
You are right: turns out Labeled in a TableView (in a TreeTableView as well)
lives by different rules (TableCellSkinBase:152, TreeTableCellSkin:126).
The consequence of this is that the new functionality **cannot** be fully
implemented with the pub
The width of TableCells are bound to the column they belong to.
Therefore, prefWidth(-1) will always return the width of the column and not what the cell should ideally have.
See the computePrefWidth() method inside TableCellSkinBase.
There is a flag which unfortunately can not be set: isDeferT
On Thu, 7 Mar 2024 14:13:18 GMT, Johan Vos wrote:
>> Almost clean backport of JDK-8318386.
>> The original patch contains a fix to gstaacparse.c which is not in jfx17u
>> because it does not have JDK-8277309 (JDK-8277309)
>
> Johan Vos has updated the pull request with a new target base due to a
Andy, all,
Some comments below:
1. Even if it is possible to do the same with public means I think it is
useful. Anyhow we need to promote the solutions better (e.g., on
StackOverflow)
2. I tried to achieve what you did in JavaFX core for my use-case,
TableView cells.
1. In
On Thu, 7 Mar 2024 13:30:47 GMT, Johan Vos wrote:
>> Hi all,
>>
>> This pull request contains a backport of commit
>> [ba79e081](https://github.com/openjdk/jfx/commit/ba79e081547b7f15697bfaaac42ec2de1971935a)
>> from the [openjdk/jfx](https://git.openjdk.org/jfx) repository.
>>
>> The commit
On Tue, 5 Mar 2024 16:44:55 GMT, Johan Vos wrote:
> 8327177: macOS: wrong GlobalRef deleted in GlassMenu
This pull request has now been integrated.
Changeset: d70fa5f1
Author:Johan Vos
URL:
https://git.openjdk.org/jfx22u/commit/d70fa5f160c5a90f4c704ad514921d5421291bbf
Stats: 1 l
> Almost clean backport of JDK-8318386.
> The original patch contains a fix to gstaacparse.c which is not in jfx17u
> because it does not have JDK-8277309 (JDK-8277309)
Johan Vos has updated the pull request with a new target base due to a merge or
a rebase. The incremental webrev excludes the u
On Tue, 5 Mar 2024 16:44:55 GMT, Johan Vos wrote:
> 8327177: macOS: wrong GlobalRef deleted in GlassMenu
This is ready to integrate.
-
PR Comment: https://git.openjdk.org/jfx22u/pull/16#issuecomment-1983514644
> Hi all,
>
> This pull request contains a backport of commit
> [ba79e081](https://github.com/openjdk/jfx/commit/ba79e081547b7f15697bfaaac42ec2de1971935a)
> from the [openjdk/jfx](https://git.openjdk.org/jfx) repository.
>
> The commit being backported was authored by Hima Bindu Meda on 16 Jan
On Thu, 7 Mar 2024 13:17:00 GMT, Johan Vos wrote:
> 8282386: JavaFX media stubs rely on libav.org
This pull request has now been integrated.
Changeset: 9ac6fa52
Author:Johan Vos
URL:
https://git.openjdk.org/jfx17u/commit/9ac6fa5295af8e157c6d1ee8a75393731a426ee4
Stats: 21 lines i
8282386: JavaFX media stubs rely on libav.org
-
Commit messages:
- Backport 357cd8563bd6ca47afd28dd1481afbe2d2458827
Changes: https://git.openjdk.org/jfx17u/pull/183/files
Webrev: https://webrevs.openjdk.org/?repo=jfx17u&pr=183&range=00
Issue: https://bugs.openjdk.org/browse/JDK-
On Thu, 7 Mar 2024 12:43:17 GMT, Hima Bindu Meda wrote:
> Clean Backport
This pull request has now been integrated.
Changeset: 419bad3a
Author:Hima Bindu Meda
URL:
https://git.openjdk.org/jfx22u/commit/419bad3a4053abe215329a5228789f2c876ab287
Stats: 5 lines in 1 file changed: 4
Clean Backport
-
Commit messages:
- Backport 64af987576214fc5483520ce8131895be74a641d
Changes: https://git.openjdk.org/jfx22u/pull/18/files
Webrev: https://webrevs.openjdk.org/?repo=jfx22u&pr=18&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8326989
Stats: 5 lines in 1 fil
Hi all,
This pull request contains a backport of commit
[ba79e081](https://github.com/openjdk/jfx/commit/ba79e081547b7f15697bfaaac42ec2de1971935a)
from the [openjdk/jfx](https://git.openjdk.org/jfx) repository.
The commit being backported was authored by Hima Bindu Meda on 16 Jan 2024 and
was
> Fixed as described in the issue + added tests to check for this scenario with
> all Transform sub classes. Since the test scenario slightly exceeding the
> regular parametrized testing of `TransformOperationsTest` I decided to
> implement the tests in a separate class.
>
> I didn't manage to
On Tue, 5 Mar 2024 16:46:28 GMT, Johan Vos wrote:
> 8327177: macOS: wrong GlobalRef deleted in GlassMenu
This pull request has now been integrated.
Changeset: 98293abf
Author:Johan Vos
URL:
https://git.openjdk.org/jfx21u/commit/98293abf8e9aa5db28d776c0391b46d1bf0951af
Stats: 1 l
Almost clean backport of JDK-8318386.
The original patch contains a fix to gstaacparse.c which is not in jfx17u
because it does not have JDK-8277309 (JDK-8277309)
-
Commit messages:
- Backport 606878af275dbad551a10653c92a2deef61c10cd
Changes: https://git.openjdk.org/jfx17u/pull/181
Hi all,
This pull request contains a backport of commit
[ba79e081](https://github.com/openjdk/jfx/commit/ba79e081547b7f15697bfaaac42ec2de1971935a)
from the [openjdk/jfx](https://git.openjdk.org/jfx) repository.
The commit being backported was authored by Hima Bindu Meda on 16 Jan 2024 and
was
+1 from me. I think this is a good addition.
The biggest use case I see is that you can now easily write code to install a tooltip when the text is truncated.
Also since the property is created lazily, there is no downside for Labeled nodes that do not need this feature.
- Marius
Gesend
31 matches
Mail list logo
