Re: RFR: 8273743: KeyCharacterCombination for "+" does not work on US QWERTY keyboard layout

2024-04-10 Thread Martin Fox
On Tue, 20 Feb 2024 18:07:43 GMT, Martin Fox wrote: > On Linux getKeyCodeForChar does not consult the current keyboard layout. For > example, it assumes the “+” character is on KeyCode.PLUS even on layouts > which don’t generate KeyCode.PLUS. The result is that most > KeyCharacterCombinations

Re: RFR: 8319555: [TestBug] Utility for creating instruction window for manual tests [v7]

2024-04-10 Thread Alexander Matveev
On Wed, 10 Apr 2024 23:45:56 GMT, Andy Goryachev wrote: >> ## ManualTestWindow >> >> This facility provides the base class for manual tests which displays the >> test instructions, >> the UI under test, and the Pass/Fail buttons. >> >> Example: >> >> >> public class ManualTestExample extends

Re: RFR: 8319555: [TestBug] Utility for creating instruction window for manual tests [v6]

2024-04-10 Thread Andy Goryachev
On Wed, 10 Apr 2024 23:16:02 GMT, Andy Goryachev wrote: >> ## ManualTestWindow >> >> This facility provides the base class for manual tests which displays the >> test instructions, >> the UI under test, and the Pass/Fail buttons. >> >> Example: >> >> >> public class ManualTestExample extends

Re: RFR: 8319555: [TestBug] Utility for creating instruction window for manual tests [v7]

2024-04-10 Thread Andy Goryachev
> ## ManualTestWindow > > This facility provides the base class for manual tests which displays the > test instructions, > the UI under test, and the Pass/Fail buttons. > > Example: > > > public class ManualTestExample extends ManualTestWindow { > public ManualTestExample() { > sup

Re: RFR: 8328577: Toolbar's overflow button overlaps the items [v3]

2024-04-10 Thread Andy Goryachev
On Tue, 2 Apr 2024 12:58:27 GMT, eduardsdv wrote: >> This change fixes the calculation of which nodes go to the toolbar and which >> go to the overflow menu. >> It is now determined before the nodes are removed from the scene graph. >> This is important because the values returned by >> ``Node.

Re: RFR: 8319555: [TestBug] Utility for creating instruction window for manual tests [v6]

2024-04-10 Thread Alexander Matveev
On Wed, 10 Apr 2024 23:16:02 GMT, Andy Goryachev wrote: >> ## ManualTestWindow >> >> This facility provides the base class for manual tests which displays the >> test instructions, >> the UI under test, and the Pass/Fail buttons. >> >> Example: >> >> >> public class ManualTestExample extends

Re: RFR: 8319555: [TestBug] Utility for creating instruction window for manual tests [v6]

2024-04-10 Thread Andy Goryachev
> ## ManualTestWindow > > This facility provides the base class for manual tests which displays the > test instructions, > the UI under test, and the Pass/Fail buttons. > > Example: > > > public class ManualTestExample extends ManualTestWindow { > public ManualTestExample() { > sup

Re: RFR: 8319555: [TestBug] Utility for creating instruction window for manual tests [v5]

2024-04-10 Thread Andy Goryachev
> ## ManualTestWindow > > This facility provides the base class for manual tests which displays the > test instructions, > the UI under test, and the Pass/Fail buttons. > > Example: > > > public class ManualTestExample extends ManualTestWindow { > public ManualTestExample() { > sup

Re: RFR: 8319555: [TestBug] Utility for creating instruction window for manual tests [v4]

2024-04-10 Thread Andy Goryachev
On Mon, 8 Apr 2024 15:04:24 GMT, Andy Goryachev wrote: >> ## ManualTestWindow >> >> This facility provides the base class for manual tests which displays the >> test instructions, >> the UI under test, and the Pass/Fail buttons. >> >> Example: >> >> >> public class ManualTestExample extends

Re: RFR: 8092102: Labeled: truncated property [v8]

2024-04-10 Thread Andy Goryachev
On Wed, 10 Apr 2024 09:03:33 GMT, Karthik P K wrote: >> Andy Goryachev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> add exports > > modules/javafx.controls/src/main/java/com/sun/javafx/scene/control/LabeledHelper.java > line 38: > >

Re: RFR: 8218745: TableView: visual glitch at borders on horizontal scrolling

2024-04-10 Thread Andy Goryachev
On Sun, 10 Mar 2024 13:29:58 GMT, Marius Hanl wrote: > But there is obviously a bug on the low level NGNode side as well. Not sure > where to go from here. does it mean this PR is not ready, or do we have other issue(s)? Also, a CSR is needed for this PR to go forward. - PR Comme

Re: RFR: 8092102: Labeled: truncated property [v9]

2024-04-10 Thread Andy Goryachev
> Adds **Labeled.textTruncated** property which indicates when the text is > visually truncated (and the ellipsis string is inserted) in order to fit the > available width. > > The new property reacts to changes in the following properties: > - ellipsisString > - font > - height > - text > - wid

Re: RFR: 8218745: TableView: visual glitch at borders on horizontal scrolling

2024-04-10 Thread Marius Hanl
On Wed, 10 Jan 2024 19:21:16 GMT, Marius Hanl wrote: > This PR fixes the border glitch/gap as explained in both linked tickets. > > I noted that the `ScrollPane` control does not suffer from this problem, > although the code is mostly the same as in `VirtualFlow`. The `ScrollPane` > snaps the

Re: RFR: 8296387: [Tooltip, CSS] -fx-show-delay is only applied to the first tooltip that is shown before it is displayed [v3]

2024-04-10 Thread Marius Hanl
On Sat, 9 Mar 2024 10:27:21 GMT, Marius Hanl wrote: >> This PR fixes a long standing issue where the `Tooltip` will always wait one >> second until it appears the very first time, even if the >> `-fx-show-delay` was set to another value. >> >> The culprit is, that the `cssForced` flag is not i

Re: RFR: 8322251: [Linux] JavaFX is not displaying CJK on Ubuntu 23.10 and later

2024-04-10 Thread Phil Race
On Wed, 10 Apr 2024 19:09:52 GMT, Andy Goryachev wrote: >> The Linux font lookup code is rejecting CFF OpenType fonts. >> Since these are becoming common because of the Noto family this could soon >> be quite a problem. >> I expect this fix is a candidate for backporting. > > modules/javafx.grap

Re: RFR: 8322251: [Linux] JavaFX is not displaying CJK on Ubuntu 23.10 and later

2024-04-10 Thread Andy Goryachev
On Wed, 10 Apr 2024 19:01:57 GMT, Phil Race wrote: > The Linux font lookup code is rejecting CFF OpenType fonts. > Since these are becoming common because of the Noto family this could soon be > quite a problem. > I expect this fix is a candidate for backporting. modules/javafx.graphics/src/mai

RFR: 8322251: [Linux] JavaFX is not displaying CJK on Ubuntu 23.10 and later

2024-04-10 Thread Phil Race
The Linux font lookup code is rejecting CFF OpenType fonts. Since these are becoming common because of the Noto family this could soon be quite a problem. I expect this fix is a candidate for backporting. - Commit messages: - 8322251 Changes: https://git.openjdk.org/jfx/pull/1439/f

Re: RFR: 8092102: Labeled: truncated property [v8]

2024-04-10 Thread Karthik P K
On Thu, 28 Mar 2024 21:44:49 GMT, Andy Goryachev wrote: >> Adds **Labeled.textTruncated** property which indicates when the text is >> visually truncated (and the ellipsis string is inserted) in order to fit the >> available width. >> >> The new property reacts to changes in the following prop

Re: RFR: 8323511 Scrollbar Click jumps inconsistent amount of pixels [v2]

2024-04-10 Thread Johan Vos
On Mon, 15 Jan 2024 08:31:59 GMT, Florian Kirmaier wrote: >> As seen in the unit test of the PR, when we click on the area above/below >> the scrollbar the position jumps - but the jump is now not always consistent. >> In the current version on the last cell - the UI always jumps to the top. In

Re: RFR: 8242553: IntegerSpinner and DoubleSpinner do not wrap around values correctly in some cases [v2]

2024-04-10 Thread drmarmac
> This PR should fix the issue and cover all relevant cases with new tests. > > Note: This involves a small behavior change, as can be seen in > dblSpinner_testWrapAround_decrement_twoSteps() in SpinnerTest.java:749. With > this change the wraparound behavior is similar to that of the IntegerSpi

Re: RFR: 8242553: IntegerSpinner and DoubleSpinner do not wrap around values correctly in some cases

2024-04-10 Thread drmarmac
On Sun, 24 Mar 2024 15:11:16 GMT, drmarmac wrote: > This PR should fix the issue and cover all relevant cases with new tests. > > Note: This involves a small behavior change, as can be seen in > dblSpinner_testWrapAround_decrement_twoSteps() in SpinnerTest.java:749. With > this change the wrap

Re: Headless glass platform

2024-04-10 Thread Johan Vos
Hi Craig, Thanks for testing and for the feedback. Based on that feedback, I pushed a change so that the HeadlessApplication now responds properly to a `Platform.exit()` call (see https://github.com/openjdk/jfx-sandbox/commit/5c8bcb2ca1f7a72f34c3e53e209b818abf8f8504 ). My implementation does a gen