Re: RFR: 8330462: StringIndexOutOfBoundException when typing anything into TextField [v16]

On Tue, 23 Apr 2024 17:47:03 GMT, Oliver Kopp wrote: >> Fixes https://bugs.openjdk.org/browse/JDK-8330462. >> >> If the parameter `maxLength` is larger than `Integer.MAX_VALUE - start`, >> then an addition of `start` to it leads to a negative value. This is "fixed" >> by using `Math.max` compa

Re: RFR: 8330462: StringIndexOutOfBoundException when typing anything into TextField [v16]

On Tue, 23 Apr 2024 20:09:50 GMT, Andy Goryachev wrote: >> Oliver Kopp has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - Fix JavaDoc formatting >> - Discard changes to modules/javafx.graphics/src/test/addExports > > tests/system/src/tes

Re: RFR: 8330462: StringIndexOutOfBoundException when typing anything into TextField [v16]

On Tue, 23 Apr 2024 17:47:03 GMT, Oliver Kopp wrote: >> Fixes https://bugs.openjdk.org/browse/JDK-8330462. >> >> If the parameter `maxLength` is larger than `Integer.MAX_VALUE - start`, >> then an addition of `start` to it leads to a negative value. This is "fixed" >> by using `Math.max` compa

Re: RFR: 8314215: Trailing Spaces before Line Breaks Affect the Center Alignment of Text [v18]

On Tue, 23 Apr 2024 19:30:49 GMT, John Hendrikx wrote: >> There are a number of tickets open related to text rendering: >> >> https://bugs.openjdk.org/browse/JDK-8314215 >> >> https://bugs.openjdk.org/browse/JDK-8145496 >> >> https://bugs.openjdk.org/browse/JDK-8129014 >> >> They have in comm

Re: RFR: 8314215: Trailing Spaces before Line Breaks Affect the Center Alignment of Text [v18]

> There are a number of tickets open related to text rendering: > > https://bugs.openjdk.org/browse/JDK-8314215 > > https://bugs.openjdk.org/browse/JDK-8145496 > > https://bugs.openjdk.org/browse/JDK-8129014 > > They have in common that wrapped text is taking the trailing spaces on each > wrap

Re: RFR: 8314215: Trailing Spaces before Line Breaks Affect the Center Alignment of Text [v17]

On Tue, 23 Apr 2024 19:20:22 GMT, John Hendrikx wrote: >> tests/system/src/test/java/test/com/sun/javafx/text/TextLayoutTest.java line >> 453: >> >>> 451: TextLayoutTest::assumeMac, >>> 452: "The quick brown लोमड़ी jumps over the lazy कुत्ता", >>> 453: 160.0f

Re: RFR: 8314215: Trailing Spaces before Line Breaks Affect the Center Alignment of Text [v17]

On Tue, 23 Apr 2024 17:40:21 GMT, Andy Goryachev wrote: >> John Hendrikx has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fix mac test values > > tests/system/src/test/java/test/com/sun/javafx/text/TextLayoutTest.java line > 453: > >> 4

Re: RFR: 8314215: Trailing Spaces before Line Breaks Affect the Center Alignment of Text [v17]

On Tue, 23 Apr 2024 13:41:55 GMT, John Hendrikx wrote: >> There are a number of tickets open related to text rendering: >> >> https://bugs.openjdk.org/browse/JDK-8314215 >> >> https://bugs.openjdk.org/browse/JDK-8145496 >> >> https://bugs.openjdk.org/browse/JDK-8129014 >> >> They have in comm

Re: RFR: 8314215: Trailing Spaces before Line Breaks Affect the Center Alignment of Text [v17]

On Tue, 23 Apr 2024 17:30:39 GMT, Andy Goryachev wrote: >> John Hendrikx has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fix mac test values > > tests/system/src/test/java/test/com/sun/javafx/text/TextLayoutTest.java line > 430: > >> 4

Re: RFR: 8330462: StringIndexOutOfBoundException when typing anything into TextField [v15]

On Tue, 23 Apr 2024 17:42:03 GMT, Oliver Kopp wrote: >> Oliver Kopp has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Add missing exports > > tests/system/src/test/java/test/com/sun/glass/ui/win/WinTextRangeProviderTest.java > line 48: >

Re: RFR: 8314215: Trailing Spaces before Line Breaks Affect the Center Alignment of Text [v17]

On Tue, 23 Apr 2024 13:41:55 GMT, John Hendrikx wrote: >> There are a number of tickets open related to text rendering: >> >> https://bugs.openjdk.org/browse/JDK-8314215 >> >> https://bugs.openjdk.org/browse/JDK-8145496 >> >> https://bugs.openjdk.org/browse/JDK-8129014 >> >> They have in comm

Re: RFR: 8314215: Trailing Spaces before Line Breaks Affect the Center Alignment of Text [v12]

On Fri, 9 Feb 2024 21:34:33 GMT, John Hendrikx wrote: >> tests/system/src/test/java/test/com/sun/javafx/text/TextLayoutTest.java line >> 2: >> >>> 1: /* >>> 2: * Copyright (c) 2012, 2023, Oracle and/or its affiliates. All rights >>> reserved. >> >> weird, github shows this file as new, but i

Re: RFR: 8330462: StringIndexOutOfBoundException when typing anything into TextField [v7]

On Fri, 19 Apr 2024 17:33:39 GMT, Andy Goryachev wrote: >> I am new to testing in the JFX project. It seems that `test.` is required as >> package prefix. Thus, I did not use the approach of package-private methods >> and classes, but needed to make the class and the tested method public. >> >

Re: RFR: 8330462: StringIndexOutOfBoundException when typing anything into TextField [v15]

On Tue, 23 Apr 2024 12:17:55 GMT, Oliver Kopp wrote: >> Fixes https://bugs.openjdk.org/browse/JDK-8330462. >> >> If the parameter `maxLength` is larger than `Integer.MAX_VALUE - start`, >> then an addition of `start` to it leads to a negative value. This is "fixed" >> by using `Math.max` compa

Re: RFR: 8330462: StringIndexOutOfBoundException when typing anything into TextField [v16]

> Fixes https://bugs.openjdk.org/browse/JDK-8330462. > > If the parameter `maxLength` is larger than `Integer.MAX_VALUE - start`, then > an addition of `start` to it leads to a negative value. This is "fixed" by > using `Math.max` comparing the `maxLength` and `maxLength + start`. Oliver Kopp h

Re: RFR: 8330462: StringIndexOutOfBoundException when typing anything into TextField [v15]

On Tue, 23 Apr 2024 12:17:55 GMT, Oliver Kopp wrote: >> Fixes https://bugs.openjdk.org/browse/JDK-8330462. >> >> If the parameter `maxLength` is larger than `Integer.MAX_VALUE - start`, >> then an addition of `start` to it leads to a negative value. This is "fixed" >> by using `Math.max` compa

Re: RFR: 8314215: Trailing Spaces before Line Breaks Affect the Center Alignment of Text [v15]

On Tue, 23 Apr 2024 12:40:57 GMT, Karthik P K wrote: > Here is the result of TextLayoutTest in MacOS M1 system. Thanks very much, I've updated the values now, so no tests should fail anymore on Mac. > Following are the skipped tests: > > ``` > TextLayoutTest > caseTest(Case) > [10] SOFT_WRAP

Re: RFR: 8314215: Trailing Spaces before Line Breaks Affect the Center Alignment of Text [v17]

> There are a number of tickets open related to text rendering: > > https://bugs.openjdk.org/browse/JDK-8314215 > > https://bugs.openjdk.org/browse/JDK-8145496 > > https://bugs.openjdk.org/browse/JDK-8129014 > > They have in common that wrapped text is taking the trailing spaces on each > wrap

Re: RFR: 8314215: Trailing Spaces before Line Breaks Affect the Center Alignment of Text [v15]

On Mon, 12 Feb 2024 10:00:57 GMT, Karthik P K wrote: >> John Hendrikx has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Change test to use the more common Arial font and add assumptions > > I ran the tests in my Mac system with macOS 14.3

Re: RFR: 8329820: [Linux] Prefer EGL over GLX [v3]

On Fri, 19 Apr 2024 14:42:23 GMT, Thiago Milczarek Sayao wrote: >> Wayland implementation will require EGL. >> >> EGL works with Xorg as well. The idea is to be EGL first and if it fails, >> fallback to GLX. A force flag `prism.es2.forceGLX=true` is available. >> >> >> See: >> [Switching th

Re: RFR: 8330462: StringIndexOutOfBoundException when typing anything into TextField [v15]

> Fixes https://bugs.openjdk.org/browse/JDK-8330462. > > If the parameter `maxLength` is larger than `Integer.MAX_VALUE - start`, then > an addition of `start` to it leads to a negative value. This is "fixed" by > using `Math.max` comparing the `maxLength` and `maxLength + start`. Oliver Kopp h

Re: Wayland

I'm doing some work here: https://github.com/tsayao/glass-wayland So far it's been a good experience to use FFM / jextract. The idea is to plug it as a glass wayland backend when it's good enough. Em seg., 22 de abr. de 2024 às 16:16, Nir Lisker escreveu: > Not sure it helps with warmup, but

Integrated: 8328577: Toolbar's overflow button overlaps the items

On Thu, 28 Mar 2024 11:31:14 GMT, eduardsdv wrote: > This change fixes the calculation of which nodes go to the toolbar and which > go to the overflow menu. > It is now determined before the nodes are removed from the scene graph. > This is important because the values returned by > ``Node.pref

Re: RFR: 8330462: StringIndexOutOfBoundException when typing anything into TextField [v14]

> Fixes https://bugs.openjdk.org/browse/JDK-8330462. > > If the parameter `maxLength` is larger than `Integer.MAX_VALUE - start`, then > an addition of `start` to it leads to a negative value. This is "fixed" by > using `Math.max` comparing the `maxLength` and `maxLength + start`. Oliver Kopp h

RFR: 8320563: Remove D3D9 code paths in favor of D3D9Ex

JFX minimum requirements guarantee 9Ex availability, so old non-Ex paths are no longer needed. In multiple parts (ex. Mesh, Graphics, etc.) where the Device is acquired I changed the type to explicitly use `IDirect3DDevice9Ex`. Technically it doesn't matter much (`IDirect3DDevice9Ex` inherits `

Re: RFR: 8320563: Remove D3D9 code paths in favor of D3D9Ex

On Tue, 23 Apr 2024 10:33:58 GMT, Lukasz Kostyra wrote: > JFX minimum requirements guarantee 9Ex availability, so old non-Ex paths are > no longer needed. > > In multiple parts (ex. Mesh, Graphics, etc.) where the Device is acquired I > changed the type to explicitly use `IDirect3DDevice9Ex`.