On Thu, 13 Jun 2024 20:07:32 GMT, Johan Vos wrote:
>> A listener was added but never removed.
>> This patch removes the listener when the menu it links to is cleared. Fix
>> for https://bugs.openjdk.org/browse/JDK-8319779
>
> Johan Vos has updated the pull request incrementally with two
On Wed, 12 Jun 2024 20:03:24 GMT, Kevin Rushforth wrote:
> This PR updates `build.gradle` to define javac lint options for three
> different types of java compilation tasks: sdk classes, test classes
> (including shims), and tool classes (including JSLC). The defaults for these
> three groups
On Mon, 20 May 2024 23:37:22 GMT, Andy Goryachev wrote:
>> Adding alt-ctrl-LEFT/RIGHT/UP/DOWN (option-command-LEFT/RIGHT/UP/DOWN) key
>> bindings to
>>
>> - ListView
>> - TreeView
>> - TableView
>> - TreeTableView
>>
>> to support keyboard-only horizontal and vertical scrolling. The main
On Fri, 17 May 2024 15:36:27 GMT, Andy Goryachev wrote:
>> This change replaces Character.isLetterOrDigit(char) which fails with
>> surrogate characters with Character.isLetterOrDigit(int).
>
> Andy Goryachev has updated the pull request with a new target base due to a
> merge or a rebase.
On Fri, 19 Apr 2024 20:36:42 GMT, Andy Goryachev wrote:
>> This change replaces Character.isLetterOrDigit(char) which fails with
>> surrogate characters with Character.isLetterOrDigit(int).
>
> Andy Goryachev has updated the pull request with a new target base due to a
> merge or a rebase.
On Thu, 16 May 2024 18:30:17 GMT, Andy Goryachev wrote:
> Root cause: premature 'return' from initialization code leaves the hover
> square visible, even when it should be hidden, as the case is when the color
> value is not present in the palette.
>
> - added unit tests
Fix looks good, I
On Thu, 16 May 2024 14:54:47 GMT, Andy Goryachev wrote:
>> modules/javafx.graphics/src/main/java/javafx/scene/layout/Region.java line
>> 1212:
>>
>>> 1210: *
>>> 1211: * Defaults to the USE_COMPUTED_SIZE flag, which
>>> means that
>>> 1212: * {@link #prefHeight(forWidth)} will
On Thu, 16 May 2024 14:58:29 GMT, Andy Goryachev wrote:
>> The javadoc for `Region.getPrefHeight() / getPrefWidth()` incorrectly refers
>> to `getPrefHeight(forWidth) / getPrefWidth(forHeight)`
>>
>> should be
>>
>> `prefHeight(forWidth) / prefWidth(forHeight)`
>>
>> - same issue is also
On Wed, 15 May 2024 23:01:30 GMT, Andy Goryachev wrote:
> The javadoc for `Region.getPrefHeight() / getPrefWidth()` incorrectly refers
> to `getPrefHeight(forWidth) / getPrefWidth(forHeight)`
>
> should be
>
> `prefHeight(forWidth) / prefWidth(forHeight)`
>
> - also converted these
On Sat, 6 Apr 2024 17:34:06 GMT, Thiago Milczarek Sayao
wrote:
> Simple fix to only request `_NET_FRAME_EXTENTS` if window has decoration.
>
> It seems i3 replies with decorated sizes, even if window is not decorated.
>
> Won't hurt other WMs.
LGTM, tested with and without fix, with and
On Sat, 6 Apr 2024 17:34:06 GMT, Thiago Milczarek Sayao
wrote:
> Simple fix to only request `_NET_FRAME_EXTENTS` if window has decoration.
>
> It seems i3 replies with decorated sizes, even if window is not decorated.
>
> Won't hurt other WMs.
I could verify that this change fixes the issue
On Mon, 6 May 2024 23:14:11 GMT, Andy Goryachev wrote:
>> Adding alt-ctrl-LEFT/RIGHT/UP/DOWN (option-command-LEFT/RIGHT/UP/DOWN) key
>> bindings to
>>
>> - ListView
>> - TreeView
>> - TableView
>> - TreeTableView
>>
>> to support keyboard-only horizontal and vertical scrolling. The main
On Mon, 13 May 2024 09:36:39 GMT, Ambarish Rapte wrote:
> The backport is almost clean.
> While cherry picking the mainline commit, a minor merge conflict was shown in
> a the file `tests/system/src/test/.classpath` : The mainline file has a few
> additional exports compared to 22
On Mon, 13 May 2024 16:42:05 GMT, Kevin Rushforth wrote:
>> forgot to mention the diff is just a different ordering.
>
> Ah, I see. In that case, reordering to match mainline seems good.
May be I am missing something here,
I verified the order, it is same as mainline jfx. (jfx has 3 more, that
The backport is almost clean.
While cherry picking the mainline commit, a minor merge conflict was shown in a
the file `tests/system/src/test/.classpath` : The mainline file has a few
additional exports compared to 22u.
Test passes on windows.
-
Commit messages:
- 8330462:
On Mon, 6 May 2024 23:14:11 GMT, Andy Goryachev wrote:
>> Adding alt-ctrl-LEFT/RIGHT/UP/DOWN (option-command-LEFT/RIGHT/UP/DOWN) key
>> bindings to
>>
>> - ListView
>> - TreeView
>> - TableView
>> - TreeTableView
>>
>> to support keyboard-only horizontal and vertical scrolling. The main
On Wed, 8 May 2024 22:02:21 GMT, Alexander Matveev wrote:
>> - Added support for #EXT-X-MEDIA tag to HTTP Live Streaming.
>> - Following audio renditions via #EXT-X-MEDIA tag will be supported (see CSR
>> for more details):
>> - MP2T streams with one H.264/AVC video track and elementary AAC
On Sat, 13 Apr 2024 01:36:01 GMT, Alexander Matveev
wrote:
> - When video fails to render AVFoundation outputs frame in
> `kCVPixelFormatType_420YpCbCr8BiPlanarVideoRange` format which is not
> supported. We do force format change after that to
> `kCVPixelFormatType_422YpCbCr8`, but
On Fri, 26 Apr 2024 23:36:26 GMT, Alexander Matveev
wrote:
>> - Added support for #EXT-X-MEDIA tag to HTTP Live Streaming.
>> - Following audio renditions via #EXT-X-MEDIA tag will be supported (see CSR
>> for more details):
>> - MP2T streams with one H.264/AVC video track and elementary AAC
On Tue, 7 May 2024 20:39:13 GMT, Oliver Kopp wrote:
>> Fixes https://bugs.openjdk.org/browse/JDK-8330462.
>>
>> If the parameter `maxLength` is larger than `Integer.MAX_VALUE - start`,
>> then an addition of `start` to it leads to a negative value. This is "fixed"
>> by using `Math.max`
On Thu, 2 May 2024 23:35:12 GMT, Oliver Kopp wrote:
>> Fixes https://bugs.openjdk.org/browse/JDK-8330462.
>>
>> If the parameter `maxLength` is larger than `Integer.MAX_VALUE - start`,
>> then an addition of `start` to it leads to a negative value. This is "fixed"
>> by using `Math.max`
On Wed, 10 Apr 2024 21:25:10 GMT, Andy Goryachev wrote:
>> Adds **Labeled.textTruncated** property which indicates when the text is
>> visually truncated (and the ellipsis string is inserted) in order to fit the
>> available width.
>>
>> The new property reacts to changes in the following
On Wed, 1 May 2024 04:46:29 GMT, Oliver Kopp wrote:
>> Fixes https://bugs.openjdk.org/browse/JDK-8330462.
>>
>> If the parameter `maxLength` is larger than `Integer.MAX_VALUE - start`,
>> then an addition of `start` to it leads to a negative value. This is "fixed"
>> by using `Math.max`
On Wed, 10 Apr 2024 21:25:10 GMT, Andy Goryachev wrote:
>> Adds **Labeled.textTruncated** property which indicates when the text is
>> visually truncated (and the ellipsis string is inserted) in order to fit the
>> available width.
>>
>> The new property reacts to changes in the following
On Mon, 29 Apr 2024 15:47:54 GMT, Oliver Kopp wrote:
>> modules/javafx.graphics/src/main/java/com/sun/glass/ui/win/WinTextRangeProvider.java
>> line 104:
>>
>>> 102: int length = text.length();
>>> 103: start = Utils.clamp(0, start, length);
>>> 104: end =
On Fri, 26 Apr 2024 22:58:37 GMT, Oliver Kopp wrote:
>> Fixes https://bugs.openjdk.org/browse/JDK-8330462.
>>
>> If the parameter `maxLength` is larger than `Integer.MAX_VALUE - start`,
>> then an addition of `start` to it leads to a negative value. This is "fixed"
>> by using `Math.max`
On Fri, 26 Apr 2024 22:58:37 GMT, Oliver Kopp wrote:
>> Fixes https://bugs.openjdk.org/browse/JDK-8330462.
>>
>> If the parameter `maxLength` is larger than `Integer.MAX_VALUE - start`,
>> then an addition of `start` to it leads to a negative value. This is "fixed"
>> by using `Math.max`
On Thu, 25 Apr 2024 21:41:14 GMT, Oliver Kopp wrote:
>> Fixes https://bugs.openjdk.org/browse/JDK-8330462.
>>
>> If the parameter `maxLength` is larger than `Integer.MAX_VALUE - start`,
>> then an addition of `start` to it leads to a negative value. This is "fixed"
>> by using `Math.max`
On Wed, 24 Apr 2024 12:54:01 GMT, Oliver Kopp wrote:
>> Fixes https://bugs.openjdk.org/browse/JDK-8330462.
>>
>> If the parameter `maxLength` is larger than `Integer.MAX_VALUE - start`,
>> then an addition of `start` to it leads to a negative value. This is "fixed"
>> by using `Math.max`
On Wed, 24 Apr 2024 12:54:01 GMT, Oliver Kopp wrote:
>> Fixes https://bugs.openjdk.org/browse/JDK-8330462.
>>
>> If the parameter `maxLength` is larger than `Integer.MAX_VALUE - start`,
>> then an addition of `start` to it leads to a negative value. This is "fixed"
>> by using `Math.max`
On Thu, 4 Apr 2024 21:55:11 GMT, Alexander Zuev wrote:
> Added missing checks;
> Added a manual regression test;
Marked as reviewed by arapte (Reviewer).
-
PR Review: https://git.openjdk.org/jfx/pull/1436#pullrequestreview-1983111622
On Tue, 12 Mar 2024 13:44:48 GMT, Kevin Rushforth wrote:
> Bump version number to 22.0.2
Marked as reviewed by arapte (Reviewer).
-
PR Review: https://git.openjdk.org/jfx22u/pull/19#pullrequestreview-1931624966
On Sun, 3 Mar 2024 22:29:02 GMT, Nir Lisker wrote:
> Update for the 3D lighting test tool as described in the JBS issue.
An observation out of scope of this PR.
The effect of lighting on mesh vs a box is quite different.
Notice the screenshot, left side is a Box and right side is Mesh, both
On Sun, 3 Mar 2024 22:29:02 GMT, Nir Lisker wrote:
> Update for the 3D lighting test tool as described in the JBS issue.
providing few more comments
tests/performance/3DLighting/src/main/java/lighting3D/Benchmark.java line 49:
> 47: stopGraphic.setBoundsType(TextBoundsType.VISUAL);
>
On Sun, 3 Mar 2024 22:29:02 GMT, Nir Lisker wrote:
> Update for the 3D lighting test tool as described in the JBS issue.
Couple quick comments:
- Executing the LightingSample manually fails with an exception
Caused by: java.lang.NullPointerException: Input stream must not be null
at
On Fri, 1 Mar 2024 15:53:21 GMT, Andy Goryachev wrote:
>> This change brings the number of javadoc warnings back to 91 (to be fixed in
>> [JDK-8270996](https://bugs.openjdk.org/browse/JDK-8270996))
>>
>> - adds missing information in `@param` tags
>> - adds
On Fri, 1 Mar 2024 00:22:05 GMT, Andy Goryachev wrote:
>> This change brings the number of javadoc warnings back to 91 (to be fixed in
>> [JDK-8270996](https://bugs.openjdk.org/browse/JDK-8270996))
>>
>> - adds missing information in `@param` tags
>> - adds
On Thu, 29 Feb 2024 09:28:04 GMT, Jayathirth D V wrote:
>> IJG has released latest version of libjpeg 9f and we need to update our
>> version also match 9f changes.
>> IJG reference : https://www.ijg.org/
>>
>> With updated changes both headless and headful tests are green on all
>>
On Wed, 28 Feb 2024 05:19:06 GMT, Jayathirth D V wrote:
>> IJG has released latest version of libjpeg 9f and we need to update our
>> version also match 9f changes.
>> IJG reference : https://www.ijg.org/
>>
>> With updated changes both headless and headful tests are green on all
>>
On Wed, 28 Feb 2024 18:48:21 GMT, Nir Lisker wrote:
>> Overhaul to the `PhongMaterial` documentation (and a bit to its superclass
>> `Material`). Except for the introduction, I divided the documentation into 3
>> sections: qualitative explanation, mathematical model (I wouldn't think it
>>
On Mon, 26 Feb 2024 16:41:05 GMT, Nir Lisker wrote:
>> Overhaul to the `PhongMaterial` documentation (and a bit to its superclass
>> `Material`). Except for the introduction, I divided the documentation into 3
>> sections: qualitative explanation, mathematical model (I wouldn't think it
>>
On Mon, 26 Feb 2024 16:41:05 GMT, Nir Lisker wrote:
>> Overhaul to the `PhongMaterial` documentation (and a bit to its superclass
>> `Material`). Except for the introduction, I divided the documentation into 3
>> sections: qualitative explanation, mathematical model (I wouldn't think it
>>
On Tue, 13 Feb 2024 12:29:49 GMT, Ambarish Rapte wrote:
> This is accessibility specific fix.
>
> **Issue**: When a ListView is shown for first time then accessibility focus
> rectangle is not drawn around the focused ListIem
>
> **Cause:**
>The ListView takes a
On Thu, 15 Feb 2024 21:59:18 GMT, Alexander Zuev wrote:
>> Ambarish Rapte has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> review corrections-1
>
> modules/javafx.controls/src/main/java/javafx/scene/co
On Thu, 15 Feb 2024 09:57:17 GMT, Marius Hanl wrote:
>> Ambarish Rapte has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> review corrections-1
>
> modules/javafx.controls/src/main/java/javafx/scene/con
On Thu, 15 Feb 2024 00:31:23 GMT, Kevin Rushforth wrote:
> Clean backport of a docs-only fix to jfx22.
Marked as reviewed by arapte (Reviewer).
-
PR Review: https://git.openjdk.org/jfx/pull/1369#pullrequestreview-1881602522
On Wed, 14 Feb 2024 15:19:47 GMT, Kevin Rushforth wrote:
> Simple fix to update the pointer to the JDK docs to JDK 21 (matching the
> current boot JDK). The only impact of this change is that hyperlinks in the
> generated API docs will link to the online JDK 21 docs. As this is a
> docs-only
On Tue, 13 Feb 2024 21:15:16 GMT, Kevin Rushforth wrote:
> The fix looks good to me, and my initial testing shows that it works as
> expected. I left a few suggestions on minor wording changes inline. I'll
> reapprove if you make the changes.
Thank you Kevin,
Please have a re-look, I made the
9374)
> Move through the TextFields and press `Alt+down`, observe that focus
> rectangle is drawn correctly.
> Once the ListView is showing Press and hold `Up/Down` or `Ctrl +
> Up/Down` keys, observe that focus rectangle is always drawn.
Ambarish Rapte has updated the pull r
This is accessibility specific fix.
**Issue**: When a ListView is shown for first time then accessibility focus
rectangle is not drawn around the focused ListIem
**Cause:**
The ListView takes a little time to create it's skin(ListViewSkin) and the
skins for ListItems(ListCellSkin)
If
On Wed, 7 Feb 2024 21:41:10 GMT, Andy Goryachev wrote:
>> Requesting content layout when font changes.
>>
>> This change makes the visual impact of
>> [JDK-8314683](https://bugs.openjdk.org/browse/JDK-8314683) more visible, so
>> perhaps both bugs should be fixed at the same time.
>
> Andy
On Mon, 21 Aug 2023 21:44:12 GMT, Andy Goryachev wrote:
> Requesting content layout when font changes.
>
> This change makes the visual impact of
> [JDK-8314683](https://bugs.openjdk.org/browse/JDK-8314683) more visible, so
> perhaps both bugs should be fixed at the same time.
With this
On Mon, 21 Aug 2023 21:44:12 GMT, Andy Goryachev wrote:
> Requesting content layout when font changes.
>
> This change makes the visual impact of
> [JDK-8314683](https://bugs.openjdk.org/browse/JDK-8314683) more visible, so
> perhaps both bugs should be fixed at the same time.
On Tue, 6 Feb 2024 13:49:13 GMT, Laurent Bourgès wrote:
>> Fixed scale=0 in DMarlinPrismUtils + added new test Scale0Test.java
>
> Laurent Bourgès has updated the pull request incrementally with one
> additional commit since the last revision:
>
> minor cleanup to simplify test and fixed
On Tue, 6 Feb 2024 00:06:58 GMT, Laurent Bourgès wrote:
>> Fixed scale=0 in DMarlinPrismUtils + added new test Scale0Test.java
>
> Laurent Bourgès has updated the pull request incrementally with one
> additional commit since the last revision:
>
> improved rendez-vous to collect stderr
On Fri, 2 Feb 2024 13:14:26 GMT, Laurent Bourgès wrote:
>> Fixed scale=0 in DMarlinPrismUtils + added new test Scale0Test.java
>
> Laurent Bourgès has updated the pull request incrementally with one
> additional commit since the last revision:
>
> fixed tests thanks to + copyright years
On Thu, 11 Jan 2024 20:13:09 GMT, Marius Hanl wrote:
> For some reason the `skinProperty` did not allow to set a new skin when it is
> the same class as the previous one.
> This leads to multiple issues:
> 1. When creating a new skin (same class as previous), the skin will likely
> install
On Mon, 29 Jan 2024 21:29:31 GMT, Laurent Bourgès wrote:
>> Fixed scale=0 in DMarlinPrismUtils + added new test Scale0Test.java
>
> Laurent Bourgès has updated the pull request incrementally with one
> additional commit since the last revision:
>
> fixed copyright years of modified files +
On Mon, 29 Jan 2024 09:44:04 GMT, Karthik P K wrote:
>> Laurent Bourgès has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> fixed test package
>
> modules/javafx.graphics/src/main/java/com/sun/marlin/DPathConsumer2D.java
> line 2:
>
>> 1:
On Mon, 29 Jan 2024 21:29:31 GMT, Laurent Bourgès wrote:
>> Fixed scale=0 in DMarlinPrismUtils + added new test Scale0Test.java
>
> Laurent Bourgès has updated the pull request incrementally with one
> additional commit since the last revision:
>
> fixed copyright years of modified files +
On Wed, 17 Jan 2024 12:57:22 GMT, Kevin Rushforth wrote:
>> As noted in the JBS bug, this is a follow-on to
>> [JDK-8196011](https://bugs.openjdk.org/browse/JDK-8196011) that I discovered
>> while testing the fix for
>> [JDK-8221261](https://bugs.openjdk.org/browse/JDK-8221261) (a deadlock in
On Mon, 22 Jan 2024 13:45:35 GMT, Ambarish Rapte wrote:
> JDK 21.0.2 is now released : https://jdk.java.net/21/
> Did a full CI build including Webkit and executed all headful tests.
This pull request has now been integrated.
Changeset: 9e7e8e1d
Author:Ambarish Rapte
URL:
On Tue, 23 Jan 2024 03:13:11 GMT, Alexander Matveev
wrote:
> This is regression from JDK-8262365. JDK-8262365 introduced support for
> hardware pause for audio device. For some reason we will skip ~500 ms of
> audio data after such pause. It is not noticeable for large audio files, but
> for
JDK 21.0.2 is now released : https://jdk.java.net/21/
Did a full CI build including Webkit and executed all headful tests.
-
Commit messages:
- boot jdk 21.0.2
Changes: https://git.openjdk.org/jfx/pull/1345/files
Webrev: https://webrevs.openjdk.org/?repo=jfx=1345=00
Issue:
On Thu, 11 Jan 2024 23:11:12 GMT, Kevin Rushforth wrote:
> Updates for the beginning of the 22.0.1 release.
Marked as reviewed by arapte (Reviewer).
-
PR Review: https://git.openjdk.org/jfx22u/pull/1#pullrequestreview-1817662768
On Fri, 5 Jan 2024 01:22:59 GMT, Martin Fox wrote:
>> When reporting input method candidate position the code in
>> GlassViewEventHandler is not applying the platform scale factors. This is
>> causing incorrect IM positions to be reported to glass on hi-dpi monitors.
>>
>> This PR a no-op on
On Mon, 8 Jan 2024 21:24:43 GMT, Kevin Rushforth wrote:
> Bump the version number of JavaFX to 23. I will integrate this to master as
> part of forking the jfx22 stabilization branch, which is scheduled for
> Thursday, January 11, 2024 at 16:00 UTC.
Marked as reviewed by arapte (Reviewer).
On Thu, 4 Jan 2024 15:31:12 GMT, Ambarish Rapte wrote:
> Update the copyright year in files modified in year 2023.
This pull request has now been integrated.
Changeset: bad94a6c
Author: Ambarish Rapte
URL:
https://git.openjdk.org/jfx/commit/bad94a6c3551a2f299d387aec0ed597238a3c
Update the copyright year in files modified in year 2023.
-
Commit messages:
- copyright year 2023
Changes: https://git.openjdk.org/jfx/pull/1317/files
Webrev: https://webrevs.openjdk.org/?repo=jfx=1317=00
Issue: https://bugs.openjdk.org/browse/JDK-8322953
Stats: 27 lines in
On Wed, 3 Jan 2024 18:39:58 GMT, Kevin Rushforth wrote:
> This PR updates the version of SWT that we use we use when building and
> testing the `javafx.swt` modules to 4.30.
>
> NOTE: we do not distribute SWT, but only use it during build and (manual)
> test.
>
> We currently use SWT 4.6. In
On Mon, 11 Dec 2023 13:10:55 GMT, Kevin Rushforth wrote:
> Until JDK-8321624 and JDK-8321625 are fixed, mark the following two tests as
> unstable on Linux, meaning they will not be run as part of our nightly
> headful test runs.
>
> DualWindowTest -
On Mon, 20 Nov 2023 08:00:58 GMT, Johan Vos wrote:
>> A listener was added but never removed.
>> This patch removes the listener when the menu it links to is cleared. Fix
>> for https://bugs.openjdk.org/browse/JDK-8319779
>
> Johan Vos has updated the pull request incrementally with one
On Fri, 8 Dec 2023 00:53:56 GMT, Ambarish Rapte wrote:
> Gradle 8.5.0 released on Nov 29, 2023, supports JDK 21.
> We need to update Gradle to 8.5 in order to update the boot JDK.
> There are not API level changes in Gradle that we need to work on, hence the
> change is only Gr
Gradle 8.5.0 released on Nov 29, 2023, supports JDK 21.
We need to update Gradle to 8.5 in order to update the boot JDK.
There are not API level changes in Gradle that we need to work on, hence the
change is only Gradle version update.
Also, merging the PR with boot jdk update to 21.0.1 b12
On Mon, 20 Nov 2023 05:37:38 GMT, Ambarish Rapte wrote:
> Currently we use the value of spinner as it's `UIA_NamePropertyId` when a11y
> client application requests for it.
> Ideally we should use the text set by `Node.setAccessibleText()` as the
> `UIA_NamePropertyId`.
> For
On Mon, 4 Dec 2023 06:39:47 GMT, Ambarish Rapte wrote:
> Update Copyright year in files modified in year 2023.
This pull request has now been integrated.
Changeset: a993b200
Author: Ambarish Rapte
URL:
https://git.openjdk.org/jfx21u/commit/a993b20052ef561bd3b1958b1bd20f99ca562
Update Copyright year in files modified in year 2023.
-
Commit messages:
- backport 8318714
Changes: https://git.openjdk.org/jfx21u/pull/38/files
Webrev: https://webrevs.openjdk.org/?repo=jfx21u=38=00
Issue: https://bugs.openjdk.org/browse/JDK-8318714
Stats: 44 lines in 44
On Fri, 1 Dec 2023 23:34:12 GMT, Kevin Rushforth wrote:
>> Ambarish Rapte has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Mac a11y change for VALUE_STRING attribute for Spinner
>
> modules/javafx.graphics/
On Fri, 1 Dec 2023 10:57:43 GMT, Ambarish Rapte wrote:
> A clean backport to jfx21u, to update copyright year in doc files.
This pull request has now been integrated.
Changeset: d7b5c1bf
Author: Ambarish Rapte
URL:
https://git.openjdk.org/jfx21u/com
A clean backport to jfx21u, to update copyright year in doc files.
-
Commit messages:
- update cpr-year in docs to 2024
Changes: https://git.openjdk.org/jfx21u/pull/36/files
Webrev: https://webrevs.openjdk.org/?repo=jfx21u=36=00
Issue: https://bugs.openjdk.org/browse/JDK-8318708
On Fri, 10 Nov 2023 23:39:21 GMT, Nir Lisker wrote:
>> Moves the filter setting of the samplers from the device parameters
>> configuration to the use-site, allowing for dynamic changes in the sampler.
>> This PR does internal plumbing work only to bring it close to the ES2
>> pipeline. A
On Wed, 15 Nov 2023 11:39:30 GMT, Lukasz Kostyra wrote:
>> 1. Not when it will be promoted to public API. Adding record components
>> breaks backwards compatibility, so making this a record will not allow
>> adding more configuration later on. What might be possible is making it an
>>
On Mon, 27 Nov 2023 19:57:30 GMT, Thorsten Fischer wrote:
>> I have put this in D3DContext.java (as per customer suggestion). Just
>> wondering if I should just reinitialize directly and not wait loop: in
>> testLostStateAndReset in D3DContext.java (D3DERR_DEVICEREMOVED is handled
>> further
On Wed, 22 Nov 2023 17:05:36 GMT, Ambarish Rapte wrote:
>> Currently we use the value of spinner as it's `UIA_NamePropertyId` when a11y
>> client application requests for it.
>> Ideally we should use the text set by `Node.setAccessibleText()` as the
>> `UIA_NameP
On Wed, 15 Nov 2023 22:00:13 GMT, Alexander Zuev wrote:
>> Create implementation for Slider and Stepper accessibility protocols.
>> Fix mapping.
>> Fix performAction parameter type in declaration.
>
> Alexander Zuev has updated the pull request incrementally with one additional
> commit since
value of Spinner and then if
> editable or not
> - 2. In application "Accessibility Insights for Windows", you can see the
> text set by `setAccessibleText()` for Spinner as the Name property and the
> Spinner's value as value property
Ambarish Rapte has updated the pull requ
On Wed, 15 Nov 2023 22:00:13 GMT, Alexander Zuev wrote:
>> Create implementation for Slider and Stepper accessibility protocols.
>> Fix mapping.
>> Fix performAction parameter type in declaration.
>
> Alexander Zuev has updated the pull request incrementally with one additional
> commit since
On Tue, 21 Nov 2023 16:32:26 GMT, Kevin Rushforth wrote:
>> Ambarish Rapte has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> add @since 22
>
> modules/javafx.controls/src/main/java/javafx/scene/control/Spinn
value of Spinner and then if
> editable or not
> - 2. In application "Accessibility Insights for Windows", you can see the
> text set by `setAccessibleText()` for Spinner as the Name property and the
> Spinner's value as value property
Ambarish Rapte has updated the pull request
Currently we use the value of spinner as it's `UIA_NamePropertyId` when a11y
client application requests for it.
Ideally we should use the text set by `Node.setAccessibleText()` as the
`UIA_NamePropertyId`.
For other controls such as Slider, ListView we use the text set by
setAccessibleText()
On Wed, 15 Nov 2023 12:35:50 GMT, Kevin Rushforth wrote:
>> This PR updates the compiler on Linux to GCC 13.2.0 (from 12.2.0) to match
>> JDK 22.
>>
>> I've run headless and headful tests on Ubuntu 16.04, 20.04, and 22.04.
>
> Kevin Rushforth has updated the pull request with a new target base
On Tue, 14 Nov 2023 00:24:30 GMT, Kevin Rushforth wrote:
> This PR updates the compiler on Linux to GCC 13.2.0 (from 12.2.0) to match
> JDK 22.
>
> I've run headless and headful tests on Ubuntu 16.04, 20.04, and 22.04.
Marked as reviewed by arapte (Reviewer).
-
PR Review:
On Tue, 14 Nov 2023 12:47:51 GMT, Kevin Rushforth wrote:
>> This PR updates the compiler on Windows to Visual Studio 2022 17.6.5 (from
>> 17.5.0) to match JDK 22.
>>
>> I've run headless and headful tests.
>
> Kevin Rushforth has updated the pull request with a new target base due to a
>
On Mon, 13 Nov 2023 18:45:13 GMT, Kevin Rushforth wrote:
> This PR updates the micro version of the compiler on macOS to 14.3.1 (from
> 14.3) to match JDK 22.
>
> I've run headless and headful tests.
Marked as reviewed by arapte (Reviewer).
Marked as reviewed by arapte (Reviewer).
On Tue, 7 Nov 2023 16:04:56 GMT, Martin Fox wrote:
>> @vlaaad
>> Yes please, I think we should have a test along with this fix. A test is
>> missing for this scenario.
>> If a unit test is not feasible, can you please check to add a system test ?
>> ( may be something like setting F1 as
On Tue, 31 Oct 2023 08:05:56 GMT, vlaaad wrote:
>> This PR addresses [JDK-8284445](https://bugs.openjdk.org/browse/JDK-8284445).
>>
>> Context: the warning might be more important than it seems. Our JavaFX-based
>> desktop app has [an issue](https://github.com/defold/defold/issues/7845) —
>>
On Mon, 6 Nov 2023 08:31:54 GMT, vlaaad wrote:
>> When a function key is pressed
>> [NSFunctionKeyMask](https://developer.apple.com/documentation/appkit/nsfunctionkeymask)
>> is automatically included by the system.
>> Hence it looks not breaking behavior with this change.
>> As the warning is
On Tue, 31 Oct 2023 08:05:56 GMT, vlaaad wrote:
>> This PR addresses [JDK-8284445](https://bugs.openjdk.org/browse/JDK-8284445).
>>
>> Context: the warning might be more important than it seems. Our JavaFX-based
>> desktop app has [an issue](https://github.com/defold/defold/issues/7845) —
>>
On Thu, 2 Nov 2023 06:55:29 GMT, Jayathirth D V wrote:
>> In SW pipeline path of Box/Gaussian Blur/Shadow effects we are not checking
>> for range when we read data from the source/destination buffers in native
>> code.
>>
>> We need to add appropriate range checks in native JNI code also
On Mon, 30 Oct 2023 15:50:09 GMT, Jose Pereda wrote:
>> On macOS 14. when a JavaFX application is launched from the command line it
>> is not activated, and the terminal application remains active.
>>
>> This PR forces the application activation on macOS 14, in case the app
>> didn't get
1 - 100 of 403 matches
Mail list logo
