Re: RFR: 8331765: Websocket callbacks are not executed after WebKit 617.1 update [v4]

2024-06-21 Thread Joeri Sykora
On Fri, 21 Jun 2024 00:07:33 GMT, Jay Bhaskar wrote: >> Issue: The Websocket Channel is broken >> Solution: The socket Provider needs a web page pointer, since the web socket >> channel source code is moved to WebkitLegacy in 617.1 for the web process >> model, it is invalid for JavaFx

Integrated: 8333147: update maven classifier syntax to recent gradle version

2024-06-07 Thread Joeri Sykora
On Thu, 6 Jun 2024 17:35:54 GMT, Joeri Sykora wrote: > Replaces the deprecated `classifier` property with `archiveClassifier`. The > property was removed with the release of Gradle 8.0: > https://docs.gradle.org/8.0/userguide/upgrading_version_7.html#abstractarchivetask_api_cleanup

RFR: 8333147: update maven classifier syntax to recent gradle version

2024-06-06 Thread Joeri Sykora
Replaces the deprecated `classifier` property with `archiveClassifier`. The property was removed with the release of Gradle 8.0: https://docs.gradle.org/8.0/userguide/upgrading_version_7.html#abstractarchivetask_api_cleanup - Commit messages: - fix 8333147 Changes:

Re: JavaFX applications fail to build with Maven 3.9.7

2024-05-29 Thread Joeri Sykora
FYI, version 23-ea+20 should contain the fixed parent pom. Op wo 29 mei 2024 om 09:31 schreef Michael Hall : > > > On May 29, 2024, at 2:19 AM, Joeri Sykora wrote: > > Hi John, > > maven artifacts are generated when providing the following gradle > proper

Re: JavaFX applications fail to build with Maven 3.9.7

2024-05-29 Thread Joeri Sykora
Hi John, maven artifacts are generated when providing the following gradle property: -PMAVEN_PUBLISH=true For the actual maven publication to maven central, Gluon uses a different parent pom file, which indeed has those duplicate profile id's. We'll provide a fix that will be available from

Re: RFR: 8332539: Update libxml2 to 2.12.7

2024-05-27 Thread Joeri Sykora
On Fri, 24 May 2024 18:18:22 GMT, Hima Bindu Meda wrote: > Updated libxml to v2.12.7. Sanity testing looks fine. No issue seen Tests are green here as well. - Marked as reviewed by sykora (Author). PR Review: https://git.openjdk.org/jfx/pull/1464#pullrequestreview-2080216007

Re: RFR: 8331748: Update libxml2 to 2.12.6

2024-05-15 Thread Joeri Sykora
On Tue, 14 May 2024 05:21:37 GMT, Hima Bindu Meda wrote: > Updated libxml to v2.12.6. Verified build and sanity testing on all > platforms. No issue seen All tests are green here too. - Marked as reviewed by sykora (Author). PR Review:

Re: RFR: 8329011: Update SQLite to 3.45.3

2024-05-14 Thread Joeri Sykora
On Tue, 14 May 2024 11:45:06 GMT, Hima Bindu Meda wrote: > Update SQLite to v3.45.3.Verified build on all platforms. Sanity testing > looks fine. Everything built fine. - Marked as reviewed by sykora (Author). PR Review:

Re: RFR: 8324326: Update ICU4C to 74.2

2024-03-14 Thread Joeri Sykora
On Tue, 12 Mar 2024 14:45:06 GMT, Hima Bindu Meda wrote: > Updated icu to v74.2. Sanity testing looks fine. Verified build on all > platforms Builds and tests all ran fine. - Marked as reviewed by sykora (Author). PR Review:

Re: [jfx17u] RFR: 8318387: Update GStreamer to 1.22.6 [v2]

2024-03-07 Thread Joeri Sykora
On Thu, 7 Mar 2024 14:13:18 GMT, Johan Vos wrote: >> Almost clean backport of JDK-8318386. >> The original patch contains a fix to gstaacparse.c which is not in jfx17u >> because it does not have JDK-8277309 (JDK-8277309) > > Johan Vos has updated the pull request with a new target base due to

Re: [jfx17u] RFR: 8318614: Update WebKit to 617.1 [v2]

2024-03-07 Thread Joeri Sykora
repository. >> >> The commit being backported was authored by Hima Bindu Meda on 16 Jan 2024 >> and was reviewed by Joeri Sykora and Kevin Rushforth. >> >> Thanks! > > Johan Vos has updated the pull request with a new target base due to a merge > or a

Re: RFR: 8325258: Additional WebKit 617.1 fixes from WebKitGTK 2.42.5

2024-02-09 Thread Joeri Sykora
On Fri, 9 Feb 2024 17:05:53 GMT, Hima Bindu Meda wrote: > Ported changes related to webkit-2.42.5. Verified build on all platforms. > Sanity testing looks fine. Builds and tests ran succesfully. - Marked as reviewed by sykora (Author). PR Review:

Re: RFR: JDK-8324337: Cherry-pick WebKit 617.1 stabilization fixes [v3]

2024-01-29 Thread Joeri Sykora
On Mon, 29 Jan 2024 04:24:54 GMT, Hima Bindu Meda wrote: >> Cherry-picked changes related to webkit-2.42.4.Verified build on all >> platforms. Sanity testing looks fine. > > Hima Bindu Meda has updated the pull request incrementally with one > additional commit since the last revision: > >

Re: RFR: JDK-8324337: Cherry-pick WebKit 617.1 stabilization fixes [v2]

2024-01-26 Thread Joeri Sykora
On Fri, 26 Jan 2024 14:19:53 GMT, Hima Bindu Meda wrote: >> Cherry-picked changes related to webkit-2.42.4.Verified build on all >> platforms. Sanity testing looks fine. > > Hima Bindu Meda has updated the pull request incrementally with one > additional commit since the last revision: > >

Re: RFR: 8318614: Update WebKit to 617.1

2024-01-11 Thread Joeri Sykora
On Wed, 10 Jan 2024 17:53:46 GMT, Hima Bindu Meda wrote: > This PR updates webkit to v617.1. Verified build on Mac,Windows and linux. > Sanity testing looks fine. No issues observed in HelloWebView as well All builds and tests went fine. - Marked as reviewed by sykora (Author).

Re: RFR: 8321434: Update Gradle to 8.5

2023-12-08 Thread Joeri Sykora
On Fri, 8 Dec 2023 00:53:56 GMT, Ambarish Rapte wrote: > Gradle 8.5.0 released on Nov 29, 2023, supports JDK 21. > We need to update Gradle to 8.5 in order to update the boot JDK. > There are not API level changes in Gradle that we need to work on, hence the > change is only Gradle version

Re: RFR: 8318388: Update libxslt to 1.1.39 [v2]

2023-12-04 Thread Joeri Sykora
On Thu, 30 Nov 2023 08:37:35 GMT, Hima Bindu Meda wrote: >> Updated libxslt to v1.1.39. Verified build on all platforms.No issue seen. > > Hima Bindu Meda has updated the pull request incrementally with two > additional commits since the last revision: > > - update license for libxslt > -

Re: RFR: 8318387: Update GStreamer to 1.22.6 [v2]

2023-11-21 Thread Joeri Sykora
On Tue, 21 Nov 2023 01:03:07 GMT, Alexander Matveev wrote: >> - GStreamer updated to 1.22.6 and GLib updated to 2.78.1. >> - Tested on all platforms with all supported media streams. >> - GStreamer 1.22.6 requires GLib 2.62.0, but since we need to support older >> GLib versions on Linux

Re: RFR: 8319996: Update to GCC 13.2.0 on Linux [v2]

2023-11-15 Thread Joeri Sykora
On Wed, 15 Nov 2023 12:35:50 GMT, Kevin Rushforth wrote: >> This PR updates the compiler on Linux to GCC 13.2.0 (from 12.2.0) to match >> JDK 22. >> >> I've run headless and headful tests on Ubuntu 16.04, 20.04, and 22.04. > > Kevin Rushforth has updated the pull request with a new target base

Re: RFR: 8319762: Update to Visual Studio 2022 version 17.6.5 on Windows [v2]

2023-11-14 Thread Joeri Sykora
On Tue, 14 Nov 2023 12:47:51 GMT, Kevin Rushforth wrote: >> This PR updates the compiler on Windows to Visual Studio 2022 17.6.5 (from >> 17.5.0) to match JDK 22. >> >> I've run headless and headful tests. > > Kevin Rushforth has updated the pull request with a new target base due to a >

Re: RFR: 8318984: Update to Xcode 14.3.1 on macOS

2023-11-14 Thread Joeri Sykora
On Mon, 13 Nov 2023 18:45:13 GMT, Kevin Rushforth wrote: > This PR updates the micro version of the compiler on macOS to 14.3.1 (from > 14.3) to match JDK 22. > > I've run headless and headful tests. Marked as reviewed by sykora (Author). - PR Review:

Re: RFR: 8317508: Provide media support for libavcodec version 60

2023-10-18 Thread Joeri Sykora
On Fri, 13 Oct 2023 01:24:36 GMT, Alexander Matveev wrote: > - Added support for libavcodec version 60. > - Tested on Ubuntu 23.10 with all possible media formats. > - Changed "--disable-yasm" to "--disable-asm". "--disable-asm" disables all > assembler optimization and "--disable-yasm" only

Re: RFR: 8313321 : Set minimum python version in WebKit cmake scripts [v3]

2023-10-18 Thread Joeri Sykora
On Wed, 11 Oct 2023 03:58:01 GMT, Hima Bindu Meda wrote: >> Minimum version of python ,to run webkit build , on linux is set to 3.6 and >> for other platforms, minimum version of python is set to 3.8. >> >> Verified build on all platforms. No issue seen > > Hima Bindu Meda has updated the pull

Re: RFR: 8317370: JavaFX runtime version is wrong at runtime [v2]

2023-10-14 Thread Joeri Sykora
On Tue, 10 Oct 2023 16:24:42 GMT, John Neffenger wrote: >> Please review these changes to the build timestamp and to the JavaFX runtime >> version available in the system properties. > > John Neffenger has updated the pull request incrementally with one additional > commit since the last

Re: RFR: 8313711: Cherry-pick WebKit 616.1 stabilization fixes [v2]

2023-08-07 Thread Joeri Sykora
On Mon, 7 Aug 2023 04:18:31 GMT, Hima Bindu Meda wrote: >> Cherry-picked commits from webkitgtk-2.40.5. >> Verified build on windows, mac and linux. Sanity testing looks fine. No >> issues seen > > Hima Bindu Meda has updated the pull request incrementally with one > additional commit since

Re: RFR: JDK-8310681: Update WebKit to 616.1 [v2]

2023-07-28 Thread Joeri Sykora
On Mon, 24 Jul 2023 12:43:57 GMT, Hima Bindu Meda wrote: >> Updated JavaFX Webkit to GTK WebKit 2.40 (616.1). >> Verified the updated version build, sanity tests and stability. No issues >> have been observed. > > Hima Bindu Meda has updated the pull request incrementally with one > additional

Re: RFR: 8308308: Update to Visual Studio 2022 version 17.5.0 on Windows [v2]

2023-06-01 Thread Joeri Sykora
On Tue, 30 May 2023 19:10:08 GMT, Kevin Rushforth wrote: >> Update the compiler on Windows to Visual Studio 2022 17.5.0. This provides >> the needed C++20 support for the next WebKit update. >> >> On Windows, the existing WebKit 615.1 build fails with Visual Studio 2022 >> 17.5.0 -- see

Re: RFR: 8308307: Update to gcc 12.2.0 on Linux

2023-05-30 Thread Joeri Sykora
On Sat, 20 May 2023 14:56:16 GMT, Kevin Rushforth wrote: > Update the compiler on Linux to gcc 12.2. This provides the needed C++20 > support for the next WebKit update. Marked as reviewed by sykora (Author). - PR Review:

Re: RFR: 8308306: Update to Xcode 14.3 on macOS [v2]

2023-05-30 Thread Joeri Sykora
On Thu, 25 May 2023 16:30:38 GMT, Kevin Rushforth wrote: >> Update the compiler on macOS to Xcode 14.3. In addition to providing the >> needed C++20 support for the next WebKit update, initial testing by the JDK >> team shows that this fixes a reproducible builds problem, so it might help >>

Re: RFR: 8308308: Update to Visual Studio 2022 version 17.5.0 on Windows

2023-05-26 Thread Joeri Sykora
On Sat, 20 May 2023 14:58:40 GMT, Kevin Rushforth wrote: > Update the compiler on Windows to Visual Studio 2022 17.5.0. This provides > the needed C++20 support for the next WebKit update. > > On Windows, the existing WebKit 615.1 build fails with Visual Studio 2022 > 17.5.0 -- see

Re: RFR: 8308308: Update to Visual Studio 2022 version 17.5.0 on Windows

2023-05-25 Thread Joeri Sykora
On Sat, 20 May 2023 14:58:40 GMT, Kevin Rushforth wrote: > Update the compiler on Windows to Visual Studio 2022 17.5.0. This provides > the needed C++20 support for the next WebKit update. > > On Windows, the existing WebKit 615.1 build fails with Visual Studio 2022 > 17.5.0 -- see

Re: RFR: 8308306: Update to Xcode 14.3 on macOS

2023-05-25 Thread Joeri Sykora
On Sat, 20 May 2023 14:47:50 GMT, Kevin Rushforth wrote: > Update the compiler on macOS to Xcode 14.3. In addition to providing the > needed C++20 support for the next WebKit update, initial testing by the JDK > team shows that this fixes a reproducible builds problem, so it might help >

Re: RFR: 8306115 : Update libxml2 to 2.10.4

2023-04-25 Thread Joeri Sykora
On Fri, 21 Apr 2023 10:34:49 GMT, Hima Bindu Meda wrote: > Updated libxml to v2.10.4.Configured and verified on all Windows, Linux and > Mac. > Sanity testing looks fine. Builds and tests completed without issues. - Marked as reviewed by sykora (Author). PR Review:

Re: RFR: 8286089: Intermittent WebKit build failure on macOS in JavaScriptCore

2023-04-04 Thread Joeri Sykora
On Tue, 28 Mar 2023 02:08:27 GMT, Jay Bhaskar wrote: > Issue: Error copying file (if different) from > Source/JavaScriptCore/Scripts/wkbuiltins/builtins_generate_separate_header.py" > to > "modules/javafx.web/build/mac/Release/JavaScriptCcripts/builtins_generate_separate_header.py". > > Root

Re: RFR: 8282359: Intermittent WebKit build failure on Windows: C1090: PDB API call failed, error code 23 [v4]

2023-04-04 Thread Joeri Sykora
On Mon, 3 Apr 2023 18:50:57 GMT, Hima Bindu Meda wrote: >> In Jenkins Build, the intermediate failure on windows is observed due to >> crash in mspdbserv.exe, which generates Program database (.pdb) files. >> Disabled the pdb file generation in order to resolve the build failure. >> Sanity

Re: RFR: 8301009: Update libxml2 to 2.10.3

2023-03-16 Thread Joeri Sykora
On Tue, 14 Mar 2023 08:04:04 GMT, Hima Bindu Meda wrote: > Updated Libxml2 to v2.10.3. verfied build and sanity testing on windows, mac > and Linux platforms. > No issue observed. Building and running tests worked on windows, linux and macos. - Marked as reviewed by sykora

Re: RFR: 8302684 : Cherry-pick WebKit 615.1 stabilization fixes (2)

2023-02-17 Thread Joeri Sykora
On Thu, 16 Feb 2023 19:29:26 GMT, Hima Bindu Meda wrote: > Stabilization fixes from Webkitgtk-2.38.5. > Verified drt and unit tests. No issues observed. Building and testing completed without issues. - Marked as reviewed by sykora (Author). PR:

Re: RFR: 8302294 : Cherry-pick WebKit 615.1 stabilization fixes

2023-02-15 Thread Joeri Sykora
On Tue, 14 Feb 2023 18:19:17 GMT, Hima Bindu Meda wrote: > Cherry-pick stabilisation fixes till 2.38.4. > Verified unit tests and drt. No issue observed. Building and testing succeeded. - Marked as reviewed by sykora (Author). PR: https://git.openjdk.org/jfx/pull/1033

Re: RFR: JDK-8299977 : Update WebKit to 615.1 [v3]

2023-02-01 Thread Joeri Sykora
On Wed, 1 Feb 2023 04:11:48 GMT, Hima Bindu Meda wrote: >> Update JavaFX WebKit to GTK WebKit 2.38 (615.1). >> >> Verified the updated version build, sanity tests and stability. >> This does not cause any issues except one unit test failure. >> Also, there are some artifacts observed while

Re: RFR: JDK-8299977 : Update WebKit to 615.1 [v2]

2023-01-31 Thread Joeri Sykora
On Mon, 30 Jan 2023 15:11:20 GMT, Hima Bindu Meda wrote: >> Update JavaFX WebKit to GTK WebKit 2.38 (615.1). >> >> Verified the updated version build, sanity tests and stability. >> This does not cause any issues except one unit test failure. >> Also, there are some artifacts observed while

Re: RFR: 8289952: Visual Studio libs msvcp140_1.dll and msvcp140_2.dll missing from build

2022-07-11 Thread Joeri Sykora
On Thu, 7 Jul 2022 23:16:12 GMT, Kevin Rushforth wrote: > On Windows platforms we redistribute the Visual Studio runtime libraries with > the JavaFX build so that JavaFX applications can run on systems that don't > have them installed already. The main C++ runtime library is `msvcp140.dll`, >