Finally getting to this. To add to what Michael said about the development
process, there are many large ongoing efforts in various stages (interest
gathering, proposals, discussions, PRs...) that require a lot of investment
from the maintainers. From the top of my head: various CSS changes +
reimp
On Sat, 14 Sep 2024 07:38:38 GMT, Michael Strauß wrote:
>> Then maybe mention that paired elements are interpolated?
>> By "this specs is for the list itself" I meant that pairwise interpolation
>> is only relevant for the list itself and not for an element in the list
>> (unless it's a list it
On Sat, 14 Sep 2024 07:43:41 GMT, Michael Strauß wrote:
>> This PR completes the CSS Transitions story (see #870) by adding
>> interpolation support for backgrounds and borders, making them targetable by
>> transitions.
>>
>> `Background` and `Border` objects are deeply immutable, but not
>>
On Sat, 14 Sep 2024 06:49:33 GMT, Michael Strauß wrote:
>> modules/javafx.graphics/src/main/java/javafx/animation/Interpolatable.java
>> line 54:
>>
>>> 52: * Two lists are combined by pairwise interpolation. If
>>> the start list has fewer elements than
>>> 53: *
On Sat, 14 Sep 2024 06:58:04 GMT, Michael Strauß wrote:
>> modules/javafx.graphics/src/main/java/javafx/scene/layout/Background.java
>> line 292:
>>
>>> 290: private Background(List fills,
>>> List images, int ignored) {
>>> 291: Objects.requireNonNull(fills, "fills cannot be null"
On Sun, 8 Sep 2024 20:55:53 GMT, Michael Strauß wrote:
>> This PR completes the CSS Transitions story (see #870) by adding
>> interpolation support for backgrounds and borders, making them targetable by
>> transitions.
>>
>> `Background` and `Border` objects are deeply immutable, but not
>> i
On Sun, 8 Sep 2024 20:55:53 GMT, Michael Strauß wrote:
>> This PR completes the CSS Transitions story (see #870) by adding
>> interpolation support for backgrounds and borders, making them targetable by
>> transitions.
>>
>> `Background` and `Border` objects are deeply immutable, but not
>> i
On Sun, 8 Sep 2024 20:55:53 GMT, Michael Strauß wrote:
>> This PR completes the CSS Transitions story (see #870) by adding
>> interpolation support for backgrounds and borders, making them targetable by
>> transitions.
>>
>> `Background` and `Border` objects are deeply immutable, but not
>> i
On Thu, 12 Sep 2024 13:19:26 GMT, Michael Strauß wrote:
>> Is this code required to be so highly performant that you need to check for
>> `RandomAccess`? Under normal circumstances, I would just stream the list and
>> filter for `null`s.
>
> This can run tens of thousands of times per second, w
Did I miss them?
On Thu, Sep 12, 2024 at 3:59 PM Nir Lisker wrote:
> Do you mind taking a look, and maybe helping answer some of my questions?
>> I'm just not getting any replies, so I'm somewhat confused.
>>
>
> I'll try to take a closer look during the weekend. T
es and render states to the same class. See
https://github.com/openjdk/jfx/pull/1281#discussion_r1412368579.
You can see all the threads in the mailing list archive:
http://mail.openjdk.java.net/pipermail/openjfx-dev/.
On Tue, Sep 10, 2024 at 4:22 AM Knee Snap wrote:
> @Nir Lisker Do you mind
On Sat, 3 Aug 2024 00:14:04 GMT, Michael Strauß wrote:
>> modules/javafx.base/src/main/java/com/sun/javafx/UnmodifiableArrayList.java
>> line 81:
>>
>>> 79:
>>> 80: @SuppressWarnings("unchecked")
>>> 81: T[] newValues = (T[])new Object[list.size()];
>>
>> With many `null`s thi
On Thu, 5 Sep 2024 12:01:23 GMT, Michael Strauß wrote:
> None of these classes can be extended by user code, and any attempt to do so
> will fail at runtime with an exception. For this reason, we can seal the
> class hierarchy and remove the run-time checks to turn this into a
> compile-time e
On Thu, 5 Sep 2024 12:01:23 GMT, Michael Strauß wrote:
> None of these classes can be extended by user code, and any attempt to do so
> will fail at runtime with an exception. For this reason, we can seal the
> class hierarchy and remove the run-time checks to turn this into a
> compile-time e
On Thu, 5 Sep 2024 12:01:23 GMT, Michael Strauß wrote:
> None of these classes can be extended by user code, and any attempt to do so
> will fail at runtime with an exception. For this reason, we can seal the
> class hierarchy and remove the run-time checks to turn this into a
> compile-time e
On Wed, 4 Sep 2024 14:38:00 GMT, Kevin Rushforth wrote:
>> This PR adds the release notes for the JavaFX 23 release. This will first go
>> into `master`, and then be backported to the `jfx23` branch so it will be
>> available in that branch when JavaFX 23 is published (and from there also
>> s
On Wed, 4 Sep 2024 11:42:47 GMT, Kevin Rushforth wrote:
> Should I split the "Enhancements" section into two groups as shown in the PR
> Description, or leave it as a single group?
@abhinayagarwal Do you write the highlights page
https://openjfx.io/highlights/22/? Will the same split be done t
On Tue, 3 Sep 2024 17:09:51 GMT, Michael Strauß wrote:
>> This PR completes the CSS Transitions story (see #870) by adding
>> interpolation support for backgrounds and borders, making them targetable by
>> transitions.
>>
>> `Background` and `Border` objects are deeply immutable, but not
>> i
I have WSL 2 and I didn't get this error. For Windows, you're not supposed
to use WSL at all for the building process, so no reason for it to be
involved. I suggest that you just run "./gradlew :media:buildWINGlib"
(which is where the error is occurring) with --debug or --info.
Did you set up Visu
On Fri, 30 Aug 2024 12:47:38 GMT, Kevin Rushforth wrote:
> This PR adds the release notes for the JavaFX 23 release. This will first go
> into `master`, and then be backported to the `jfx23` branch so it will be
> available in that branch when JavaFX 23 is published (and from there also
> sync
When modern APIs agree on a feature, it makes sense to consider it for
JavaFX (that lacks a lot of standard features). If you can give links to
the API and docs of vertex coloring in D3D9, OpenGL, Metal and possibly
Vulkan and D3D11 for future-proofing, we could see what APIs they support
exactly a
On Tue, 20 Aug 2024 02:59:00 GMT, Ambarish Rapte wrote:
> Gradle 8.8 released on May 31, 2024, supports JDK 22.
> On Jul 11, 2024, gradle 8.9 was released too, so we can update to the latest
> gradle 8.9
>
> This gradle update is required in order to update the boot jdk to 22.0.2.
> The change
On Fri, 9 Aug 2024 22:32:46 GMT, Michael Strauß wrote:
>> This PR completes the CSS Transitions story (see #870) by adding
>> interpolation support for backgrounds and borders, making them targetable by
>> transitions.
>>
>> `Background` and `Border` objects are deeply immutable, but not
>> i
ring. Simpler to use, and simpler in terms of
> supported features – does not offer tables, for instance. There are still
> use cases which RTA won’t be able to address, and for which an external
> library is still needed.
>
>
>
> Thanks again for good questions. Did
lone.
> - RichTextFX depends on several long-unmaintained libraries, namely
> ReactFX. There is nothing that can be done from the OpenJFX side, as it
> would require rewriting RichTextFX from scratch.
>
> I don't think anyone expects OpenJFX to provide something as complex as
My questions are similar to the ones in the previous discussion, but now I
can be more specific.
I see a list of "building blocks" in
https://bugs.openjdk.org/browse/JDK-8300569, which I like. Specifically,
two types of building blocks additions are important as I see it: rich
text-specific ones l
On Wed, 14 Aug 2024 02:21:30 GMT, Kevin Rushforth wrote:
>> 1. Added logic to look in the standard locations for Visual Studio 2022,
>> with a fallback to 2019 and then 2017 if 2022 is not found. It will look in
>> the following locations:
>>
>> C:("Program Files"|"Program Files (x86)")\Micros
On Mon, 12 Aug 2024 21:31:49 GMT, Kevin Rushforth wrote:
>> 1. Added logic to look in the standard locations for Visual Studio 2022,
>> with a fallback to 2019 and then 2017 if 2022 is not found. It will look in
>> the following locations:
>>
>> C:("Program Files"|"Program Files (x86)")\Micros
On Wed, 7 Aug 2024 22:47:28 GMT, Andy Goryachev wrote:
> oops, yes, you did, my mistake. the master progressed since then, got me
> confused.
>
> I got a bunch of errors again after switching:
>
> ```
> Description ResourceTypePathLocation
> Cannot infer type arguments for Pa
On Wed, 7 Aug 2024 02:13:12 GMT, John Hendrikx wrote:
>> Moves `SimpleSelector` and `CompoundSelector` to internal packages.
>>
>> This can be done with only a minor API break, as `SimpleSelector` and
>> `CompoundSelector` were public before. However, these classes could not be
>> constructed
On Wed, 7 Aug 2024 02:13:12 GMT, John Hendrikx wrote:
>> Moves `SimpleSelector` and `CompoundSelector` to internal packages.
>>
>> This can be done with only a minor API break, as `SimpleSelector` and
>> `CompoundSelector` were public before. However, these classes could not be
>> constructed
On Mon, 12 Aug 2024 15:37:10 GMT, Kevin Rushforth wrote:
>> 1. Added logic to look in the standard locations for Visual Studio 2022,
>> with a fallback to 2019 and then 2017 if 2022 is not found. It will look in
>> the following locations:
>>
>> C:("Program Files"|"Program Files (x86)")\Micros
On Sat, 10 Aug 2024 11:53:00 GMT, John Hendrikx wrote:
>>> This is not the case. The sorting is still correct. Claiming that the
>>> sorting is invalid because a newly added item was not placed in a specific
>>> location relative to other equal items is a bit of misrepresentation.
>>>
>>> So,
that briefly describes what is being tested.
>
> If that is in line with what most people want, I can create a PR to add
> this to the CONTRIBUTING.md file.
>
> - Johan
>
> On Wed, Jul 10, 2024 at 1:36 AM Nir Lisker wrote:
>
>> * in some cases, tests are always prefi
My Eclipse never had this long filename problem, and I reviewed the fluent
bindings PR when it was written so I would have seen it. You can try the
most basic version of Eclipse (
https://download.eclipse.org/eclipse/downloads/) to see if it still happens
if you want to dig into it.
On Tue, Jul 9,
>
> * in some cases, tests are always prefixed with `test` (e.g. `testFoo()`)
> * in some cases, tests have a concise but somehow meaningful name (e.g.
> `testScrollBarStaysVisible`)
Prefixing 'test' was an old convention for testing frameworks. I have been
dropping that prefix in my projects sin
On Wed, 26 Jun 2024 21:23:34 GMT, Andy Goryachev wrote:
> This might be controversial. I am proposing to remove the Gradle integration
> in the Eclipse config files.
>
> Problem
> ===
> Eclipse Gradle integration (Buildship) cannot import the OpenJFX build.gradle
> cleanly. Every time the
On Mon, 8 Jul 2024 09:08:19 GMT, John Hendrikx wrote:
> I work around this by running the test once, then changing its configuration
> and adding a standard incantation to its command line (`-Djavafx.toolkit`,
> `-Djava.library.path`, some `--add-modules`)
The `--add-modules` could be taken c
On Wed, 26 Jun 2024 21:23:34 GMT, Andy Goryachev wrote:
> This might be controversial. I am proposing to remove the Gradle integration
> in the Eclipse config files.
>
> Problem
> ===
> Eclipse Gradle integration (Buildship) cannot import the OpenJFX build.gradle
> cleanly. Every time the
As discussed previously regarding auto-generation of css styleables, an
annotation on the property can be made displayable in javadoc. The
problem is that it will display *all* the parameters of the annotation. For
autogeneration, we need more than what we would like to display, so perhaps
two diff
On Mon, 3 Jun 2024 09:48:40 GMT, Florian Kirmaier wrote:
> Note that this PR also changes the specification of Interpolatable to make
> users aware that they shouldn't assume any particular identity of the object
> returned from the interpolate() method. This allows the implementation to
> re-
On Tue, 4 Jun 2024 20:46:28 GMT, Kevin Rushforth wrote:
> @nlisker would you be willing to be the second reviewer?
I could do some of the review, but probably no time for a full one.
> Since you propose interpolating objects that aren't simple sets of
> floating-point fields, the overridden in
On Tue, 4 Apr 2023 15:22:48 GMT, John Hendrikx wrote:
> This provides and uses a new implementation of `ExpressionHelper`, called
> `ListenerManager` with improved semantics.
>
> # Behavior
>
> |Listener...|ExpressionHelper|ListenerManager|
> |---|---|---|
> |Invocation Order|In order they wer
https://github.com/eclipse/buildship/issues/658 is not that relevant
because it describes a problem in Gradle's integration with Eclipse, not
with Buildship, but it's reported on Buildship, so I don't think there's
much to resolve there except for alignment issues. It has since been solved
on Gradl
It has been a while since I tried a clean import of jfx, but the
instructions in
https://wiki.openjdk.org/display/OpenJFX/Using+an+IDE#UsinganIDE-UsingEclipse
seem correct, unless something changed. What you describe is written there.
Only the initial import requires a gradle build, and after rever
On Wed, 5 Jun 2024 21:59:13 GMT, Michael Strauß wrote:
>> Implementation of [CSS
>> Transitions](https://www.w3.org/TR/css-transitions-1/).
>>
>> ### Future enhancements
>> CSS transition support for backgrounds and borders: #1471
>>
>> ### Limitations
>> This implementation supports both sho
Hi Risto,
There is some work on this already here:
https://github.com/openjdk/jfx/pull/1281. I didn't have time to continue
with it, so it was auto-closed. To answer your points specifically:
Hi, sometimes it is useful to clamp texture coordinates that exceed the
> normal 0-1 range, however curre
On Wed, 29 May 2024 15:52:36 GMT, Lukasz Kostyra wrote:
>> Checked code and fixed the gramatical error in Transition files:
>> s/interval/intervals
>>
>> Fill and Stroke Transition had correct grammatical form already, so those
>> were untouched. I couldn't find any other instances of this err
On Wed, 29 May 2024 06:53:40 GMT, Lukasz Kostyra wrote:
> Checked code and fixed the gramatical error in Transition files:
> s/interval/intervals
>
> Fill and Stroke Transition had correct grammatical form already, so those
> were untouched. I couldn't find any other instances of this error in
Resending the vote on the mailing list because I sent it only to Kevin.
Vote: YES
On Thu, May 23, 2024 at 2:38 AM Nir Lisker wrote:
> Vote: YES
>
> On Thu, May 23, 2024 at 2:24 AM Kevin Rushforth <
> kevin.rushfo...@oracle.com> wrote:
>
>> I hereby nominate J
On Sun, 26 May 2024 08:08:26 GMT, Michael Strauß wrote:
>> Implementation of [CSS
>> Transitions](https://gist.github.com/mstr2/c72f8c9faa87de14926978f517a6018a).
>>
>> ### Future enhancements
>> CSS transitions requires all participating objects to implement the
>> `Interpolatable` interface.
On Sat, 25 May 2024 21:39:24 GMT, Michael Strauß wrote:
>> Implementation of [CSS
>> Transitions](https://gist.github.com/mstr2/c72f8c9faa87de14926978f517a6018a).
>>
>> ### Future enhancements
>> CSS transitions requires all participating objects to implement the
>> `Interpolatable` interface.
On Sat, 25 May 2024 20:40:39 GMT, Michael Strauß wrote:
>> Implementation of [CSS
>> Transitions](https://gist.github.com/mstr2/c72f8c9faa87de14926978f517a6018a).
>>
>> ### Future enhancements
>> CSS transitions requires all participating objects to implement the
>> `Interpolatable` interface.
On Sat, 25 May 2024 21:04:24 GMT, Michael Strauß wrote:
>> modules/javafx.graphics/src/main/docs/javafx/scene/doc-files/cssref.html
>> line 690:
>>
>>> 688: changed, it smoothly transitions to the new value over a
>>> period of time. Implicit transitions are supported
>>> 689:
On Sat, 25 May 2024 20:37:44 GMT, Michael Strauß wrote:
>> modules/javafx.graphics/src/main/java/javafx/animation/Interpolator.java
>> line 277:
>>
>>> 275: * @since 23
>>> 276: */
>>> 277: public enum StepPosition {
>>
>> I think it would be helpful to include (or link to) image
On Mon, 31 Jul 2023 18:10:46 GMT, Michael Strauß wrote:
>> modules/javafx.graphics/src/main/java/javafx/animation/Interpolator.java
>> line 319:
>>
>>> 317: * The output time value is determined by the {@link StepPosition}.
>>> 318: *
>>> 319: * @param intervals the number of int
On Fri, 24 May 2024 11:18:35 GMT, Michael Strauß wrote:
>> Implementation of [CSS
>> Transitions](https://gist.github.com/mstr2/c72f8c9faa87de14926978f517a6018a).
>>
>> ### Future enhancements
>> CSS transitions requires all participating objects to implement the
>> `Interpolatable` interface.
On Mon, 11 Mar 2024 16:54:25 GMT, John Hendrikx wrote:
>> Improves performance of selector matching in the CSS subsystem. This is done
>> by using custom set implementation which are highly optimized for the most
>> common cases where the number of selectors is small (most commonly 1 or 2).
>>
On Tue, 21 May 2024 22:32:21 GMT, Kevin Rushforth wrote:
>> Update the code review guidelines for JavaFX.
>>
>> The JavaFX
>> [CONTRIBUTING](https://github.com/kevinrushforth/jfx/blob/8332313-contributing/CONTRIBUTING.md)
>> guidelines includes guidance for creating, reviewing, and integrating
On Sat, 18 May 2024 14:24:49 GMT, Kevin Rushforth wrote:
> Maybe it's worth changing "adds any new" to "adds, removes, or modifies any"?
This looks like a good idea.
-
PR Review Comment: https://git.openjdk.org/jfx/pull/1455#discussion_r1605798488
On Fri, 17 May 2024 14:58:41 GMT, Nir Lisker wrote:
>> Kevin Rushforth has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains 20 addi
On Fri, 17 May 2024 14:10:43 GMT, Kevin Rushforth wrote:
>> Update the code review guidelines for JavaFX.
>>
>> The JavaFX
>> [CONTRIBUTING](https://github.com/kevinrushforth/jfx/blob/8332313-contributing/CONTRIBUTING.md)
>> guidelines includes guidance for creating, reviewing, and integrating
On Thu, 16 May 2024 15:42:05 GMT, Kevin Rushforth wrote:
> It looks like the list of packages available in the Ubuntu 22.04 GitHub
> Actions test runner no longer includes `gcc-13` as of yesterday. I didn't
> find any documentation to indicate that this was intentional, but now that
> Ubuntu 2
On Wed, 15 May 2024 20:08:10 GMT, John Hendrikx wrote:
>> or is it? :-)
>
> Isn't this automatic? Seems weird you could integrate without these passing.
> or is it? :-)
Looks to me like it is...
---
On Wed, 15 May 2024 17:45:56 GMT, Kevin Rushforth wrote:
> Update the code review guidelines for JavaFX.
>
> The JavaFX
> [CONTRIBUTING](https://github.com/kevinrushforth/jfx/blob/8332313-contributing/CONTRIBUTING.md)
> guidelines includes guidance for creating, reviewing, and integrating
> c
On Fri, 26 Apr 2024 07:53:59 GMT, Lukasz Kostyra wrote:
>> JFX minimum requirements guarantee 9Ex availability, so old non-Ex paths are
>> no longer needed.
>>
>> In multiple parts (ex. Mesh, Graphics, etc.) where the Device is acquired I
>> changed the type to explicitly use `IDirect3DDevice9
On Tue, 23 Apr 2024 10:33:58 GMT, Lukasz Kostyra wrote:
> JFX minimum requirements guarantee 9Ex availability, so old non-Ex paths are
> no longer needed.
>
> In multiple parts (ex. Mesh, Graphics, etc.) where the Device is acquired I
> changed the type to explicitly use `IDirect3DDevice9Ex`.
On Tue, 23 Apr 2024 10:33:58 GMT, Lukasz Kostyra wrote:
> JFX minimum requirements guarantee 9Ex availability, so old non-Ex paths are
> no longer needed.
>
> In multiple parts (ex. Mesh, Graphics, etc.) where the Device is acquired I
> changed the type to explicitly use `IDirect3DDevice9Ex`.
On Tue, 23 Apr 2024 10:33:58 GMT, Lukasz Kostyra wrote:
> JFX minimum requirements guarantee 9Ex availability, so old non-Ex paths are
> no longer needed.
>
> In multiple parts (ex. Mesh, Graphics, etc.) where the Device is acquired I
> changed the type to explicitly use `IDirect3DDevice9Ex`.
On Tue, 23 Apr 2024 10:33:58 GMT, Lukasz Kostyra wrote:
> JFX minimum requirements guarantee 9Ex availability, so old non-Ex paths are
> no longer needed.
>
> In multiple parts (ex. Mesh, Graphics, etc.) where the Device is acquired I
> changed the type to explicitly use `IDirect3DDevice9Ex`.
n/java/javase/21/core/restricted-methods.html
>>
>> But one thing to watch out for with FFM is startup + warm up time.
>> I struggled a lot with that in using FFM for just one library in the
>> java.desktop module.
>>
>> -phil
>>
>> On 4/22/24 9:12 AM
Sorry, we bumped to Java 21 in JavaFX 22 I think since we preserve the N-1
rule.
On Mon, Apr 22, 2024 at 6:03 PM Nir Lisker wrote:
> I think that we'll be able to bump to Java 25 in JavaFX 25, like we did
> with 21. I suggested initially to bump to Java 22 exactly for FFM as it'
I think that we'll be able to bump to Java 25 in JavaFX 25, like we did
with 21. I suggested initially to bump to Java 22 exactly for FFM as it's
very useful for JavaFX, but was told we shouldn't since it's not an LTS
version.
I have no idea how long the work on Wayland will take including the cod
tings);
> return new Size(size, size);
> }
>
>
> 2) Callbacks
>
> @Override
> protected void _invokeLater(Runnable runnable) {
> MemorySegment call = GSourceFunc.allocate(p -> {
> runnable.run();
> return 0;
> }, Arena.ofAuto());
>
> g_idle_
I would need this to hook the events with wl_registry_add_listener, but
> currently the code generation for this is not working.
>
>
>
>
>
> Em dom., 21 de abr. de 2024 às 16:39, Nir Lisker
> escreveu:
>
>> What are wl_ types? jextract only supports c headers.
>>
>> On
What are wl_ types? jextract only supports c headers.
On Sun, Apr 21, 2024 at 10:31 PM Thiago Milczarek Sayão <
thiago.sa...@gmail.com> wrote:
> Hi,
>
> I did a small test app to explore Wayland client and portals (for Robot
> and dialogs such as file open/save).
>
> https://github.com/tsayao/way
I didn't find such memory leaks in my application, though I don't do stage
handling. What I would look at is where the `stage` reference in the lambda
is coming from. You say you have a list of open stages. When you close a
stage, do you remove the references to that stage from all places? What
abo
On Thu, 28 Mar 2024 22:21:32 GMT, drmarmac wrote:
>> modules/javafx.controls/src/main/java/javafx/scene/control/ControlUtils.java
>> line 166:
>>
>>> 164: sm.startAtomic();
>>> 165:
>>> 166: final List removed = new
>>> ArrayList<>(c.getRemovedSize());
>>
>> I wonder
On Wed, 27 Mar 2024 23:18:43 GMT, Marius Hanl wrote:
>> modules/javafx.controls/src/main/java/javafx/scene/control/MultipleSelectionModelBase.java
>> line 773:
>>
>>> 771: .collect(Collectors.toList());
>>> 772:
>>> 773: sortedNewIndices.forEach(this::se
On Wed, 27 Mar 2024 20:38:58 GMT, Nir Lisker wrote:
>> Update for the 3D lighting test tool as described in the JBS issue.
>
> Nir Lisker has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Added gradle script
Looks like
> Update for the 3D lighting test tool as described in the JBS issue.
Nir Lisker has updated the pull request incrementally with one additional
commit since the last revision:
Whitespace?
-
Changes:
- all: https://git.openjdk.org/jfx/pull/1387/files
- new: ht
On Wed, 27 Mar 2024 20:38:58 GMT, Nir Lisker wrote:
>> Update for the 3D lighting test tool as described in the JBS issue.
>
> Nir Lisker has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Added gradle script
I added t
> Update for the 3D lighting test tool as described in the JBS issue.
Nir Lisker has updated the pull request incrementally with one additional
commit since the last revision:
Added gradle script
-
Changes:
- all: https://git.openjdk.org/jfx/pull/1387/files
- new: ht
On Thu, 21 Mar 2024 21:50:37 GMT, Andy Goryachev wrote:
> Using Eclipse IDE to remove unused imports in **demo apps** (3D, Ensemble,
> etc.) and update the copyright year to 2024. Using wildcard for more than 10
> static imports.
>
>
> --
>
> This is a trivial change (though fairly large), 1
On Wed, 27 Mar 2024 09:11:56 GMT, drmarmac wrote:
>> This PR removes potentially incorrect usages of Stream.peek().
>> The changed code should be covered by the tests that are already present.
>
> drmarmac has updated the pull request incrementally with one additional
> commit since the last rev
On Wed, 27 Mar 2024 12:23:47 GMT, Marius Hanl wrote:
>> I'd say .forEach() is used correctly here, according to docs, it guarantees
>> execution of the side-effects (add to removed list & clear index), just not
>> in any particular order. This way we avoid multiple iteration.
>
> Another idea i
On Wed, 13 Mar 2024 22:32:59 GMT, Nir Lisker wrote:
>> Update for the 3D lighting test tool as described in the JBS issue.
>
> Nir Lisker has updated the pull request incrementally with five additional
> commits since the last revision:
>
> - Added spacing
> - Renam
On Thu, 21 Mar 2024 18:47:24 GMT, Andy Goryachev wrote:
> Using Eclipse IDE to remove unused imports in javafx.controls and update the
> copyright year to 2024. Using wildcard for more than 10 static imports.
>
> This is a trivial change, 1 reviewer is probably enough.
I can, but it will take
On Tue, 19 Mar 2024 22:28:54 GMT, Andy Goryachev wrote:
>> tests/system/src/test/java/test/util/Util.java line 383:
>>
>>> 381: runAndWait(() -> {
>>> 382: for (Window w : new ArrayList<>(Window.getWindows())) {
>>> 383: w.hide();
>>
>> I think you can use `L
On Mon, 18 Mar 2024 22:53:03 GMT, Andy Goryachev wrote:
> Changing `Util.shutdown()` to hide **all** showing Windows and then call
> `Platform.exit()`.
> This simplifies the tests and ensures a clean shutdown.
tests/system/src/test/java/test/util/Util.java line 383:
> 381: runAndWait((
On Tue, 5 Mar 2024 16:44:00 GMT, Ambarish Rapte wrote:
> Executing the LightingSample manually fails with an exception
I think the package names of the main and resources weren't aligned.
> The copyright year new files should be 2024 only. Some new files have more
> than one copyright year. If
> Update for the 3D lighting test tool as described in the JBS issue.
Nir Lisker has updated the pull request incrementally with five additional
commits since the last revision:
- Added spacing
- Renamed constant
- Updated benchmark reset message
- Simplified models creation
- Rev
On Tue, 5 Mar 2024 16:49:28 GMT, Ambarish Rapte wrote:
>> Nir Lisker has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> copyright headers
>
> tests/performance/3DLighting/src/main/java/lighting3D/Be
> Update for the 3D lighting test tool as described in the JBS issue.
Nir Lisker has updated the pull request incrementally with one additional
commit since the last revision:
copyright headers
-
Changes:
- all: https://git.openjdk.org/jfx/pull/1387/files
- new: ht
> Update for the 3D lighting test tool as described in the JBS issue.
Nir Lisker has updated the pull request incrementally with one additional
commit since the last revision:
Undo files move
-
Changes:
- all: https://git.openjdk.org/jfx/pull/1387/files
- new: ht
On Sat, 9 Mar 2024 06:48:25 GMT, John Hendrikx wrote:
>> Improves performance of selector matching in the CSS subsystem. This is done
>> by using custom set implementation which are highly optimized for the most
>> common cases where the number of selectors is small (most commonly 1 or 2).
>>
On Mon, 4 Mar 2024 21:04:28 GMT, Andy Goryachev wrote:
> Adds Labeled.truncated property which indicates when the text is visually
> truncated (and the ellipsis string is inserted) in order to fit the available
> width.
>
> The new property reacts to changes in the following properties:
> - el
Update for the 3D lighting test tool as described in the JBS issue.
-
Commit messages:
- Whitespaces
- Initial commit
Changes: https://git.openjdk.org/jfx/pull/1387/files
Webrev: https://webrevs.openjdk.org/?repo=jfx&pr=1387&range=00
Issue: https://bugs.openjdk.org/browse/JDK-83
Hi Dirk,
JavaFX has some input validation support in terms of focus control and
rejecting invalid characters. Can you explain what your proposal adds? Are
there JBS issues asking for this?
Thanks,
Nir
On Fri, Mar 1, 2024, 13:50 Dirk Lemmermann wrote:
> Hi everyone,
>
> I updated the validatio
On Wed, 28 Feb 2024 18:48:21 GMT, Nir Lisker wrote:
>> Overhaul to the `PhongMaterial` documentation (and a bit to its superclass
>> `Material`). Except for the introduction, I divided the documentation into 3
>> sections: qualitative explanation, mathematical model (I
1 - 100 of 704 matches
Mail list logo
