Re: RFR: 8211247: Open-source simple test programs for FX / SWT interop

2024-09-18 Thread duke
On Tue, 17 Sep 2024 14:29:11 GMT, Jayathirth D V wrote: > This PR is for open-sourcing HelloFXCanvas test app. > JBS : https://bugs.openjdk.org/browse/JDK-8211247 > It is an SWT app with SWT button and an FXCanvas with animated rectangle. > This is used on our integration testing. > > This test

Re: [jfx17u] RFR: 8319996: Update to GCC 13.2.0 on Linux

2024-09-11 Thread duke
On Wed, 11 Sep 2024 14:10:15 GMT, Sergey Chernyshev wrote: > Hi all, > > Please review this clean backport of > [2e733041](https://github.com/openjdk/jfx/commit/2e7330417c2f39fee15676966d5b7455bb3fcbff) > from the [openjdk/jfx](https://git.openjdk.org/jfx) repository. > > The fix being backp

Re: [jfx17u] RFR: 8319762: Update to Visual Studio 2022 version 17.6.5 on Windows

2024-09-11 Thread duke
On Wed, 11 Sep 2024 10:57:02 GMT, Sergey Chernyshev wrote: > Hi all, > > Please review a clean backport of > [2d4b494e](https://github.com/openjdk/jfx/commit/2d4b494ea9cee1acd0407b9de61f0af9163f5d62) > from the [openjdk/jfx](https://git.openjdk.org/jfx) repository. > > The fix being backport

Re: [jfx17u] RFR: 8334713: WebKit build failed on LoongArch64 because currentStackPointer is undefined

2024-09-11 Thread duke
On Tue, 10 Sep 2024 12:36:42 GMT, Sergey Chernyshev wrote: > Hi all, > > Please review the clean backport of the commit > [ca04c87d](https://github.com/openjdk/jfx/commit/ca04c87d307c36591162af8cd6298ede17812834) > from the [openjdk/jfx](https://git.openjdk.org/jfx) repository. > > The commi

Re: [jfx21u] RFR: 8334713: WebKit build failed on LoongArch64 because currentStackPointer is undefined

2024-09-11 Thread duke
On Tue, 10 Sep 2024 12:33:35 GMT, Sergey Chernyshev wrote: > Hi all, > > Please review the clean backport of the commit > [ca04c87d](https://github.com/openjdk/jfx/commit/ca04c87d307c36591162af8cd6298ede17812834) > from the [openjdk/jfx](https://git.openjdk.org/jfx) repository. > > The commi

Re: [jfx17u] RFR: 8318984: Update to Xcode 14.3.1 on macOS

2024-09-11 Thread duke
On Tue, 10 Sep 2024 13:39:11 GMT, Sergey Chernyshev wrote: > Hi all, > > Please review a clean backport of > [d24e96a6](https://github.com/openjdk/jfx/commit/d24e96a66f1908b5a1a1a7d48ee938ba1c782e6c) > from the [openjdk/jfx](https://git.openjdk.org/jfx) repository. > > The fix being backport

Re: [jfx17u] RFR: 8331765: Websocket callbacks are not executed after WebKit 617.1 update

2024-09-11 Thread duke
On Tue, 10 Sep 2024 12:40:02 GMT, Sergey Chernyshev wrote: > Hi all, > > Please review a clean backport of > [6a586b66](https://github.com/openjdk/jfx/commit/6a586b662592be3eb81670f0c5ce48061c2fc07c) > from the [openjdk/jfx](https://git.openjdk.org/jfx) repository. > > The commit being backp

Re: [jfx17u] RFR: 8282359: Intermittent WebKit build failure on Windows: C1090: PDB API call failed, error code 23

2024-09-11 Thread duke
On Tue, 10 Sep 2024 12:53:42 GMT, Sergey Chernyshev wrote: > Hi all, > > Please review a clean backport of > [a264435d](https://github.com/openjdk/jfx/commit/a264435dccba6ec386548f76f1ace095d943f4ca) > from the [openjdk/jfx](https://git.openjdk.org/jfx) repository. > > The commit being backp

Re: [jfx21u] RFR: 8331765: Websocket callbacks are not executed after WebKit 617.1 update

2024-09-11 Thread duke
On Tue, 10 Sep 2024 12:39:09 GMT, Sergey Chernyshev wrote: > Hi all, > > Please review a clean backport of > [6a586b66](https://github.com/openjdk/jfx/commit/6a586b662592be3eb81670f0c5ce48061c2fc07c) > from the [openjdk/jfx](https://git.openjdk.org/jfx) repository. > > The commit being backp

Withdrawn: 8290310: ChangeListener events are incorrect or misleading when a nested change occurs

2024-09-09 Thread duke
On Tue, 4 Apr 2023 15:22:48 GMT, John Hendrikx wrote: > This provides and uses a new implementation of `ExpressionHelper`, called > `ListenerManager` with improved semantics. > > # Behavior > > |Listener...|ExpressionHelper|ListenerManager| > |---|---|---| > |Invocation Order|In order they wer

Withdrawn: 8218745: TableView: visual glitch at borders on horizontal scrolling

2024-09-05 Thread duke
On Thu, 23 May 2024 21:51:55 GMT, Marius Hanl wrote: > Alternative PR to https://github.com/openjdk/jfx/pull/1330 which does not > modify the layout of `VirtualFlow`. > > This PR fixes the glitching by removing the code in `NGNode.renderRectClip`, > which made many calculations leading to floa

Re: [jfx23u] RFR: 8337481: File API: file.name contains path instead of name

2024-09-04 Thread duke
On Wed, 4 Sep 2024 12:30:43 GMT, Oliver Schmidtmer wrote: > Clean backport of JDK-8337481 @Schmidor Your change (at version a3db959ad2d9422b1e8da9b75c18a0586a35c0ba) is now ready to be sponsored by a Committer. - PR Comment: https://git.openjdk.org/jfx23u/pull/19#issuecomment-23

Re: RFR: 8339212: gradle downloads x64 binary of SWT on Linux/aarch64 [v2]

2024-09-03 Thread duke
On Thu, 29 Aug 2024 14:43:39 GMT, ANUPAM DEV wrote: >> Hi, >> >> I have updated the name of the SWT.jar that needs to be downloaded during >> the build process for Linux aarch64. >> from: >> IS_LINUX ? "org.eclipse.swt.gtk.linux.x86_64_3.124.200.v20231113-1355" : >> "" >> >> to: >> IS

Re: RFR: 8334124: Rendering issues with CSS "text-shadow" in WebView [v3]

2024-08-31 Thread duke
On Fri, 30 Aug 2024 11:50:54 GMT, Oliver Schmidtmer wrote: >> On a Shadow state update with cleared shadow, the new values were not >> transmitted to the Java GraphicsDecoder > > Oliver Schmidtmer has updated the pull request incrementally with one > additional commit since the last revision: >

Re: RFR: 8337481: File API: file.name contains path instead of name [v3]

2024-08-30 Thread duke
On Fri, 30 Aug 2024 11:34:56 GMT, Oliver Schmidtmer wrote: >> FileSystemJava had no valid implementation for pathFileName since the >> function was renamed from pathGetFileName to pathFileName in the >> FileSystem.h from WebKit > > Oliver Schmidtmer has updated the pull request incrementally wi

Withdrawn: 8242616: Regression: RTL - TextField Cursor Movement Via Keyboard

2024-08-29 Thread duke
On Fri, 25 Aug 2023 11:41:22 GMT, Karthik P K wrote: > The old logic for cursor movement was buggy when both RTL and LTR text was > present in the TextField. Used character BreakIterator instead of finding the > character index using hitTest. > > Added system test to validate the fix. This pu

Withdrawn: 8334593: Adding, removing and then adding a JFXPanel again leads to NullPointerException

2024-08-27 Thread duke
On Fri, 28 Jun 2024 08:49:49 GMT, Prasanta Sadhukhan wrote: > Adding, then removing, and then adding a JFXPanel to the same component in > the Swing scene graph leads to a NullPointerException in GlassScene because > the sceneState is null. > Removing JFXPanel calls JFXPanel.removeNotify which

Re: RFR: 8334900: IOOBE when adding data to a Series of a BarChart that already contains data [v4]

2024-08-14 Thread duke
On Sat, 10 Aug 2024 16:21:11 GMT, Markus Mack wrote: >> This PR is a fix for another IOOBE that I discovered while working on #1476. >> >> The PR simplifies the code for adding a series that already contains data by >> adding the data points one-by-one. >> As far as I can see no attempt was pre

Re: RFR: 8336592: Wrong type in documentation for TreeTableView

2024-07-18 Thread duke
On Wed, 17 Jul 2024 05:53:45 GMT, ANUPAM DEV wrote: > Hello, > > There was a typo in the documentation of TreeTableView. > I have changed TreeTableColumns to TreeTableColumn > > Please review. > > Regards, > Anupam @anupamdev20 Your change (at version 61ae9ca55d73d5b4e72c4e5d414310a1c2b328a2

Withdrawn: 8285893: Hiding dialog and showing new one causes dialog to be frozen

2024-07-18 Thread duke
On Tue, 9 Jan 2024 21:45:33 GMT, Marius Hanl wrote: > This PR fixes the dialog freeze problem once and for all. > > This one is a bit tricky to understand, here is how it works: > This bug happens on every platform, although the implementation of nested > event loops differs on every platform.

Withdrawn: 8273743: KeyCharacterCombination for "+" does not work on US QWERTY keyboard layout

2024-07-16 Thread duke
On Tue, 20 Feb 2024 18:07:43 GMT, Martin Fox wrote: > On Linux getKeyCodeForChar does not consult the current keyboard layout. For > example, it assumes the “+” character is on KeyCode.PLUS even on layouts > which don’t generate KeyCode.PLUS. The result is that most > KeyCharacterCombinations

Re: RFR: 8322619: Parts of SG no longer update during rendering - overlapping - culling - dirty [v6]

2024-07-09 Thread duke
On Thu, 4 Jul 2024 08:06:39 GMT, eduardsdv wrote: >> This is an alternative solution to the PR: >> https://github.com/openjdk/jfx/pull/1310. >> >> This solution is based on the invariant that if a node is marked as dirty, >> all ancestors must also be marked as dirty and that if an ancestor is

Re: RFR: 8198830: BarChart: auto-range of CategoryAxis not working on dynamically setting data [v2]

2024-06-29 Thread duke
On Fri, 28 Jun 2024 07:39:46 GMT, Markus Mack wrote: >> This PR fixes the placement of `BarChart` bars and category tick marks, >> particularly when adding data / multiple series and enabling animations. >> It covers all cases mentioned in the JBS ticket and adds a unit test. >> >> The settable

Re: RFR: 8088923: IOOBE when adding duplicate categories to the BarChart [v5]

2024-06-27 Thread duke
On Sat, 22 Jun 2024 10:55:28 GMT, Markus Mack wrote: >> This PR provides the test case given in the JBS issue, and a simple fix for >> the index calculation when inserting data after previous data with duplicate >> categories. >> >> Also, I've added a comment to `BarChart`s javadoc, clarifying

Re: RFR: 8314754: Minor ticks are not getting updated both the axes in LineChart [v3]

2024-06-27 Thread duke
On Wed, 26 Jun 2024 06:33:43 GMT, Markus Mack wrote: >> This PR ensures the `tickMarksUpdated()` method (overriden with minor tick >> mark layout code in subclasses) is called during `Chart` `Axis` layout when >> needed. >> Previously, it was only called when tick mark length or range was chang

Re: RFR: 8334713: WebKit build failed on LoongArch64 because currentStackPointer is undefined

2024-06-27 Thread duke
On Fri, 21 Jun 2024 09:02:43 GMT, Ao Qi wrote: > This problem has been fixed > [upstream](https://github.com/WebKit/WebKit/pull/23282). This patch merges > the fix in advance. > > Error log: > > > /some_dir/jfx/modules/javafx.web/src/main/native/Source/WTF/wtf/StackPointer.cpp:140:2: > erro

Re: RFR: 8334739: XYChart and (Stacked)AreaChart properties return incorrect beans [v2]

2024-06-27 Thread duke
On Fri, 21 Jun 2024 16:57:38 GMT, Markus Mack wrote: >> This PR makes the `XYChart` axes properties return the correct parent >> XYChart object. > > Markus Mack has updated the pull request incrementally with one additional > commit since the last revision: > > Set correct bean for propertie

Withdrawn: 8327179: Update the 3D lighting application

2024-05-22 Thread duke
On Sun, 3 Mar 2024 22:29:02 GMT, Nir Lisker wrote: > Update for the 3D lighting test tool as described in the JBS issue. This pull request has been closed without being integrated. - PR: https://git.openjdk.org/jfx/pull/1387

Withdrawn: 8299423: JavaFX Mac system menubar leaks

2024-05-08 Thread duke
On Wed, 13 Mar 2024 13:32:32 GMT, Florian Kirmaier wrote: > Based on my previous PR: https://github.com/openjdk/jfx/pull/987 > This one only contains the test. > Because it was fixed in some other PR. > But i would like to see the Test being merged, to ensure it never breaks > again. This pull

Withdrawn: 8296266: TextArea: Navigation breaks with RTL text

2024-04-19 Thread duke
On Tue, 22 Aug 2023 20:46:21 GMT, Andy Goryachev wrote: > The fix uses character BreakIterator instead of the logic that relies on > caretBounds/hitTest/rangeShape in TextInputControl.nextCharacterVisually(). > > I believe this is a more reliable method of navigation, as it behaves in sync > w

Withdrawn: JDK-8218745: TableView: visual glitch at borders on horizontal scrolling

2024-03-08 Thread duke
On Wed, 10 Jan 2024 19:21:16 GMT, Marius Hanl wrote: > This PR fixes the border glitch/gap as explained in both linked tickets. > > I noted that the `ScrollPane` control does not suffer from this problem, > although the code is mostly the same as in `VirtualFlow`. The `ScrollPane` > snaps the

Withdrawn: 8092272: [D3D 3D] Need a robust 3D states management for texture

2024-02-23 Thread duke
On Wed, 8 Nov 2023 22:30:34 GMT, Nir Lisker wrote: > Moves the filter setting of the samplers from the device parameters > configuration to the use-site, allowing for dynamic changes in the sampler. > This PR does internal plumbing work only to bring it close to the ES2 > pipeline. A followup

Withdrawn: 8313650: Add hasProperties method to MenuItem and Toggle

2024-02-22 Thread duke
On Fri, 18 Aug 2023 17:06:57 GMT, Andy Goryachev wrote: > 1. Creating a new `javafx.scene.ContainsProperties` interface that declares > two methods: > - public ObservableMap getProperties(); > - public boolean hasProperties(); > > 2. Node, MenuItem, and Toggle now extend ContainsProperties inte

Withdrawn: 8299753: Tree/TableView: Column Resizing With Fractional Scale

2024-02-06 Thread duke
On Thu, 15 Jun 2023 19:38:00 GMT, Andy Goryachev wrote: > Modified the resize algorithm to work well with fractional scale, thanks for > deeper understanding of the problem thanks to @hjohn and @mstr2 . > > It is important to note that even though the constraints are given by the > user in un

Withdrawn: 8319340: [Linux] Disabled windows should not allow window operations (minimize, resize, maximize, close)

2024-01-31 Thread duke
On Thu, 2 Nov 2023 19:13:58 GMT, Thiago Milczarek Sayao wrote: > JavaFX on Linux is allowing disabled windows to be minimized. > > Currently close does nothing as it should, maximize disappears (on MS Windows > it's greyed out - it's a platform behavior difference) and minimize is being > all

Withdrawn: 8311895: CSS Transitions

2024-01-09 Thread duke
On Tue, 16 Aug 2022 03:01:23 GMT, Michael Strauß wrote: > Implementation of [CSS > Transitions](https://gist.github.com/mstr2/c72f8c9faa87de14926978f517a6018a). > > ### Example > > .button { > -fx-background-color: dodgerblue; > } > > .button:hover { > -fx-background-color: red; >

Withdrawn: 8308644: [Linux] Missing mappings for dead keys + Alt Gr

2023-12-22 Thread duke
On Mon, 22 May 2023 00:19:45 GMT, Thiago Milczarek Sayao wrote: > This PR adds missing key mappings for dead keys and fixes "Alt Gr" for some > systems. This pull request has been closed without being integrated. - PR: https://git.openjdk.org/jfx/pull/1143

Withdrawn: JDK-8290310: ChangeListener events are incorrect or misleading when a nested change occurs

2023-12-12 Thread duke
On Tue, 4 Apr 2023 15:22:48 GMT, John Hendrikx wrote: > This provides and uses a new implementation of `ExpressionHelper`, called > `ListenerManager` with improved semantics. > > # Behavior > > |Listener...|ExpressionHelper|ListenerManager| > |---|---|---| > |Invocation Order|In order they wer

Withdrawn: 8313709: Wrong layout of a FlowPane in a BorderPane in a ScrollPane, if padding is too big

2023-11-30 Thread duke
On Mon, 7 Aug 2023 10:53:06 GMT, Jose Pereda wrote: > So far, BorderPane does the calculation for the children min/pref > width/height taken into account only the margin applied to them, if any, but > not the total padding that could be applied as well to the BorderPane itself. > > However, th

Withdrawn: 8255248: NullPointerException in JFXPanel due to race condition in HostContainer

2023-10-26 Thread duke
On Tue, 18 Jul 2023 06:05:06 GMT, Prasanta Sadhukhan wrote: > Due to transient datatype of scenePeer, it can become null which can result > in NPE in scenarios where scene is continuously been reset and set, which > warrants a null check, as is done in other places for the same variable. This

Withdrawn: 8313556: Create implementation of NSAccessibilitySlider protocol

2023-10-26 Thread duke
On Tue, 29 Aug 2023 10:10:54 GMT, Alexander Zuev wrote: > Create implementation for Slider and Stepper accessibility protocols. > Fix mapping. > Fix performAction parameter type in declaration. This pull request has been closed without being integrated. - PR: https://git.openjdk.or

Withdrawn: 8090267: JFXPanel Input Problem

2023-10-16 Thread duke
On Tue, 4 Jul 2023 05:54:54 GMT, Prasanta Sadhukhan wrote: > When Japanse (IME on) is inputted to the TextFIeld, which is on JFXPanel, > small window for inputting appears on top-left side of screen > > ![image](https://github.com/openjdk/jfx/assets/43534309/65833d59-528e-4087-9992-9f86b8b8c47

Withdrawn: JDK-8187314: All Cells: must show backing data always

2023-10-10 Thread duke
On Fri, 4 Aug 2023 18:13:34 GMT, Marius Hanl wrote: > Before, the `updateItem` method was called with the new value that was > committed via `commitEdit()`. > This is problematic as developers may setup a commit handler via > `setOnEditCommit`, which may reject the edit (or change the value oth

Withdrawn: 8311216: DataURI can lose information in some charset environments

2023-09-04 Thread duke
On Sat, 1 Jul 2023 22:24:09 GMT, Michael Strauß wrote: > DataURI uses the following implementation to decode the percent-encoded > payload of a "data" URI: > > > ... > String data = uri.substring(dataSeparator + 1); > Charset charset = Charset.defaultCharset(); > ... > URLDecoder.decode(data.r

Withdrawn: 8305925: Add concatenated list view

2023-08-24 Thread duke
On Wed, 12 Apr 2023 07:24:08 GMT, Michael Strauß wrote: > The JavaFX collections framework offers the > `FXCollections.concat(ObservableList...)` method, which creates a new > modifiable list that contains a concatenated snapshot of the source lists, > backed by an `ArrayList`. However, when t

Withdrawn: 8304041: [WebView] Text on the left and right of emoji is not visible

2023-08-19 Thread duke
On Thu, 6 Apr 2023 20:00:01 GMT, Phil Race wrote: > This fixes a problem with mixing Emoji and regular text in Webview. > The Prism implementation expects that Emoji will not be in the same call to > drawString as regular glyphs, > since they need very different handling. > This fix breaks up th

Withdrawn: 8307316: Let JavaFX be built on unknown architectures

2023-08-10 Thread duke
On Wed, 3 May 2023 16:02:34 GMT, John Neffenger wrote: > Please review these changes to the Gradle build files and the dependency > verification file. The initial version of this pull request extends the > permitted build platforms for Linux to the Java architectures `arm`, > `ppc64le`, and `s

Withdrawn: 8089373: Translation from character to key code is not sufficient

2023-08-09 Thread duke
On Thu, 4 May 2023 17:18:21 GMT, Martin Fox wrote: > Note: the Java-side changes in this PR are also in #694 which fixes the same > issue (and more) on Linux. Unfortunately the Linux Robot code is not working > making it difficult to test on that platform (see #718). > > KeyCharacterCombinatio

Withdrawn: 8087370: [odroid] Monocle: Touch is still broken on Odroid

2023-08-09 Thread duke
On Wed, 13 Oct 2021 10:52:40 GMT, Fabian Wolter wrote: > There are sometimes multitouch events detected, when only a single touch > should be detected under certain conditions. This lead to touch events on > previous touch positions. > > The referenced bug is closed with "won't fix" with the j

Withdrawn: 8273743: KeyCharacterCombination for "+" does not work on US QWERTY keyboard layout

2023-08-08 Thread duke
On Mon, 13 Dec 2021 19:46:27 GMT, Martin Fox wrote: > The algorithm in `KeyCharacterCombination.match` relies on the call > `Toolkit.getKeyCodeForChar` which is difficult to implement correctly. It > defies the way most keyboard API’s work and no platform has got it right yet. > In particular

Withdrawn: 8278924: [Linux] Robot key test can fail if multiple keyboard layouts are installed

2023-08-07 Thread duke
On Mon, 17 Jan 2022 20:25:08 GMT, Martin Fox wrote: > The Robot implementation on Linux did not consult the current layout when > mapping from a KeyCode to a hardware code. Internally it retrieved results > for all the layouts but just picked the first one it saw leading to random > effects. T

Withdrawn: 8303038: Glass gtk3 sends scroll events with delta(x, y) = 0

2023-08-01 Thread duke
On Wed, 22 Feb 2023 01:11:55 GMT, Thiago Milczarek Sayao wrote: > Simple fix to get the scroll deltas from GDK_SCROLL_SMOOTH. If we ignore this > scroll event type, deltas are sent to java with the value equal to zero. > > Here's whats happening: > > We include all event masks, so when using

Withdrawn: (draf): ChangeListener events are incorrect or misleading when a nested change occurs

2023-07-26 Thread duke
On Sun, 17 Jul 2022 20:59:46 GMT, John Hendrikx wrote: > This contains the following: > - Nested changes or invalidations using ExpressionHelper are delayed until > the current emission completes > - This fixes odd change events being produced (with incorrect oldValue) > - Also fixes a bug i

Withdrawn: 8269907 memory leak - Dirty Nodes / Parent removed

2023-07-24 Thread duke
On Wed, 21 Jul 2021 11:29:38 GMT, Florian Kirmaier wrote: > After thinking about this issue for some time, I've now got a solution. > I know put the scene in the state it is, before is was shown, when the > dirtyNodes are unset, the whole scene is basically considered dirty. > This has the dra

Withdrawn: JDK-8306490: Fix raw type warnings in graphics

2023-07-06 Thread duke
On Tue, 18 Apr 2023 16:17:52 GMT, John Hendrikx wrote: > Focused only on raw type problems, and removing casts that were no longer > needed because of the changes. This pull request has been closed without being integrated. - PR: https://git.openjdk.org/jfx/pull/1095

Withdrawn: 8273485: Deadlock when also using Swing and exiting Fullscreen on Mac

2023-07-04 Thread duke
On Wed, 8 Sep 2021 10:37:40 GMT, Florian Kirmaier wrote: > When using Swing it's possible to generate a Deadlock. > It's related to the nested eventloop started in enterFullScreenExitingLoop - > and the RenderLock aquired when using setView in Scene. > Sample Programm and Threaddump are added

Withdrawn: JDK-8298104: NPE on synchronizeSceneNodes()

2023-06-30 Thread duke
On Wed, 3 May 2023 11:46:50 GMT, Daniel wrote: > A null pointer exception occurs on the ScenePulseListener when iterating > through the dirty node list. > A null check is needed on the node before calling node.getScene(). > > The error occurs occasionally and causes the application to crash. >

Withdrawn: 8282104: Node zoom/rotate flickers on Raspberry Pi with Touchscreen

2023-06-19 Thread duke
On Fri, 18 Feb 2022 17:04:08 GMT, Alexander Scherbatiy wrote: > Zoomed/Rotated with two fingers rectangle flickers (unexpectedly becomes > pretty small or large and then returns back to previous size several times > during zooming/rotating) on a Raspberry Pi with Touchscreen. > > The log with

Withdrawn: 8282703: Axis is not cached in the LinuxTouchTransform class

2023-06-19 Thread duke
On Sat, 5 Mar 2022 15:53:52 GMT, Alexander Scherbatiy wrote: > An axis is not cached in the LinuxTouchTransform class. > > To reproduce the issue I added `System.out.printf("initTransform: axis: %d, > index: %d%n", axis, index);` log to the LinuxTouchTransform.initTransform() > method: > http

Withdrawn: 8282886: Mouse event is generated outside of node on Raspberry Pi with Touchscreen

2023-06-19 Thread duke
On Wed, 9 Mar 2022 17:55:36 GMT, Alexander Scherbatiy wrote: > Tapping on a circle in the center of the screen sometimes generates mouse > click events outside the circle with x coordinates set to zero. > > To reproduce the issue run the > [JFXCircle](https://bugs.openjdk.java.net/secure/atta

Withdrawn: JDK-8304323 Provide infrastructure to make it possible for properties to delay listener registration

2023-06-12 Thread duke
On Sun, 5 Feb 2023 13:07:25 GMT, John Hendrikx wrote: > This PR contains changes to make it easier to implement properties which want > to conserve resources until they're observed themselves. > > `isObserved` is promoted from `ObjectBinding` to the `ObservableValue` > interface, allowing yo

Withdrawn: 8305768: Unify WindowContext in glass-gtk

2023-06-10 Thread duke
On Sat, 8 Apr 2023 00:53:12 GMT, Thiago Milczarek Sayao wrote: > This unifies and organizes WindowContext of the glass-gtk. > > It does not change any behaviour, just reorganizes the code. This pull request has been closed without being integrated. - PR: https://git.openjdk.org/j

Withdrawn: 8252936: Optimize removal of listeners from ExpressionHelper.Generic

2023-06-09 Thread duke
On Thu, 6 Feb 2020 16:13:33 GMT, dannygonzalez wrote: > https://bugs.openjdk.java.net/browse/JDK-8185886 > > Optimisation to ExpressionHelper.Generic class to use Sets rather than Arrays > to improve listener removal speed. > > This was due to the removal of listeners in TableView taking up to

Withdrawn: 8268642: Improve property system to facilitate correct usage

2023-06-09 Thread duke
On Tue, 27 Jul 2021 23:15:10 GMT, Michael Strauß wrote: > Based on previous discussions, this PR attempts to improve the JavaFX > property system by enforcing correct API usage in several cases that are > outlined below. It also streamlines the API by deprecating untyped APIs in > favor of typ

Withdrawn: 8277848 Binding and Unbinding to List leads to memory leak

2023-05-29 Thread duke
On Tue, 7 Dec 2021 14:57:00 GMT, Florian Kirmaier wrote: > Making the initial listener of the ListProperty weak fixes the problem. > The same is fixed for Set and Map. > Due to a smart implementation, this is done without any performance drawback. > (The trick is to have an object, which is both

Withdrawn: 8299423: JavaFX Mac system menubar leaks

2023-05-29 Thread duke
On Fri, 30 Dec 2022 09:41:46 GMT, Florian Kirmaier wrote: > This PR fixes the leak in the mac system menu bar. > > Inside the native code, NewGlobalRef is called for the callable. > Which makes it into a "GC-Root" until DeleteGlobalRef is called. > > The DeleteGlobalRef is never called for the

Withdrawn: JDK-8269921 Text in Textflow and listeners on bounds can cause endless loop/crash and other performance issues

2023-05-27 Thread duke
On Tue, 6 Jul 2021 14:53:24 GMT, Florian Kirmaier wrote: > It's "a bit" complicated. > In some situations, getRuns get's called because listeners on bounds are set. > This causes TextFlow to layout to compute the runs. > Afterward, the bounds of the parents get updated. > This triggers a call to

Withdrawn: 8278021: Fix warnings in macOS glass native code and treat warnings as errors

2023-05-27 Thread duke
On Wed, 1 Dec 2021 17:44:21 GMT, Martin Fox wrote: > Turning on warnings-as-errors for the macOS glass native code. Deprecated > declarations are excluded and still appear as warnings. > > In the code that tries to locate the application's dock icon there were three > instances where `NO` was

Withdrawn: JDK-8298060: Fix precision bug in gesture recognizer classes

2023-05-27 Thread duke
On Sat, 3 Dec 2022 22:17:55 GMT, John Hendrikx wrote: > This includes a fix for the precision problem we've found as part of the > graphics warnings clean ups. > > I've included two commits, one with just the minimal fix, and one with the > clean ups. I can drop off the 2nd commit if it is dee

Withdrawn: 8218745: TableView: visual glitch at borders on horizontal scrolling

2023-05-26 Thread duke
On Thu, 23 Sep 2021 19:01:52 GMT, Marius Hanl wrote: > This PR fixes an issue which is probably in JavaFX since VirtualFlow exists. > While horizontal scrolling any VirtualFlow control the left blue border > sometimes disappear/gets smaller. (see also image below) > > This can be fixed by **sna

Withdrawn: 8267546: Add CSS themes as a first-class concept

2023-05-26 Thread duke
On Fri, 21 May 2021 04:30:28 GMT, Michael Strauß wrote: > This PR adds style themes as a first-class concept to OpenJFX. A style theme > is a collection of stylesheets and the logic that governs them. Style themes > can respond to OS notifications and update their stylesheets dynamically. > Th

Withdrawn: 8273743: KeyCharacterCombination for "+" does not work on US QWERTY keyboard layout

2023-05-26 Thread duke
On Tue, 28 Sep 2021 21:01:13 GMT, Martin Fox wrote: > There was a mismatch between the way `get_glass_key` generated the Java key > code for a given key press and how `getKeyCodeForChar` determined the key > code for the matching character. For example, when pressing the plus sign on > a US ke

Withdrawn: 8274967: KeyCharacterCombinations for punctuation and symbols fail on non-US keyboards

2023-05-26 Thread duke
On Mon, 15 Nov 2021 20:13:11 GMT, Martin Fox wrote: > The code that maps from a Windows virtual key code to a Java key code in > `getKeyCodeForChar` did not match the similar code in > `ViewContainer::HandleViewKeyEvent`. The OEM keys are assigned to printable > punctuation and symbols in ways

Withdrawn: 8090522: Allow support for disabling stage iconification (minimization)

2023-05-26 Thread duke
On Thu, 19 May 2022 12:44:44 GMT, Paweł Kruszczyński wrote: > `Stage` minimalizing (iconified state) cannot be disabled for the user. The > same for `Stage` closable state. > PR adds these features without breaking backward compatibility. This pull request has been closed without being integrat

Withdrawn: 8290274: DRT 27 tests fail due to xml not well formed error on window

2023-05-26 Thread duke
On Wed, 10 Aug 2022 10:06:21 GMT, Jay Bhaskar wrote: > Issue: xml not well-formed error occurs at XML document parser. > Issue: doEnd() call not needed for JAVA platform, as it is making > XMLDocumentParserLibxml2 xml not well-formed error. This pull request has been closed without being integr

Withdrawn: 8299348: Size-restricted window can be observed with incorrect dimensions

2023-05-04 Thread duke
On Mon, 26 Dec 2022 03:03:50 GMT, Michael Strauß wrote: > On Windows, a `Stage` that is restricted by minimum and maximum sizes can > briefly be observed to appear with incorrect dimensions when it is first > shown. The root cause of this bug is that the native `WinWindow._setBounds` > method

Withdrawn: 8185887: TableRowSkinBase fails to correctly virtualize cells in horizontal direction

2023-04-28 Thread duke
On Mon, 24 Feb 2020 07:39:43 GMT, yosbits wrote: > If there are many columns, the current TableView will stall scrolling. > Resolving this performance issue requires column virtualization. > Virtualization mode is enabled when the row height is fixed by the following > method. > > `tableView.

Withdrawn: 8253086: Optimization of removeAll and retainAll of ObservableListWrapper

2023-04-28 Thread duke
On Mon, 14 Sep 2020 09:57:26 GMT, yosbits wrote: > https://bugs.openjdk.java.net/browse/JDK-8253086 > > ObservableListWrapper.java > * public boolean removeAll(Collection c) > * public boolean retainAll(Collection c) > > These two methods use BitSet, but it doesn't make sense. > By rewriting t

Withdrawn: 8255572: Axis does not compute preferred height properly when autoRanging is off

2023-04-28 Thread duke
On Thu, 29 Oct 2020 15:15:22 GMT, Jonathan Vusich wrote: > As noted in the corresponding JBS issue, `Axis` does not properly compute its > preferred height when `autoRanging` is turned off. The simplest fix seems to > be changing `CategoryAxis` so that `tickLabelRotation` is set to 90 degrees

Withdrawn: 8090110: Very bad TextArea of performance in a language environment that uses the Chinese character (KANJI)

2023-04-28 Thread duke
On Wed, 23 Sep 2020 15:41:43 GMT, yosbits wrote: > * https://bugs.openjdk.java.net/browse/JDK-8090110 > * https://bugs.openjdk.java.net/browse/JDK-8089418 > > TextArea slows down as the number of characters increases. This problem can > be greatly improved by setting the clip of the display are

Withdrawn: 8230231: font-family not updated in HTMLEditor

2023-04-28 Thread duke
On Wed, 9 Oct 2019 13:05:22 GMT, Hadzic Samir wrote: > Fix for https://github.com/javafxports/openjdk-jfx/issues/573 > > Issue on JBS bug tracking : https://bugs.openjdk.java.net/browse/JDK-8230231 > > Fix: Check for quote when updating the font-family comboBox. > > A new font is added as a re

Withdrawn: 8262023: Scrolled button is pressed using Monocle on Raspberry Pi with Touchscreen

2023-04-28 Thread duke
On Fri, 19 Feb 2021 14:19:35 GMT, Alexander Scherbatiy wrote: > The issue is reproduced on Raspberry Pi 3 B+ with Touchscreen display. > > To reproduce the issue run the > [ScrollPaneSample](https://bugs.openjdk.java.net/secure/attachment/93270/ScrollPaneSample.java) > with Monocle: >> sudo j

Withdrawn: 8261221: Tooltip bigger than screen size blinks - shows and hides over and over again

2023-04-28 Thread duke
On Fri, 5 Feb 2021 10:46:49 GMT, Paweł Kruszczyński wrote: > `Tooltip` is no longer hiding upon receiving > `MouseEvent.MOUSE_ENTERED_TARGET` event inside it. Pressing mouse on > overlaying tooltip also kills the tooltip, so the infinite duration tooltip > can be closed. This pull request has

Withdrawn: [WIP]8267425: Intermittent failure of HonorDeveloperSettingsTest unit test

2023-04-28 Thread duke
On Thu, 20 May 2021 07:18:28 GMT, Ambarish Rapte wrote: > The same failure was earlier fixed at PR #496, which seems insufficient. > The changes in this PR were also tried ealier in the PR #496 but later > removed, as they seemed not necessary. > Fix is to clean up the test, by removing all chil

Withdrawn: 8286867: Update #getGlyphCode return a negative number

2023-04-28 Thread duke
On Fri, 13 May 2022 05:34:08 GMT, Tomator wrote: > When I used BlueJ, I found a problem with Chinese display. > /javafx.graphics/com/sun/javafx/font/CompositeGlyphMapper.java#getGlyphCode > may return a negative number when no font library is specified in Linux,and > this could cause java.lang

Withdrawn: 8295078: TextField blurry when inside an TitledPane -> AnchorPane

2023-04-28 Thread duke
On Tue, 11 Oct 2022 09:05:34 GMT, Marius Hanl wrote: > The problem here is, that the `AnchorPane` does not use its snapped insets. > Therefore, the fix is to replace all `getInsets().getXXX` calls with their > corresponding `snappedXXXInset()` methods. > > Note: The reason the `AnchorPane` insi

Withdrawn: 8290037: Bindings should clean up after themselves when their weak listeners go out of scope

2023-04-28 Thread duke
On Thu, 14 Jul 2022 14:48:14 GMT, John Hendrikx wrote: > This is an initial (incomplete) implementation of 8290037 for evaluation. > > If the approach is agreed, I will modify the rest of the `*PropertyBase` > classes which use weak listeners, and add some tests. > > I didn't use `Cleaner` bec