On Tue, 23 Aug 2022 16:34:59 GMT, Nir Lisker wrote:
>> Fixes the mistakes in the JBS ticket and some additional minor corrections.
>
> Nir Lisker has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Addressed review comment
Marked as reviewed
On Tue, 23 Aug 2022 15:36:35 GMT, Nir Lisker wrote:
>> Fixes the mistakes in the JBS ticket and some additional minor corrections.
>
> Nir Lisker has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Addressed review comments
Looks good with
> Fixes the mistakes in the JBS ticket and some additional minor corrections.
Nir Lisker has updated the pull request incrementally with one additional
commit since the last revision:
Addressed review comment
-
Changes:
- all: https://git.openjdk.org/jfx/pull/880/files
-
On Tue, 23 Aug 2022 15:36:35 GMT, Nir Lisker wrote:
>> Fixes the mistakes in the JBS ticket and some additional minor corrections.
>
> Nir Lisker has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Addressed review comments
> When looking at
On Tue, 23 Aug 2022 15:36:35 GMT, Nir Lisker wrote:
>> Fixes the mistakes in the JBS ticket and some additional minor corrections.
>
> Nir Lisker has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Addressed review comments
When looking at
> Fixes the mistakes in the JBS ticket and some additional minor corrections.
Nir Lisker has updated the pull request incrementally with one additional
commit since the last revision:
Addressed review comments
-
Changes:
- all: https://git.openjdk.org/jfx/pull/880/files
-
On Tue, 23 Aug 2022 11:37:38 GMT, Nir Lisker wrote:
>> modules/javafx.graphics/src/main/java/javafx/concurrent/ScheduledService.java
>> line 130:
>>
>>> 128: * will treat that duration as if it were Duration.ZERO. Likewise, any
>>> Duration which answers true
>>> 129: * to {@link
On Tue, 23 Aug 2022 11:46:47 GMT, Nir Lisker wrote:
>> Fixes the mistakes in the JBS ticket and some additional minor corrections.
>
> Nir Lisker has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Addressed review comments
> Fixes the mistakes in the JBS ticket and some additional minor corrections.
Nir Lisker has updated the pull request incrementally with one additional
commit since the last revision:
Addressed review comments
-
Changes:
- all: https://git.openjdk.org/jfx/pull/880/files
-
On Mon, 22 Aug 2022 22:21:29 GMT, Kevin Rushforth wrote:
>> Nir Lisker has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix typo
>
> modules/javafx.graphics/src/main/java/javafx/concurrent/ScheduledService.java
> line 130:
>
>> 128: *
On Fri, 19 Aug 2022 00:37:34 GMT, Nir Lisker wrote:
>> Fixes the mistakes in the JBS ticket and some additional minor corrections.
>
> Nir Lisker has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Fix typo
A few comments inline.
On Fri, 19 Aug 2022 00:37:34 GMT, Nir Lisker wrote:
>> Fixes the mistakes in the JBS ticket and some additional minor corrections.
>
> Nir Lisker has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Fix typo
I took a quick look and don't see
On Fri, 19 Aug 2022 14:54:11 GMT, Andy Goryachev wrote:
> Would these changes require a CSR? Or, since they are just corrections, the
> API did not really change? Otherwise, looks good. Thank you for cleaning up
> the docs!
Usually they don't since there are no spec changes.
-
On Fri, 19 Aug 2022 00:37:34 GMT, Nir Lisker wrote:
>> Fixes the mistakes in the JBS ticket and some additional minor corrections.
>
> Nir Lisker has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Fix typo
Would these changes require a CSR?
On Thu, 18 Aug 2022 23:50:03 GMT, Nir Lisker wrote:
> ```
> fatal: ambiguous argument 'upstream/jfx19': unknown revision or path not in
> the working tree.
> ```
I should have said "presuming you have a remote configured with the name
`upstream`". Anyway, what you did was good.
-
> Fixes the mistakes in the JBS ticket and some additional minor corrections.
Nir Lisker has updated the pull request incrementally with one additional
commit since the last revision:
Fix typo
-
Changes:
- all: https://git.openjdk.org/jfx/pull/880/files
- new:
On Thu, 18 Aug 2022 23:52:48 GMT, Nir Lisker wrote:
> Fixes the mistakes in the JBS ticket and some additional minor corrections.
modules/javafx.base/src/main/java/javafx/beans/property/Property.java line 102:
> 100: *
> 101: *
> 102: *
Fixes the mistakes in the JBS ticket and some additional minor corrections.
-
Commit messages:
- Initial commit
Changes: https://git.openjdk.org/jfx/pull/880/files
Webrev: https://webrevs.openjdk.org/?repo=jfx=880=00
Issue: https://bugs.openjdk.org/browse/JDK-8286678
Stats: 30
On Thu, 18 Aug 2022 23:43:33 GMT, Nir Lisker wrote:
>> Fixes the mistakes in the JBS ticket and some additional minor corrections.
>
> Nir Lisker has refreshed the contents of this pull request, and previous
> commits have been removed. The incremental views will show differences
> compared to
On Thu, 18 Aug 2022 23:43:33 GMT, Nir Lisker wrote:
>> Fixes the mistakes in the JBS ticket and some additional minor corrections.
>
> Nir Lisker has refreshed the contents of this pull request, and previous
> commits have been removed. Incremental views are not available.
`git reset --hard
> Fixes the mistakes in the JBS ticket and some additional minor corrections.
Nir Lisker has refreshed the contents of this pull request, and previous
commits have been removed. The incremental views will show differences compared
to the previous content of the PR. The pull request contains one
On Thu, 18 Aug 2022 23:19:49 GMT, Nir Lisker wrote:
>> Fixes the mistakes in the JBS ticket and some additional minor corrections.
>
> Nir Lisker has refreshed the contents of this pull request, and previous
> commits have been removed. The incremental views will show differences
> compared to
On Thu, 18 Aug 2022 23:19:49 GMT, Nir Lisker wrote:
>> Fixes the mistakes in the JBS ticket and some additional minor corrections.
>
> Nir Lisker has refreshed the contents of this pull request, and previous
> commits have been removed. The incremental views will show differences
> compared to
On Thu, 18 Aug 2022 19:08:19 GMT, Nir Lisker wrote:
> Fixes the mistakes in the JBS ticket and some additional minor corrections.
Looks like the rebase missed a few commits. Not sure why.
-
PR: https://git.openjdk.org/jfx/pull/877
> Fixes the mistakes in the JBS ticket and some additional minor corrections.
Nir Lisker has refreshed the contents of this pull request, and previous
commits have been removed. The incremental views will show differences compared
to the previous content of the PR. The pull request contains 16
On Thu, 18 Aug 2022 19:08:19 GMT, Nir Lisker wrote:
> Fixes the mistakes in the JBS ticket and some additional minor corrections.
I'll review it.
@arapte or @aghaisas Can one of you be the second reviewer?
-
PR: https://git.openjdk.org/jfx/pull/877
On Thu, 18 Aug 2022 22:40:09 GMT, Nir Lisker wrote:
> It's a PR against the javafx19 branch. I think I forked the master branch
> though, which is why it is showing all the commits.
Yeah, this is a fairly easy mistake to make. It's also very obvious when it
happens.
> I might need to rebase,
On Thu, 18 Aug 2022 19:08:19 GMT, Nir Lisker wrote:
> Fixes the mistakes in the JBS ticket and some additional minor corrections.
you probably need to rebase. impossible to review.
-
PR: https://git.openjdk.org/jfx/pull/877
On Thu, 18 Aug 2022 19:08:19 GMT, Nir Lisker wrote:
> Fixes the mistakes in the JBS ticket and some additional minor corrections.
It's a PR against the javafx19 branch. I think I forked the master branch
though, which is why it is showing all the commits. I might need to rebase, but
if the
On Thu, 18 Aug 2022 19:08:19 GMT, Nir Lisker wrote:
> Fixes the mistakes in the JBS ticket and some additional minor corrections.
Nir, have you sync'ed your branch with the latest master? There are 5000+
files changed listed.
-
PR: https://git.openjdk.org/jfx/pull/877
30 matches
Mail list logo
