Re: RFR: 8276170: Create Sources when publishing to Maven

2022-12-04 Thread Michael Paus
On Sun, 4 Dec 2022 20:10:29 GMT, Johan Vos wrote: > We're now using the github issue tracker to discuss reproducible builds, > which is probably not the primary reason Github issues were created, so I > think it's better to start this discussion on a mail thread :) Or maybe use

Re: RFR: 8276170: Create Sources when publishing to Maven

2022-12-04 Thread Johan Vos
On Fri, 29 Oct 2021 12:36:13 GMT, eduardsdv wrote: > Create sources.jars and attach they to the publish task, so that they can be > uploaded to the (e.g. maven) repository automatically. We're now using the github issue tracker to discuss reproducible builds, which is probably not the primary

Re: RFR: 8276170: Create Sources when publishing to Maven

2022-12-03 Thread John Neffenger
On Fri, 2 Dec 2022 15:52:59 GMT, Johan Vos wrote: > I personally would like to have an approach similar to OpenJDK, which is more > Makefile based and deals with module/platform/architecture specific things in > a cleaner way. Me too! I thought I was alone in wanting to move to Makefiles. The

Re: RFR: 8276170: Create Sources when publishing to Maven

2022-12-02 Thread eduardsdv
On Fri, 29 Oct 2021 12:36:13 GMT, eduardsdv wrote: > Create sources.jars and attach they to the publish task, so that they can be > uploaded to the (e.g. maven) repository automatically. Thanks for the clarification and I totally comprehend your point of view. The build file is really big. It

Re: RFR: 8276170: Create Sources when publishing to Maven

2022-12-02 Thread Johan Vos
On Fri, 29 Oct 2021 12:36:13 GMT, eduardsdv wrote: > Create sources.jars and attach they to the publish task, so that they can be > uploaded to the (e.g. maven) repository automatically. I think there is some confusion, so let me clarify. My intention was never to remove or stop building the

Re: RFR: 8276170: Create Sources when publishing to Maven

2022-12-02 Thread Florian Kirmaier
On Fri, 29 Oct 2021 12:36:13 GMT, eduardsdv wrote: > Create sources.jars and attach they to the publish task, so that they can be > uploaded to the (e.g. maven) repository automatically. Honestly, the idea of removing the Maven build horrifies me. This would basically force me (and probably

Re: RFR: 8276170: Create Sources when publishing to Maven

2022-12-01 Thread Kevin Rushforth
On Fri, 29 Oct 2021 12:36:13 GMT, eduardsdv wrote: > Create sources.jars and attach they to the publish task, so that they can be > uploaded to the (e.g. maven) repository automatically. In this case, there was no agreement that we should add this capability. As @johanvos said in [this

Re: RFR: 8276170: Create Sources when publishing to Maven

2022-12-01 Thread Nir Lisker
On Fri, 29 Oct 2021 12:36:13 GMT, eduardsdv wrote: > Create sources.jars and attach they to the publish task, so that they can be > uploaded to the (e.g. maven) repository automatically. It requires only 1 reviewer with the tole of Reviewer. One of you can be the second reviewer.

Re: RFR: 8276170: Create Sources when publishing to Maven

2022-12-01 Thread Florian Kirmaier
On Fri, 29 Oct 2021 12:36:13 GMT, eduardsdv wrote: > Create sources.jars and attach they to the publish task, so that they can be > uploaded to the (e.g. maven) repository automatically. I'm actually using it for my builds ... But sadly I'm not a reviewer. - PR:

Re: RFR: 8276170: Create Sources when publishing to Maven

2022-12-01 Thread Michael Paus
On Fri, 29 Oct 2021 12:36:13 GMT, eduardsdv wrote: > Create sources.jars and attach they to the publish task, so that they can be > uploaded to the (e.g. maven) repository automatically. It's a pitty that this review was never completed. Very demotivating. - PR:

Re: RFR: 8276170: Create Sources when publishing to Maven

2022-12-01 Thread eduardsdv
On Fri, 29 Oct 2021 12:36:13 GMT, eduardsdv wrote: > Create sources.jars and attach they to the publish task, so that they can be > uploaded to the (e.g. maven) repository automatically. It seems that no one needs it, so I am closing this PR. - PR: