Re: RFR: 8290473: update Eclipse .classpath in apps, buildSrc [v2]

2022-08-08 Thread Andy Goryachev
On Mon, 8 Aug 2022 15:31:49 GMT, Nir Lisker wrote: >> @kevinrushforth : >> Eclipse does not support conditionals in the .classpath files. The warning >> cannot be turned off. I see no other way but to create empty folders. > > On Linux there is no such warning., neither is there on Windows

Re: RFR: 8290473: update Eclipse .classpath in apps, buildSrc [v2]

2022-08-08 Thread Nir Lisker
On Mon, 8 Aug 2022 15:21:58 GMT, Andy Goryachev wrote: >> I agree that an optional dependency for a platform-specific generated source >> directory is a much better solution than creating an empty dir. > > @kevinrushforth : > Eclipse does not support conditionals in the .classpath files. The

Re: RFR: 8290473: update Eclipse .classpath in apps, buildSrc [v2]

2022-08-08 Thread Andy Goryachev
On Sat, 6 Aug 2022 13:33:09 GMT, Nir Lisker wrote: >> I agree that an optional dependency for a platform-specific generated source >> directory is a much better solution than creating an empty dir. > > I don't know what the platform-specific ones are for Mac. I can check on > Linux if there's

Re: RFR: 8290473: update Eclipse .classpath in apps, buildSrc [v2]

2022-08-08 Thread Andy Goryachev
On Sat, 6 Aug 2022 13:22:17 GMT, Kevin Rushforth wrote: >> As @kleopatra noted below, you need to add the hlsl folders that are built >> on Windows. Add them as an optional source to avoid errors on other OS's: >> >> >> >> >> >> >> >> And the same for >> `` >>

Re: RFR: 8290473: update Eclipse .classpath in apps, buildSrc [v2]

2022-08-06 Thread Nir Lisker
On Sat, 6 Aug 2022 13:22:17 GMT, Kevin Rushforth wrote: >> As @kleopatra noted below, you need to add the hlsl folders that are built >> on Windows. Add them as an optional source to avoid errors on other OS's: >> >> >> >> >> >> >> >> And the same for >> `` >>

Re: RFR: 8290473: update Eclipse .classpath in apps, buildSrc [v2]

2022-08-06 Thread Kevin Rushforth
On Fri, 5 Aug 2022 18:55:15 GMT, Kevin Rushforth wrote: >> thank you for checking! >> >> it looks like there is no way around creating these directories before the >> 'sdk' task in build.gradle, to silence the missing path warning in eclipse >> (and adding them back to the .classpath) >> >>

Re: RFR: 8290473: update Eclipse .classpath in apps, buildSrc [v2]

2022-08-06 Thread Kevin Rushforth
On Sat, 6 Aug 2022 02:28:27 GMT, Nir Lisker wrote: >> As with any multi-stage project, we need to run 'gradle sdk' (or perhaps >> 'gradle sdk apps' for good measure) to build these directories. Then, in >> Eclipse, clean all projects. These steps produce a working configuration. >> >> I do

Re: RFR: 8290473: update Eclipse .classpath in apps, buildSrc [v2]

2022-08-05 Thread Nir Lisker
On Mon, 1 Aug 2022 19:34:11 GMT, Andy Goryachev wrote: >> buildSrc/.classpath line 10: >> >>> 8: >> path="../build/libs/antlr-runtime-3.1.3.jar"/> >>> 9: >> path="../build/libs/stringtemplate-3.2.jar"/> >>> 10: >> path="../build/libs/swt-debug.jar"/> >> >> Why does buildSrc need to be a

Re: RFR: 8290473: update Eclipse .classpath in apps, buildSrc [v2]

2022-08-05 Thread Nir Lisker
On Mon, 1 Aug 2022 19:30:28 GMT, Andy Goryachev wrote: >> modules/javafx.graphics/.classpath line 5: >> >>> 3: >>> 4: >>> 5: >> >> How do you not get errors on these on Mac/Linux if they are not declared >> optional? >> >> Additionally, you need the hlsl folders as shown in the mailing

Re: RFR: 8290473: update Eclipse .classpath in apps, buildSrc [v2]

2022-08-05 Thread Kevin Rushforth
On Fri, 5 Aug 2022 18:25:50 GMT, Andy Goryachev wrote: > i was thinking of merely creating these two dirs in a new task 'initDirs' and > make 'sdk' depend on that task, in the top level build.gradle. Any objections I suppose that would be OK. I presume you'll check that the presence of the

Re: RFR: 8290473: update Eclipse .classpath in apps, buildSrc [v2]

2022-08-05 Thread Andy Goryachev
On Fri, 5 Aug 2022 12:01:27 GMT, Jeanette Winzenburg wrote: >> hmm .. that's indeed weird - here (on win) both graphics/build/hlsl/Prism >> and graphics/build/hlsl/Decora are created by running ./gradlew sdk ... >> will re-check > > did re-check (added your fork as remote, checkout this

Re: RFR: 8290473: update Eclipse .classpath in apps, buildSrc [v2]

2022-08-05 Thread Jeanette Winzenburg
On Fri, 5 Aug 2022 11:02:50 GMT, Jeanette Winzenburg wrote: >> This is puzzling, @kleopatra . >> I don't see a reference to [hlsl/]Prism or [hlsl/]Decora anywhere. Not in >> any gradle.build file, not in every file. I don't think these two >> directories are being built, though I can only

Re: RFR: 8290473: update Eclipse .classpath in apps, buildSrc [v2]

2022-08-05 Thread Jeanette Winzenburg
On Thu, 4 Aug 2022 17:07:53 GMT, Andy Goryachev wrote: >> the tests are fine - it happens if I have a separate project and let that >> depend on the controls, basic, graphics projects (just the same setup as >> described on the mailinglist) > > This is puzzling, @kleopatra . > I don't see a

Re: RFR: 8290473: update Eclipse .classpath in apps, buildSrc [v2]

2022-08-04 Thread Andy Goryachev
> The goal of this change is to make sure jfx repo can be imported as a gradle > project in eclipse and all nested projects in the workspace compile with no > errors. > > - updated .classpath entries in apps/ > - added utf-8 prefs in .settings/ Andy Goryachev has updated the pull request with