Re: RFR: 8301900: TextArea: Committing text with ENTER in an IME window inserts newline [v3]

2024-02-23 Thread Kevin Rushforth
On Fri, 2 Feb 2024 18:43:19 GMT, Martin Fox wrote: >> In the Mac glass code the presence of "marked" text (which is tracked in the >> nsAttrBuffer) signals that an IME is active. In this state the current code >> assumes that when NSTextInputContext handles a `keyDown:` it will either >>

Re: RFR: 8301900: TextArea: Committing text with ENTER in an IME window inserts newline [v3]

2024-02-05 Thread Andy Goryachev
On Fri, 2 Feb 2024 18:43:19 GMT, Martin Fox wrote: >> In the Mac glass code the presence of "marked" text (which is tracked in the >> nsAttrBuffer) signals that an IME is active. In this state the current code >> assumes that when NSTextInputContext handles a `keyDown:` it will either >>

Re: RFR: 8301900: TextArea: Committing text with ENTER in an IME window inserts newline [v3]

2024-02-02 Thread Martin Fox
On Fri, 2 Feb 2024 18:43:19 GMT, Martin Fox wrote: >> In the Mac glass code the presence of "marked" text (which is tracked in the >> nsAttrBuffer) signals that an IME is active. In this state the current code >> assumes that when NSTextInputContext handles a `keyDown:` it will either >>

Re: RFR: 8301900: TextArea: Committing text with ENTER in an IME window inserts newline [v3]

2024-02-02 Thread Martin Fox
> In the Mac glass code the presence of "marked" text (which is tracked in the > nsAttrBuffer) signals that an IME is active. In this state the current code > assumes that when NSTextInputContext handles a `keyDown:` it will either > generate a call to `insertText:replacementRange:` or one of