On Thu, 22 Feb 2024 22:28:40 GMT, Nir Lisker wrote:
>> Overhaul to the `PhongMaterial` documentation (and a bit to its superclass
>> `Material`). Except for the introduction, I divided the documentation into 3
>> sections: qualitative explanation, mathematical model (I wouldn't think it
>>
On Thu, 22 Feb 2024 23:11:55 GMT, Nir Lisker wrote:
>> The only thing I can point at is the OCA (which is linked in the CONTRIBUTOR
>> guidelines), which states that contributions need to be an original work.
>>
>> So to double-check: Aside from that image (and the ones derived from it),
>>
On Thu, 22 Feb 2024 23:04:50 GMT, Nir Lisker wrote:
>> StringJoiner seems to provide little benefit for maps or key=value pairs.
>> Do you know of an alternative?
>
> A `StringJoiner` seems suitable to me in this case:
>
> new StringJoiner(",", "PhongMaterial[", "]")
>
On Thu, 22 Feb 2024 23:07:21 GMT, Kevin Rushforth wrote:
>> Perhaps the contribution guidelines should mention what resources can be
>> included. In all other open source projects I worked on it was enough that
>> the resource wasn't licensed (or had something like
>>
On Thu, 22 Feb 2024 22:51:56 GMT, Nir Lisker wrote:
>> sorry, Nir. ;-)
>
> Perhaps the contribution guidelines should mention what resources can be
> included. In all other open source projects I worked on it was enough that
> the resource wasn't licensed (or had something like
>
On Thu, 22 Feb 2024 22:50:06 GMT, Andy Goryachev wrote:
>>> also, the first `+` is unnecessary
>>
>> I think it was done for uniformity with the other properties. I would use a
>> `StringJoiner` these days for such a task anyway.
>
> StringJoiner seems to provide little benefit for maps or
On Thu, 22 Feb 2024 22:44:05 GMT, Nir Lisker wrote:
>> Weird, I specifically reverted the auto-formatting, not sure how it got in.
>> Will revert.
>
>> also, the first `+` is unnecessary
>
> I think it was done for uniformity with the other properties. I would use a
> `StringJoiner` these
On Thu, 22 Feb 2024 22:42:18 GMT, Andy Goryachev wrote:
>> OK, it will be after the weekend when I can come back to this. Reviewers can
>> assume that only the background will change.
>
> sorry, Nir. ;-)
Perhaps the contribution guidelines should mention what resources can be
included. In
On Thu, 22 Feb 2024 22:20:56 GMT, Nir Lisker wrote:
>> modules/javafx.graphics/src/main/java/javafx/scene/paint/PhongMaterial.java
>> line 848:
>>
>>> 846: + ", specularPower=" + getSpecularPower() + ",
>>> diffuseMap=" + getDiffuseMap() + ", specularMap="
>>> 847:
On Thu, 22 Feb 2024 22:40:59 GMT, Nir Lisker wrote:
>> All of them, since they were derived from the original. I can still tell
>> what the source is.
>
> OK, it will be after the weekend when I can come back to this. Reviewers can
> assume that only the background will change.
sorry, Nir.
On Thu, 22 Feb 2024 22:36:06 GMT, Kevin Rushforth wrote:
>> Do I only need to switch the ones in the introduction that show the
>> multiplication of the color and the map, or all of the new images that use
>> it as a background? The latter will be a lot of work.
>
> All of them, since they
On Thu, 22 Feb 2024 22:31:59 GMT, Nir Lisker wrote:
>> To add to this, such approval would be unlikely, and I am not in favor of
>> making the request. Perhaps you can find suitable images already in the
>> repo? Here is one that might work:
>>
>>
On Thu, 22 Feb 2024 22:21:49 GMT, Kevin Rushforth wrote:
>> What would an approval require?
>
> To add to this, such approval would be unlikely, and I am not in favor of
> making the request. Perhaps you can find suitable images already in the repo?
> Here is one that might work:
>
>
> Overhaul to the `PhongMaterial` documentation (and a bit to its superclass
> `Material`). Except for the introduction, I divided the documentation into 3
> sections: qualitative explanation, mathematical model (I wouldn't think it
> necessary, but the current doc explains it), and examples.
>
14 matches
Mail list logo
