On Tue, 21 Nov 2023 21:11:43 GMT, Nir Lisker wrote:
> Deprecating for removal `getDateFormat()` in `TimeStringConverter` and
> `DateStringConverter` after it was removed already in
> `DateTimeStringConverter`, and `getNumberFormat()` in `NumberStringConverter`
> (and subclasses).
Marked as
On Tue, 21 Nov 2023 21:11:43 GMT, Nir Lisker wrote:
> Deprecating for removal `getDateFormat()` in `TimeStringConverter` and
> `DateStringConverter` after it was removed already in
> `DateTimeStringConverter`, and `getNumberFormat()` in `NumberStringConverter`
> (and subclasses).
> > Will
On Tue, 21 Nov 2023 21:11:43 GMT, Nir Lisker wrote:
> Deprecating for removal `getDateFormat()` in `TimeStringConverter` and
> `DateStringConverter` after it was removed already in
> `DateTimeStringConverter`, and `getNumberFormat()` in `NumberStringConverter`
> (and subclasses).
Marked as
On Tue, 21 Nov 2023 23:19:56 GMT, Andy Goryachev wrote:
> It's just weird - allowing core classes to override yet denying this freedom
> to the app dev.
I don't think these classes should have existed. They don't add any
functionality and could have been specialized constant implementations.
On Tue, 21 Nov 2023 23:36:56 GMT, Nir Lisker wrote:
> Saves upkeeping 2 copies.
this should be a standard operating procedure, in my opinion.
-
PR Comment: https://git.openjdk.org/jfx/pull/1294#issuecomment-1821864861
On Tue, 21 Nov 2023 21:11:43 GMT, Nir Lisker wrote:
> Deprecating for removal `getDateFormat()` in `TimeStringConverter` and
> `DateStringConverter` after it was removed already in
> `DateTimeStringConverter`, and `getNumberFormat()` in `NumberStringConverter`
> (and subclasses).
CSR is
On Tue, 21 Nov 2023 21:11:43 GMT, Nir Lisker wrote:
> Deprecating for removal `getDateFormat()` in `TimeStringConverter` and
> `DateStringConverter` after it was removed already in
> `DateTimeStringConverter`, and `getNumberFormat()` in `NumberStringConverter`
> (and subclasses).
Is the
On Tue, 21 Nov 2023 21:11:43 GMT, Nir Lisker wrote:
> Deprecating for removal `getDateFormat()` in `TimeStringConverter` and
> `DateStringConverter` after it was removed already in
> `DateTimeStringConverter`, and `getNumberFormat()` in `NumberStringConverter`
> (and subclasses).
so the app
On Tue, 21 Nov 2023 21:11:43 GMT, Nir Lisker wrote:
> Deprecating for removal `getDateFormat()` in `TimeStringConverter` and
> `DateStringConverter` after it was removed already in
> `DateTimeStringConverter`, and `getNumberFormat()` in `NumberStringConverter`
> (and subclasses).
No, they
On Tue, 21 Nov 2023 21:11:43 GMT, Nir Lisker wrote:
> Deprecating for removal `getDateFormat()` in `TimeStringConverter` and
> `DateStringConverter` after it was removed already in
> `DateTimeStringConverter`, and `getNumberFormat()` in `NumberStringConverter`
> (and subclasses).
The
On Tue, 21 Nov 2023 21:11:43 GMT, Nir Lisker wrote:
> Deprecating for removal `getDateFormat()` in `TimeStringConverter` and
> `DateStringConverter` after it was removed already in
> `DateTimeStringConverter`, and `getNumberFormat()` in `NumberStringConverter`
> (and subclasses).
On Tue, 21 Nov 2023 21:11:43 GMT, Nir Lisker wrote:
> Deprecating for removal `getDateFormat()` in `DateTimeStringConverter` and
> `DateTimeStringConverter` after it was removed already in
> `DateTimeStringConverter`, and `getNumberFormat()` in `NumberStringConverter`
> (and subclasses).
On Tue, 21 Nov 2023 21:47:36 GMT, Andy Goryachev wrote:
> Are we going to make all these private at some point?
They are going to be made package-private so that they are not public API while
still can be read by subclasses. There's no "internal protected" visibility
that would be ideal here.
On Tue, 21 Nov 2023 21:11:43 GMT, Nir Lisker wrote:
> Deprecating for removal `getDateFormat()` in `DateTimeStringConverter` and
> `DateTimeStringConverter` after it was removed already in
> `DateTimeStringConverter`, and `getNumberFormat()` in `NumberStringConverter`
> (and subclasses).
Are
Deprecating for removal `getDateFormat()` in `DateTimeStringConverter` and
`DateTimeStringConverter` after it was removed already in
`DateTimeStringConverter`, and `getNumberFormat()` in `NumberStringConverter`
(and subclasses).
-
Commit messages:
- Deprecate protected methods
15 matches
Mail list logo