On Thu, 22 Feb 2024 10:33:38 GMT, Karthik P K wrote:
>> A valid concern about specific fonts, similar to
>> https://github.com/openjdk/jfx/pull/1236#issuecomment-1937022815
>>
>> What was the resolution there? To use a hard-coded font based on the
>> platform, or pick an available one from th
On Tue, 20 Feb 2024 15:48:26 GMT, Andy Goryachev wrote:
>> I see that the tests don't run on all the platforms. I will look into this
>> and update the PR
>
> A valid concern about specific fonts, similar to
> https://github.com/openjdk/jfx/pull/1236#issuecomment-1937022815
>
> What was the re
On Wed, 21 Feb 2024 18:59:02 GMT, John Hendrikx wrote:
> I'm unclear on this part, do you mean it's possible that multiple `Text`
> objects could be hit at the same time? There should only be one `TextRun` at
> a certain x/y coordinate right?
>
Yes there will be one TextRun at a certain x/y co
On Wed, 21 Feb 2024 13:03:46 GMT, Karthik P K wrote:
> > To determine the runStart/runEnd, `Text` is already analyzing the runs (and
> > doing coordinate tests on them). Runs however have locations, with x/y
> > coordinates. Would it not be possible, and more sensible, to adjust the
> > `x`, `
On Mon, 19 Feb 2024 14:32:36 GMT, John Hendrikx wrote:
> To determine the runStart/runEnd, `Text` is already analyzing the runs (and
> doing coordinate tests on them). Runs however have locations, with x/y
> coordinates. Would it not be possible, and more sensible, to adjust the `x`,
> `y` coo
On Mon, 19 Feb 2024 10:21:52 GMT, Karthik P K wrote:
>> tests/system/src/test/java/test/robot/javafx/scene/RTLTextCharacterIndexTest.java
>> line 107:
>>
>>> 105: */
>>> 106:
>>> 107: public class RTLTextCharacterIndexTest {
>>
>> This is a system test, which don't run with the build system.
On Mon, 19 Feb 2024 14:32:36 GMT, John Hendrikx wrote:
>Okay, so let me summarize (and let me know if that's correct)
@hjohn you have summarised it correctly. I understood your concern and thanks
for explaining your suggestion it in details. I will look into this approach
and get back to you.
On Mon, 19 Feb 2024 13:45:00 GMT, Karthik P K wrote:
> > @karthikpandelu You mentioned there is special casing going on when a
> > `Text` is part of a `TextFlow`. What are those cases and where is this
> > happening? How does it even know that a `Text` is involved and that it is
> > part of a
On Thu, 15 Feb 2024 10:36:51 GMT, Karthik P K wrote:
>> I think we should simplify the `getHitInfo` method in the `TextLayout`
>> interface.
>>
>> The code currently seems to be making distinctions where there are none.
>> `TextFlow`s provide spans, while `Text`s provide a text. `getHitInfo`
On Thu, 15 Feb 2024 10:36:51 GMT, Karthik P K wrote:
>> I think we should simplify the `getHitInfo` method in the `TextLayout`
>> interface.
>>
>> The code currently seems to be making distinctions where there are none.
>> `TextFlow`s provide spans, while `Text`s provide a text. `getHitInfo`
On Wed, 14 Feb 2024 04:39:04 GMT, John Hendrikx wrote:
>> Karthik P K has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Review comments
>
> modules/javafx.graphics/src/main/java/com/sun/javafx/text/PrismTextLayout.java
> line 432:
>
>> 4
On Wed, 14 Feb 2024 04:33:00 GMT, John Hendrikx wrote:
>> Karthik P K has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Review comments
>
> modules/javafx.graphics/src/main/java/com/sun/javafx/text/PrismTextLayout.java
> line 424:
>
>> 4
On Wed, 14 Feb 2024 04:27:42 GMT, John Hendrikx wrote:
>> Karthik P K has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Review comments
>
> modules/javafx.graphics/src/main/java/com/sun/javafx/scene/text/TextLayout.java
> line 213:
>
>>
On Thu, 15 Feb 2024 10:36:51 GMT, Karthik P K wrote:
> > I think we should simplify the `getHitInfo` method in the `TextLayout`
> > interface.
> > The code currently seems to be making distinctions where there are none.
> > `TextFlow`s provide spans, while `Text`s provide a text. `getHitInfo` c
On Wed, 14 Feb 2024 05:27:19 GMT, John Hendrikx wrote:
> I think we should simplify the `getHitInfo` method in the `TextLayout`
> interface.
>
> The code currently seems to be making distinctions where there are none.
> `TextFlow`s provide spans, while `Text`s provide a text. `getHitInfo` can
On Fri, 9 Feb 2024 07:59:47 GMT, Karthik P K wrote:
>> In the `getHitInfo()` method of PrismTextLayout, RTL node orientation
>> conditions were not considered, hence hit test values such as character
>> index and insertion index values were incorrect.
>>
>> Added checks for RTL orientation of
On Fri, 9 Feb 2024 07:59:47 GMT, Karthik P K wrote:
>> In the `getHitInfo()` method of PrismTextLayout, RTL node orientation
>> conditions were not considered, hence hit test values such as character
>> index and insertion index values were incorrect.
>>
>> Added checks for RTL orientation of
> In the `getHitInfo()` method of PrismTextLayout, RTL node orientation
> conditions were not considered, hence hit test values such as character index
> and insertion index values were incorrect.
>
> Added checks for RTL orientation of nodes and fixed the issue in
> `getHitInfo()` to calculat
18 matches
Mail list logo
