Re: RFR: 8319844 : Text/TextFlow.hitTest() is incorrect in RTL orientation [v9]

2024-02-08 Thread Andy Goryachev
On Tue, 6 Feb 2024 10:31:18 GMT, Karthik P K wrote: >> In the `getHitInfo()` method of PrismTextLayout, RTL node orientation >> conditions were not considered, hence hit test values such as character >> index and insertion index values were incorrect. >> >> Added checks for RTL orientation of

Re: RFR: 8319844 : Text/TextFlow.hitTest() is incorrect in RTL orientation [v9]

2024-02-06 Thread Karthik P K
On Tue, 6 Feb 2024 18:09:40 GMT, Andy Goryachev wrote: > Fails with "Emojis" data set (magenta line indicates where): > I forgot to mention that I didn't test with emojis. I wanted to make it work with text with all scenario and then move to emojis. Now that we have text related issues fixed,

Re: RFR: 8319844 : Text/TextFlow.hitTest() is incorrect in RTL orientation [v9]

2024-02-06 Thread Andy Goryachev
On Tue, 6 Feb 2024 10:31:18 GMT, Karthik P K wrote: >> In the `getHitInfo()` method of PrismTextLayout, RTL node orientation >> conditions were not considered, hence hit test values such as character >> index and insertion index values were incorrect. >> >> Added checks for RTL orientation of

Re: RFR: 8319844 : Text/TextFlow.hitTest() is incorrect in RTL orientation [v9]

2024-02-06 Thread Andy Goryachev
On Tue, 6 Feb 2024 10:31:18 GMT, Karthik P K wrote: >> In the `getHitInfo()` method of PrismTextLayout, RTL node orientation >> conditions were not considered, hence hit test values such as character >> index and insertion index values were incorrect. >> >> Added checks for RTL orientation of

Re: RFR: 8319844 : Text/TextFlow.hitTest() is incorrect in RTL orientation [v9]

2024-02-06 Thread Karthik P K
> In the `getHitInfo()` method of PrismTextLayout, RTL node orientation > conditions were not considered, hence hit test values such as character index > and insertion index values were incorrect. > > Added checks for RTL orientation of nodes and fixed the issue in > `getHitInfo()` to calculat