Re: RFR: 8320796: CssMetaData.initStyleables() [v3]

2023-11-27 Thread Michael Strauß
On Tue, 28 Nov 2023 00:26:32 GMT, Andy Goryachev wrote: >> Provides a public utility method for use by the skins (core and custom) to >> simplify initialization of styleable properties. >> >> >> + /** >> + * Utility method which combines CssMetaData items in one unmodifiable list >> with the

Re: RFR: 8320796: CssMetaData.initStyleables() [v2]

2023-11-27 Thread Andy Goryachev
On Mon, 27 Nov 2023 21:39:31 GMT, Andy Goryachev wrote: >> Provides a public utility method for use by the skins (core and custom) to >> simplify initialization of styleable properties. >> >> >> + /** >> + * Utility method which combines CssMetaData items in one unmodifiable list >> with the

Re: RFR: 8320796: CssMetaData.initStyleables() [v3]

2023-11-27 Thread Andy Goryachev
> Provides a public utility method for use by the skins (core and custom) to > simplify initialization of styleable properties. > > > + /** > + * Utility method which combines CssMetaData items in one unmodifiable list > with the size equal to the number > + * of items it holds (i.e. with no un

Re: RFR: 8320796: CssMetaData.initStyleables() [v2]

2023-11-27 Thread Kevin Rushforth
On Mon, 27 Nov 2023 21:39:31 GMT, Andy Goryachev wrote: >> Provides a public utility method for use by the skins (core and custom) to >> simplify initialization of styleable properties. >> >> >> + /** >> + * Utility method which combines CssMetaData items in one unmodifiable list >> with the

Re: RFR: 8320796: CssMetaData.initStyleables() [v2]

2023-11-27 Thread Andy Goryachev
> Provides a public utility method for use by the skins (core and custom) to > simplify initialization of styleable properties. > > > + /** > + * Utility method which combines CssMetaData items in one unmodifiable list > with the size equal to the number > + * of items it holds (i.e. with no un

Re: RFR: 8320796: CssMetaData.initStyleables()

2023-11-27 Thread Andy Goryachev
On Mon, 27 Nov 2023 18:30:27 GMT, Andy Goryachev wrote: > Provides a public utility method for use by the skins (core and custom) to > simplify initialization of styleable properties. > > > + /** > + * Utility method which combines CssMetaData items in one unmodifiable list > with the size eq

Re: RFR: 8320796: CssMetaData.initStyleables()

2023-11-27 Thread Michael Strauß
On Mon, 27 Nov 2023 20:42:56 GMT, Andy Goryachev wrote: > On second thought, I don't want to craft another, array-based > UnmodifiableRandomAccessList implementation to save one indirection. Keep in > mind that ArrayList is also array-based. These indirections add up in a hot loop. What do you

Re: RFR: 8320796: CssMetaData.initStyleables()

2023-11-27 Thread Andy Goryachev
On Mon, 27 Nov 2023 18:30:27 GMT, Andy Goryachev wrote: > Provides a public utility method for use by the skins (core and custom) to > simplify initialization of styleable properties. > > > + /** > + * Utility method which combines CssMetaData items in one unmodifiable list > with the size eq

Re: RFR: 8320796: CssMetaData.initStyleables()

2023-11-27 Thread Andy Goryachev
On Mon, 27 Nov 2023 19:52:25 GMT, Michael Strauß wrote: > could benefit from a bit of optimization. good point, thanks! - PR Comment: https://git.openjdk.org/jfx/pull/1296#issuecomment-1828500547

Re: RFR: 8320796: CssMetaData.initStyleables()

2023-11-27 Thread Michael Strauß
On Mon, 27 Nov 2023 18:30:27 GMT, Andy Goryachev wrote: > Provides a public utility method for use by the skins (core and custom) to > simplify initialization of styleable properties. > > > + /** > + * Utility method which combines CssMetaData items in one unmodifiable list > with the size eq

RFR: 8320796: CssMetaData.initStyleables()

2023-11-27 Thread Andy Goryachev
Provides a public utility method for use by the skins (core and custom) to simplify initialization of styleable properties. + /** + * Utility method which combines CssMetaData items in one unmodifiable list with the size equal to the number + * of items it holds (i.e. with no unnecessary overhe