On Sat, 25 May 2024 13:50:56 GMT, Kevin Rushforth wrote:
>> The code looks good. I didn't test it, but I'm fine with integrating.
>
>> Also some clarification on the contributing rules: "all Reviewers who have
>> requested the chance to review have done so" -- does the indication at the
>> top
On Fri, 24 May 2024 15:04:08 GMT, Nir Lisker wrote:
>> John Hendrikx has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Move getStyleClassNames to location it was introduced to reduce diff
>
> The code looks good. I didn't test it, but I'm
On Mon, 11 Mar 2024 16:54:25 GMT, John Hendrikx wrote:
>> Improves performance of selector matching in the CSS subsystem. This is done
>> by using custom set implementation which are highly optimized for the most
>> common cases where the number of selectors is small (most commonly 1 or 2).
>>
On Mon, 11 Mar 2024 16:54:25 GMT, John Hendrikx wrote:
>> Improves performance of selector matching in the CSS subsystem. This is done
>> by using custom set implementation which are highly optimized for the most
>> common cases where the number of selectors is small (most commonly 1 or 2).
>>
On Fri, 24 May 2024 12:12:27 GMT, Kevin Rushforth wrote:
> > > I wonder if we may want to add some tests for the `FixedCapacitySet`?
> >
> >
> > Yeah, now that it is more likely that this will make it into FX, I will add
> > a small set of unit tests for this class.
>
> Since this PR is ready
On Fri, 24 May 2024 08:22:28 GMT, John Hendrikx wrote:
> > I wonder if we may want to add some tests for the `FixedCapacitySet`?
>
> Yeah, now that it is more likely that this will make it into FX, I will add a
> small set of unit tests for this class.
Since this PR is ready to integrate, I th
On Thu, 23 May 2024 22:54:15 GMT, Marius Hanl wrote:
> Code looks good to me. As mentioned above, I tested it already and everything
> was good, so I'm certain that there is no regression here.
>
> I'm generally not a big fan of 'reimplementing' Collections, but I can see
> why it is needed he
On Thu, 23 May 2024 22:44:08 GMT, Marius Hanl wrote:
>> John Hendrikx has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Move getStyleClassNames to location it was introduced to reduce diff
>
> modules/javafx.graphics/src/main/java/javafx/c
On Mon, 11 Mar 2024 16:54:25 GMT, John Hendrikx wrote:
>> Improves performance of selector matching in the CSS subsystem. This is done
>> by using custom set implementation which are highly optimized for the most
>> common cases where the number of selectors is small (most commonly 1 or 2).
>>
On Mon, 11 Mar 2024 16:54:25 GMT, John Hendrikx wrote:
>> Improves performance of selector matching in the CSS subsystem. This is done
>> by using custom set implementation which are highly optimized for the most
>> common cases where the number of selectors is small (most commonly 1 or 2).
>>
On Mon, 11 Mar 2024 16:54:25 GMT, John Hendrikx wrote:
>> Improves performance of selector matching in the CSS subsystem. This is done
>> by using custom set implementation which are highly optimized for the most
>> common cases where the number of selectors is small (most commonly 1 or 2).
>>
On Mon, 11 Mar 2024 16:54:25 GMT, John Hendrikx wrote:
>> Improves performance of selector matching in the CSS subsystem. This is done
>> by using custom set implementation which are highly optimized for the most
>> common cases where the number of selectors is small (most commonly 1 or 2).
>>
On Mon, 11 Mar 2024 16:54:25 GMT, John Hendrikx wrote:
>> Improves performance of selector matching in the CSS subsystem. This is done
>> by using custom set implementation which are highly optimized for the most
>> common cases where the number of selectors is small (most commonly 1 or 2).
>>
On Mon, 11 Mar 2024 16:54:25 GMT, John Hendrikx wrote:
>> Improves performance of selector matching in the CSS subsystem. This is done
>> by using custom set implementation which are highly optimized for the most
>> common cases where the number of selectors is small (most commonly 1 or 2).
>>
14 matches
Mail list logo
