Re: RFR: 8324658: Allow animation play/start/stop/pause methods to be called on any thread [v2]

2024-01-27 Thread Kevin Rushforth
On Sat, 27 Jan 2024 15:48:02 GMT, Nir Lisker wrote: >> modules/javafx.graphics/src/main/java/javafx/animation/Timeline.java line >> 196: >> >>> 194: @Override >>> 195: void stopOnFxThread() { >>> 196: // The parent check is redone in the super method. Consider >>> refactoring.

Re: RFR: 8324658: Allow animation play/start/stop/pause methods to be called on any thread [v2]

2024-01-27 Thread Nir Lisker
On Sat, 27 Jan 2024 15:40:53 GMT, Kevin Rushforth wrote: >> Nir Lisker has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Doc changes to AnimationTimer methods > > modules/javafx.graphics/src/main/java/javafx/animation/Timeline.java line 19

Re: RFR: 8324658: Allow animation play/start/stop/pause methods to be called on any thread [v2]

2024-01-27 Thread Kevin Rushforth
On Sat, 27 Jan 2024 15:11:44 GMT, Nir Lisker wrote: >> Added a utility method to run code on the FX thread if it's not already, and >> changed the animation methods to use it. > > Nir Lisker has updated the pull request incrementally with one additional > commit since the last revision: > >

Re: RFR: 8324658: Allow animation play/start/stop/pause methods to be called on any thread [v2]

2024-01-27 Thread Nir Lisker
> Added a utility method to run code on the FX thread if it's not already, and > changed the animation methods to use it. Nir Lisker has updated the pull request incrementally with one additional commit since the last revision: Doc changes to AnimationTimer methods - Changes: