Re: [jfx22] RFR: 8324879: Platform-specific preferences keys are incorrect for Windows toolkit

2024-01-30 Thread Kevin Rushforth
On Tue, 30 Jan 2024 19:21:50 GMT, Michael Strauß wrote: > This pull request contains a backport of commit > [af7e0571](https://github.com/openjdk/jfx/commit/af7e05716711d942df20eb1f807b384810a4a839) > from the [openjdk/jfx](https://git.openjdk.org/jfx) repository. > > The commit being backport

[jfx22] RFR: 8324879: Platform-specific preferences keys are incorrect for Windows toolkit

2024-01-30 Thread Michael Strauß
This pull request contains a backport of commit [af7e0571](https://github.com/openjdk/jfx/commit/af7e05716711d942df20eb1f807b384810a4a839) from the [openjdk/jfx](https://git.openjdk.org/jfx) repository. The commit being backported was authored by Michael Strauß on 30 Jan 2024 and was reviewed b

Re: RFR: 8324879: Platform-specific preferences keys are incorrect for Windows toolkit

2024-01-30 Thread Andy Goryachev
On Tue, 30 Jan 2024 00:53:51 GMT, Michael Strauß wrote: > `WinApplication` contains mappings of platform-specific preference keys to > platform-independent keys. > These keys are incorrect (for example, `Windows.UIColor.ForegroundColor` > instead of `Windows.UIColor.Foreground`). > > This was

Re: RFR: 8324879: Platform-specific preferences keys are incorrect for Windows toolkit

2024-01-30 Thread Andy Goryachev
On Tue, 30 Jan 2024 00:53:51 GMT, Michael Strauß wrote: > `WinApplication` contains mappings of platform-specific preference keys to > platform-independent keys. > These keys are incorrect (for example, `Windows.UIColor.ForegroundColor` > instead of `Windows.UIColor.Foreground`). > > This was

Re: RFR: 8324879: Platform-specific preferences keys are incorrect for Windows toolkit

2024-01-30 Thread Andy Goryachev
On Tue, 30 Jan 2024 01:10:56 GMT, Kevin Rushforth wrote: > do you want to be the second reviewer? will do - PR Comment: https://git.openjdk.org/jfx/pull/1353#issuecomment-1917335686

Re: RFR: 8324879: Platform-specific preferences keys are incorrect for Windows toolkit

2024-01-29 Thread Kevin Rushforth
On Tue, 30 Jan 2024 00:53:51 GMT, Michael Strauß wrote: > `WinApplication` contains mappings of platform-specific preference keys to > platform-independent keys. > These keys are incorrect (for example, `Windows.UIColor.ForegroundColor` > instead of `Windows.UIColor.Foreground`). > > This was

Re: RFR: 8324879: Platform-specific preferences keys are incorrect for Windows toolkit

2024-01-29 Thread Kevin Rushforth
On Tue, 30 Jan 2024 00:53:51 GMT, Michael Strauß wrote: > `WinApplication` contains mappings of platform-specific preference keys to > platform-independent keys. > These keys are incorrect (for example, `Windows.UIColor.ForegroundColor` > instead of `Windows.UIColor.Foreground`). > > This was

RFR: 8324879: Platform-specific preferences keys are incorrect for Windows toolkit

2024-01-29 Thread Michael Strauß
`WinApplication` contains mappings of platform-specific preference keys to platform-independent keys. These keys are incorrect (for example, `Windows.UIColor.ForegroundColor` instead of `Windows.UIColor.Foreground`). This was not discovered during testing because the manual test application doe