On Wed, 24 Apr 2024 15:26:27 GMT, Kevin Rushforth wrote:
>> Interesting = @kevinrushforth what do you think?
>
> An excellent question. If it is robust, then it seems OK. Using Junit5
> Assumptions is more flexible, though, so might lean toward wanting to use
> that. Either way, test this on th
On Tue, 23 Apr 2024 19:00:49 GMT, Andy Goryachev wrote:
>> tests/system/src/test/java/test/com/sun/glass/ui/win/WinTextRangeProviderTest.java
>> line 48:
>>
>>> 46: import static org.junit.jupiter.api.Assertions.assertEquals;
>>> 47:
>>> 48: @EnabledOnOs({OS.WINDOWS})
>>
>> I did not use `Pla
On Tue, 23 Apr 2024 17:42:03 GMT, Oliver Kopp wrote:
>> Oliver Kopp has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Add missing exports
>
> tests/system/src/test/java/test/com/sun/glass/ui/win/WinTextRangeProviderTest.java
> line 48:
>
On Tue, 23 Apr 2024 12:17:55 GMT, Oliver Kopp wrote:
>> Fixes https://bugs.openjdk.org/browse/JDK-8330462.
>>
>> If the parameter `maxLength` is larger than `Integer.MAX_VALUE - start`,
>> then an addition of `start` to it leads to a negative value. This is "fixed"
>> by using `Math.max` compa
On Tue, 23 Apr 2024 12:17:55 GMT, Oliver Kopp wrote:
>> Fixes https://bugs.openjdk.org/browse/JDK-8330462.
>>
>> If the parameter `maxLength` is larger than `Integer.MAX_VALUE - start`,
>> then an addition of `start` to it leads to a negative value. This is "fixed"
>> by using `Math.max` compa
> Fixes https://bugs.openjdk.org/browse/JDK-8330462.
>
> If the parameter `maxLength` is larger than `Integer.MAX_VALUE - start`, then
> an addition of `start` to it leads to a negative value. This is "fixed" by
> using `Math.max` comparing the `maxLength` and `maxLength + start`.
Oliver Kopp h