Re: RFR: JDK-8296387: [Tooltip, CSS] -fx-show-delay is only applied to the first tooltip that is shown before it is displayed [v2]

2024-03-09 Thread Marius Hanl
On Fri, 8 Mar 2024 22:59:42 GMT, Andy Goryachev wrote: > This is another, unrelated issue: If I specify a number instead of duration > like `-fx-show-delay: 1;` we'll get an exception every time the tooltip is > about to be shown. This is because the CSS implementation thinks it is a PX value

Re: RFR: JDK-8296387: [Tooltip, CSS] -fx-show-delay is only applied to the first tooltip that is shown before it is displayed [v2]

2024-03-09 Thread Marius Hanl
On Sat, 9 Mar 2024 04:07:45 GMT, John Hendrikx wrote: > Perhaps we should open an issue to solve this for all controls in one go? A > solution that would prevent **any** `Node` from being displayed without CSS > applied? Yes, that sounds like a good idea. Checking the calls to `applyCss`, it

Re: RFR: JDK-8296387: [Tooltip, CSS] -fx-show-delay is only applied to the first tooltip that is shown before it is displayed [v2]

2024-03-09 Thread Marius Hanl
On Fri, 8 Mar 2024 22:36:19 GMT, Andy Goryachev wrote: > What I see is the very first time the tooltip appears it's using the old > show-delay value of 1000ms. Any subsequent attempts the new delay is in > effect. > > Then, change back to 1000ms. Same thing happens: the first time the old >

Re: RFR: JDK-8296387: [Tooltip, CSS] -fx-show-delay is only applied to the first tooltip that is shown before it is displayed [v2]

2024-03-08 Thread John Hendrikx
On Fri, 8 Mar 2024 16:10:26 GMT, Marius Hanl wrote: >> This PR fixes a long standing issue where the `Tooltip` will always wait one >> second until it appears the very first time, even if the >> `-fx-show-delay` was set to another value. >> >> The culprit is, that the `cssForced` flag is not

Re: RFR: JDK-8296387: [Tooltip, CSS] -fx-show-delay is only applied to the first tooltip that is shown before it is displayed [v2]

2024-03-08 Thread Andy Goryachev
On Fri, 8 Mar 2024 16:10:26 GMT, Marius Hanl wrote: >> This PR fixes a long standing issue where the `Tooltip` will always wait one >> second until it appears the very first time, even if the >> `-fx-show-delay` was set to another value. >> >> The culprit is, that the `cssForced` flag is not

Re: RFR: JDK-8296387: [Tooltip, CSS] -fx-show-delay is only applied to the first tooltip that is shown before it is displayed [v2]

2024-03-08 Thread Andy Goryachev
On Fri, 8 Mar 2024 16:10:26 GMT, Marius Hanl wrote: >> This PR fixes a long standing issue where the `Tooltip` will always wait one >> second until it appears the very first time, even if the >> `-fx-show-delay` was set to another value. >> >> The culprit is, that the `cssForced` flag is not

Re: RFR: JDK-8296387: [Tooltip, CSS] -fx-show-delay is only applied to the first tooltip that is shown before it is displayed [v2]

2024-03-08 Thread Andy Goryachev
On Fri, 8 Mar 2024 16:10:26 GMT, Marius Hanl wrote: >> This PR fixes a long standing issue where the `Tooltip` will always wait one >> second until it appears the very first time, even if the >> `-fx-show-delay` was set to another value. >> >> The culprit is, that the `cssForced` flag is not

Re: RFR: JDK-8296387: [Tooltip, CSS] -fx-show-delay is only applied to the first tooltip that is shown before it is displayed [v2]

2024-03-08 Thread Andy Goryachev
On Fri, 8 Mar 2024 16:10:26 GMT, Marius Hanl wrote: >> This PR fixes a long standing issue where the `Tooltip` will always wait one >> second until it appears the very first time, even if the >> `-fx-show-delay` was set to another value. >> >> The culprit is, that the `cssForced` flag is not

Re: RFR: JDK-8296387: [Tooltip, CSS] -fx-show-delay is only applied to the first tooltip that is shown before it is displayed [v2]

2024-03-08 Thread Marius Hanl
> This PR fixes a long standing issue where the `Tooltip` will always wait one > second until it appears the very first time, even if the > `-fx-show-delay` was set to another value. > > The culprit is, that the `cssForced` flag is not inside `Tooltip`, but inside > the `TooltipBehaviour`. So