Re: RFR: JDK-8297412: Remove easy warnings in javafx.fxml, javafx.media, javafx.swing, javafx.swt and javafx.web [v4]

2022-11-23 Thread Nir Lisker
On Tue, 22 Nov 2022 18:52:32 GMT, John Hendrikx wrote: >> modules/javafx.fxml/src/main/java/javafx/fxml/FXMLLoader.java line 1446: >> >>> 1444: @Override >>> 1445: public void processEndElement() throws IOException { >>> 1446: super.processEndElement(); >> >> I

Re: RFR: JDK-8297412: Remove easy warnings in javafx.fxml, javafx.media, javafx.swing, javafx.swt and javafx.web [v4]

2022-11-22 Thread Kevin Rushforth
On Tue, 22 Nov 2022 19:06:47 GMT, John Hendrikx wrote: >> - Remove unsupported/unnecessary SuppressWarning annotations >> - Remove reduntant type specifications (use diamond operator) >> - Remove unused or duplicate imports >> - Remove unnecessary casts (type is already correct type or can be

Re: RFR: JDK-8297412: Remove easy warnings in javafx.fxml, javafx.media, javafx.swing, javafx.swt and javafx.web [v4]

2022-11-22 Thread Kevin Rushforth
On Tue, 22 Nov 2022 18:35:36 GMT, Andy Goryachev wrote: >> John Hendrikx has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fix indent of 5 spaces to 4 spaces > > modules/javafx.fxml/src/main/java/javafx/fxml/FXMLLoader.java line 1446: >

Re: RFR: JDK-8297412: Remove easy warnings in javafx.fxml, javafx.media, javafx.swing, javafx.swt and javafx.web [v4]

2022-11-22 Thread John Hendrikx
> - Remove unsupported/unnecessary SuppressWarning annotations > - Remove reduntant type specifications (use diamond operator) > - Remove unused or duplicate imports > - Remove unnecessary casts (type is already correct type or can be autoboxed) > - Remove unnecessary semi-colons (at end of class