On Wed, 30 Nov 2022 12:48:10 GMT, Kevin Rushforth wrote:
>> If the casts in the numerator actually matter, then the cast in the
>> denominator can be removed. The latter are the ones that Eclipse flags for
>> me as unnecessary.
>
> I still think that any change here would be a very low value
On Wed, 30 Nov 2022 12:48:10 GMT, Kevin Rushforth wrote:
>> If the casts in the numerator actually matter, then the cast in the
>> denominator can be removed. The latter are the ones that Eclipse flags for
>> me as unnecessary.
>
> I still think that any change here would be a very low value
On Tue, 29 Nov 2022 16:50:00 GMT, Kevin Rushforth wrote:
>> John Hendrikx has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix indentation
>
> modules/javafx.graphics/src/main/java/com/sun/javafx/tk/quantum/RotateGestureRecognizer.java
>
On Tue, 22 Nov 2022 21:28:44 GMT, Kevin Rushforth wrote:
>> John Hendrikx has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix indentation
>
> modules/javafx.graphics/src/main/java/com/sun/javafx/tk/quantum/UploadingPainter.java
> line
On Mon, 28 Nov 2022 13:39:05 GMT, John Hendrikx wrote:
>> - Remove unsupported/unnecessary SuppressWarning annotations
>> - Remove reduntant type specifications (use diamond operator)
>> - Remove unused or duplicate imports
>> - Remove unnecessary casts (type is already correct type or can be
On Wed, 30 Nov 2022 03:19:54 GMT, Nir Lisker wrote:
>> modules/javafx.graphics/src/main/java/com/sun/javafx/tk/quantum/WindowStage.java
>> line 418:
>>
>>> 416: scaleFactor = 1.0 / scaleDivider;
>>> 417: adjw = (int)Math.round(iw / scaleDivider);
>>>
On Tue, 22 Nov 2022 21:30:09 GMT, Kevin Rushforth wrote:
>> John Hendrikx has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix indentation
>
> modules/javafx.graphics/src/main/java/com/sun/javafx/tk/quantum/WindowStage.java
> line 418:
On Tue, 29 Nov 2022 17:11:51 GMT, Kevin Rushforth wrote:
>> John Hendrikx has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix indentation
>
> modules/javafx.graphics/src/main/java/com/sun/javafx/tk/quantum/WindowStage.java
> line 422:
On Wed, 23 Nov 2022 16:49:50 GMT, Andy Goryachev wrote:
>> You are correct that with these kind of changes you can't see if it is
>> correct just from looking at the diff. Variables would need to be named more
>> explicitly, or explicit casts would need to be added to repeat the type
>>
On Tue, 22 Nov 2022 21:34:44 GMT, Kevin Rushforth wrote:
>> John Hendrikx has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix indentation
>
> modules/javafx.graphics/src/main/java/com/sun/prism/es2/ES2VramPool.java line
> 54:
>
>> 52:
On Mon, 28 Nov 2022 13:39:05 GMT, John Hendrikx wrote:
>> - Remove unsupported/unnecessary SuppressWarning annotations
>> - Remove reduntant type specifications (use diamond operator)
>> - Remove unused or duplicate imports
>> - Remove unnecessary casts (type is already correct type or can be
On Sat, 26 Nov 2022 19:24:21 GMT, Nir Lisker wrote:
>> The cast has precedence and Java will not downcast mid calculation and lose
>> precision, so all examples here are correct.
>
> `4L * physicalWidth * physicalHeight;` does not require an explicit cast, so
> I think it's the clearest.
That
> - Remove unsupported/unnecessary SuppressWarning annotations
> - Remove reduntant type specifications (use diamond operator)
> - Remove unused or duplicate imports
> - Remove unnecessary casts (type is already correct type or can be autoboxed)
> - Remove unnecessary semi-colons (at end of class
13 matches
Mail list logo